From mboxrd@z Thu Jan 1 00:00:00 1970 From: Francisco Jerez Subject: Re: [PATCH] drm/i915/hsw: Disable L3 caching of atomic memory operations. Date: Wed, 02 Oct 2013 15:31:40 -0700 Message-ID: <87ioxfuwxf.fsf@riseup.net> References: <1380751423-6255-1-git-send-email-currojerez@riseup.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0533759998==" Return-path: Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by gabe.freedesktop.org (Postfix) with ESMTP id 8956FE5DF6 for ; Wed, 2 Oct 2013 15:35:05 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org --===============0533759998== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Daniel Vetter writes: > On Thu, Oct 3, 2013 at 12:03 AM, Francisco Jerez = wrote: >> + case I915_PARAM_HAS_ATOMICS: >> + value =3D 1; >> + break; > > Generally when we do kernel fixes for gpu hangs like that we don't add > parameters (would drown in them otherwise) but simply queue it up to > -fixes and slap a cc: stable on it. Gpu hang fixes are critical enough > imo for that treatment, even when it's for brand new userspace code. > > Any specific reason why we shouldn't follow this approach here? I'd > make the patch simpler and we could dump a bit of userspace code, too. > -Daniel Not really, I'm fine either way. I'll send a revised version of this patch without the param change. Thanks. > --=20 > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (GNU/Linux) iF4EAREIAAYFAlJMntIACgkQg5k4nX1Sv1vKOQD8CwE/M1NRxUp95SPqVnUcNyak 4TFlEIbZoYvoGhFM5PUA/iHTXtDkxfZgI3WZIYxp46dpk1aLH7Jx++jd+RyVluIU =yTX1 -----END PGP SIGNATURE----- --==-=-=-- --===============0533759998== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0533759998==--