From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69917EB64D7 for ; Mon, 26 Jun 2023 12:23:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C231310E04B; Mon, 26 Jun 2023 12:23:52 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1721410E04B for ; Mon, 26 Jun 2023 12:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687782231; x=1719318231; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=tGtYRN4b7lRlvDvmKI5Q+CEJjEbPv46LrjEnab2n0CU=; b=j/0Jw9R2vBmk1JcxeCdDN2WPb/ji5IJ5MCLvmhAQBG3ZIp/PXRxjsoto vjNZ08klZtBG3AS6XQRMXZNern8QWJRJ44BU/ydEes5UuhmUors1PLzsr mZWarm9GNLml8hpMH0MWsiacikvyk3lbJyNhTa1T4hfsVfLU88+eCg/jL yGhV+iKtP4KWqWi8NXOjsm/a1XxxJwPrk/3jP4dSRJ8gYlRf8lLMHmPTe QyA6+sicsLpdEZ4yWJsXSnpClyyZ0h82McZRyBQwgcMFQso/XkmgWe5DQ 9L0HKrUYofnfvbfLPxX1cN3AFj/YbfO+33GQiGHNz4VDTXQYKkPxqsfI1 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="360116358" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="360116358" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 05:23:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="693457589" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="693457589" Received: from avhiruda-mobl1.amr.corp.intel.com (HELO localhost) ([10.252.41.186]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 05:23:45 -0700 From: Jani Nikula To: Chaitanya Kumar Borah , intel-gfx@lists.freedesktop.org In-Reply-To: <20230626055444.1113796-3-chaitanya.kumar.borah@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230626055444.1113796-1-chaitanya.kumar.borah@intel.com> <20230626055444.1113796-3-chaitanya.kumar.borah@intel.com> Date: Mon, 26 Jun 2023 15:23:26 +0300 Message-ID: <87jzvqv2dd.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/color: For MTL convert 24 bit lut values to 16 bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 26 Jun 2023, Chaitanya Kumar Borah wrote: > For MTL and beyond, convert back the 24 bit lut values > read from HW to 16 bit values to maintain parity with > userspace values. This way we avoid pipe config mismatch > for pre-csc lut values. > > Signed-off-by: Chaitanya Kumar Borah > --- > drivers/gpu/drm/i915/display/intel_color.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c > index 25c73e2e6fa3..856191640e71 100644 > --- a/drivers/gpu/drm/i915/display/intel_color.c > +++ b/drivers/gpu/drm/i915/display/intel_color.c > @@ -3477,6 +3477,14 @@ static struct drm_property_blob *glk_read_degamma_lut(struct intel_crtc *crtc) > for (i = 0; i < lut_size; i++) { > u32 val = intel_de_read_fw(dev_priv, PRE_CSC_GAMC_DATA(pipe)); > > + /* > + * For MTL and beyond, convert back the 24 bit lut values > + * read from HW to 16 bit values to maintain parity with > + * userspace values > + */ > + if (DISPLAY_VER(dev_priv) >= 14) > + val = mul_u32_u32(val, (1 << 16)) / (1 << 24); > + Here too please add a small helper for the conversion. BR, Jani. > lut[i].red = val; > lut[i].green = val; > lut[i].blue = val; -- Jani Nikula, Intel Open Source Graphics Center