From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E7B0C74A5B for ; Fri, 17 Mar 2023 03:43:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ADF9210E02C; Fri, 17 Mar 2023 03:43:49 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 409C910E02C for ; Fri, 17 Mar 2023 03:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679024628; x=1710560628; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=ilQMLNj8SxmwTU7lkD/9QyCYMuIGXjMrbkKZx6j9oDs=; b=nofXnSoaiVChtTI2mnjh25l2CUXThqv9bMvMejbgi8LqOu2WRucMOc9v QPt+eIp9O01GbuVPLqhDgqJQ0lErtHH1FHQJLY9YMsdRYUxpzMc7RvKVI MCPS+nZLVU3V/tSRjCCLYxn3LIR4WV5vVib8W7vOk/gkX7co6EXfZ20lV W9+KDB3zFGPjyV/P8c4OFgSR5WmMzHwxDg1v4kIzaWD9ehPxu/j0+/v/s fF6/WqYqoqxh7ESGcemz7SMBKD4ATkyS4GBGcpCVxYP+fYncLE4zqq9fH 9CezwOFyZqVNWbUAHUPGNcbNdrp1zsa/HKQi/loai1cKfW7srhgy8z02i A==; X-IronPort-AV: E=McAfee;i="6600,9927,10651"; a="400755709" X-IronPort-AV: E=Sophos;i="5.98,267,1673942400"; d="scan'208";a="400755709" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2023 20:43:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10651"; a="803971585" X-IronPort-AV: E=Sophos;i="5.98,267,1673942400"; d="scan'208";a="803971585" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.119.150]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2023 20:43:39 -0700 Date: Thu, 16 Mar 2023 20:43:39 -0700 Message-ID: <87jzzgvy8k.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <20230316010101.2590309-3-umesh.nerlige.ramappa@intel.com> References: <20230316010101.2590309-1-umesh.nerlige.ramappa@intel.com> <20230316010101.2590309-3-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v6 02/12] drm/i915/mtl: Synchronize i915/BIOS on C6 enabling X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 15 Mar 2023 18:00:51 -0700, Umesh Nerlige Ramappa wrote: > > From: Vinay Belgaumkar Hi Vinay, > If BIOS enables/disables C6, i915 should do the same. So MTL bios has a control for enabling/disabling C6? Both RC6 and MC6 individually or collectively? What happens if bios has disabled RC6 and i915 enables it: just that it will bust OA? The patch itself LGTM if the above is true, I can R-b it after I hear about the above. Thanks. -- Ashutosh > Also, retain this value across driver reloads. This is needed only for > MTL as of now due to an existing bug in OA which needs C6 disabled for it > to function. BIOS behavior is also different across platforms in terms of > how C6 is enabled. > > Signed-off-by: Vinay Belgaumkar