From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33EABC433EF for ; Wed, 20 Jul 2022 05:39:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 66B5611AA72; Wed, 20 Jul 2022 05:39:13 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 087AB11AA72 for ; Wed, 20 Jul 2022 05:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658295552; x=1689831552; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=cvwlrbbZfn84wMWRhlBEttFhOpiQ+s6YwVZ5Ku+v7/0=; b=S5x8O+zrwmIaWtaid5Ze73cn8nlu7bGct36n24ISp7dXfQ/Hf98Elv+E PPO0Da6EFxkHGV+AL+yvAtOzg/QkRBZdBCs0UjlvpAgoGFzgqtSt+/Qyq DT4AWPU/57m1URgmFhPMiCOrvd16/D/PZfbJ+MsQcOLxDS6jHfHgWP64Q 5xWc3QBOsIDkX9yd/Ki3prhNB+GCo9a2izoGsvrZS3o1XL6fMpzFLstQP FQIrAEY6PIfzy3CjGaygfB2npufTrjf2YGoK6cRADegub8S8BObcfj2bj vlLUq6zrwv8OHt1pBj+KwpiOwQXmBojHzgvFPdJqZga17i3WqFLAwMS9l Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="269711502" X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="269711502" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 22:39:11 -0700 X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="625515017" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.70.164]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 22:39:11 -0700 Date: Tue, 19 Jul 2022 22:39:11 -0700 Message-ID: <87k088baww.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Alan Previn In-Reply-To: <20220509210151.1843173-6-alan.previn.teres.alexis@intel.com> References: <20220509210151.1843173-1-alan.previn.teres.alexis@intel.com> <20220509210151.1843173-6-alan.previn.teres.alexis@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [Intel-gfx 5/6] drm/i915/guc: Rename GuC log relay debugfs descriptively X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 09 May 2022 14:01:50 -0700, Alan Previn wrote: > > @@ -190,11 +190,11 @@ static int guc_log_relay_release(struct inode *inode, struct file *file) > return 0; > } > > -static const struct file_operations guc_log_relay_fops = { > +static const struct file_operations guc_log_relay_ctl_fops = { > .owner = THIS_MODULE, > - .open = guc_log_relay_open, > - .write = guc_log_relay_write, > - .release = guc_log_relay_release, > + .open = guc_log_relay_ctl_open, > + .write = guc_log_relay_ctl_write, > + .release = guc_log_relay_ctl_release, > }; > > void intel_guc_log_debugfs_register(struct intel_guc_log *log, > @@ -204,7 +204,7 @@ void intel_guc_log_debugfs_register(struct intel_guc_log *log, > { "guc_log_dump", &guc_log_dump_fops, NULL }, > { "guc_load_err_log_dump", &guc_load_err_log_dump_fops, NULL }, > { "guc_log_level", &guc_log_level_fops, NULL }, > - { "guc_log_relay", &guc_log_relay_fops, NULL }, > + { "guc_log_relay_ctl", &guc_log_relay_ctl_fops, NULL }, Even though debugfs, any issue with changing the file name from the uapi point of view? Any scripts etc. which will need to be updated? > { "guc_log_relay_buf_size", &guc_log_relay_buf_size_fops, NULL }, > { "guc_log_relay_subbuf_count", &guc_log_relay_subbuf_count_fops, NULL }, > };