From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27D75C433EF for ; Wed, 18 May 2022 11:39:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1744D10E0A6; Wed, 18 May 2022 11:39:44 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D4F910E068; Wed, 18 May 2022 11:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652873982; x=1684409982; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=rjF4zWNjVkRaA4u9AigM/0O/Su6Qa+NPXOPo2kzYSB0=; b=I16iBUE0/p9kag9SgM12YwEc2hqFmYPL8AZAS77ocyah+/bwqKelCljU wm2CgLOg8cblNcjcdk8s4FfkkStGY+H9FH+wCy0d0x8sNSIDm/7tOW4st U+e9DXLcJDMiS114SUh3XJDGWz4tQjIb3EeUSJ06qBu4A8LnCtL6w32jf FXipvgY1BpRuKlvsUCw/dQeLprcAkla9VF3coPWzYRE+zCFOjFAes5/S2 p8V6/ox/QAKtLfDpLwVbCGjvSUlOB/xC1br9VzIAWdTSx5Mb2QmL9h5mB le4LsKeBQ/Z5yHaetHuKB/1aOl9u/evdMX/XlFKjpjF3kZqS7pJ2pef/z g==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="270453941" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="270453941" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 04:39:19 -0700 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="626998272" Received: from jwasiuki-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.133.47]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 04:39:16 -0700 From: Jani Nikula To: Borislav Petkov , Randy Dunlap In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220405151517.29753-1-bp@alien8.de> <20220405151517.29753-12-bp@alien8.de> <78e67e42-7e1e-e9fa-036d-441168100731@infradead.org> Date: Wed, 18 May 2022 14:39:14 +0300 Message-ID: <87k0ajdq8t.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 11/11] drm/i915: Fix undefined behavior due to shift overflowing the constant X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, LKML , dri-devel@lists.freedesktop.org, Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 18 May 2022, Borislav Petkov wrote: > On Tue, May 17, 2022 at 04:05:46PM -0700, Randy Dunlap wrote: >>=20 >>=20 >> On 4/5/22 08:15, Borislav Petkov wrote: >> > From: Borislav Petkov >> >=20 >> > Fix: >> >=20 >> > In file included from :0:0: >> > drivers/gpu/drm/i915/gt/uc/intel_guc.c: In function =E2=80=98intel_g= uc_send_mmio=E2=80=99: >> > ././include/linux/compiler_types.h:352:38: error: call to =E2=80=98_= _compiletime_assert_1047=E2=80=99 \ >> > declared with attribute error: FIELD_PREP: mask is not constant >> > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNT= ER__) >> >=20 >> > and other build errors due to shift overflowing values. >> >=20 >> > See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory >> > details as to why it triggers with older gccs only. >> >=20 >>=20 >> Acked-by: Randy Dunlap >> Tested-by: Randy Dunlap >>=20 >> Is this merged anywhere? > > It's state is "new" in their patchwork: > > https://patchwork.freedesktop.org/patch/480756/ Basically we run all patches through CI before merging, and because only one patch was sent to intel-gfx, the CI just sat waiting for the rest of the series to arrive... Anyway, didn't really like the changes in i915_reg.h, sent my version of that and the rest separately [1]. > so I guess not yet. > >> It could/should at least be in linux-next so that other people >> don't waste time on it. > > -ETOOMANYPATCHES I guess. :-\ Yeah, sorry about that. BR, Jani. [1] https://patchwork.freedesktop.org/series/104122/ --=20 Jani Nikula, Intel Open Source Graphics Center