From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5B1C433F5 for ; Wed, 27 Oct 2021 14:42:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E71360F21 for ; Wed, 27 Oct 2021 14:42:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0E71360F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 53CFF6E8AF; Wed, 27 Oct 2021 14:42:56 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 912016E8AF for ; Wed, 27 Oct 2021 14:42:54 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="293635741" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="293635741" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 07:42:54 -0700 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="497896000" Received: from smaharan-mobl.gar.corp.intel.com (HELO localhost) ([10.251.214.195]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 07:42:51 -0700 From: Jani Nikula To: "Hogander\, Jouni" , "intel-gfx\@lists.freedesktop.org" , "Souza\, Jose" Cc: "Kahola\, Mika" In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211026223329.116104-1-jose.souza@intel.com> Date: Wed, 27 Oct 2021 17:42:48 +0300 Message-ID: <87k0hyh6l3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH] drm/i915/adlp: Extend PSR2 support in transcoder B X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 27 Oct 2021, "Hogander, Jouni" wrote: > On Tue, 2021-10-26 at 15:33 -0700, Jos=C3=A9 Roberto de Souza wrote: >> PSR2 is supported in transcoder A and B on Alderlake-P. >>=20 >> BSpec: 49185 >> Cc: Mika Kahola >> Cc: Jouni Hogander >> Signed-off-by: Jos=C3=A9 Roberto de Souza > > LGTM > > Reviewed-by: Jouni H=C3=B6gander Since INVALID_TRANSCODER is a thing, I'd actually prefer: trans =3D=3D TRANSCODER_A || trans =3D=3D TRANSCODER_B It's not likely INVALID_TRANSCODER will ever end up here, but I tried to look and it's actually not trivial to say this will never happen. I prefer the defensive approach. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_psr.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >>=20 >> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c >> b/drivers/gpu/drm/i915/display/intel_psr.c >> index d35db50ef967a..710b911b065b9 100644 >> --- a/drivers/gpu/drm/i915/display/intel_psr.c >> +++ b/drivers/gpu/drm/i915/display/intel_psr.c >> @@ -588,7 +588,9 @@ static void hsw_activate_psr2(struct intel_dp >> *intel_dp) >> static bool >> transcoder_has_psr2(struct drm_i915_private *dev_priv, enum >> transcoder trans) >> { >> - if (DISPLAY_VER(dev_priv) >=3D 12) >> + if (IS_ALDERLAKE_P(dev_priv)) >> + return trans <=3D TRANSCODER_B; >> + else if (DISPLAY_VER(dev_priv) >=3D 12) >> return trans =3D=3D TRANSCODER_A; >> else >> return trans =3D=3D TRANSCODER_EDP; > --=20 Jani Nikula, Intel Open Source Graphics Center