From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFE66C433EF for ; Fri, 15 Oct 2021 14:52:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B45A660D42 for ; Fri, 15 Oct 2021 14:52:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B45A660D42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F294C6EDC3; Fri, 15 Oct 2021 14:52:49 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id C46D86EDC1; Fri, 15 Oct 2021 14:52:47 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10138"; a="226698535" X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="226698535" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 07:52:47 -0700 X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="443214826" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.132.192]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 07:52:46 -0700 Date: Fri, 15 Oct 2021 07:52:46 -0700 Message-ID: <87k0iecpc1.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Cc: , In-Reply-To: <20211014194238.1078854-1-John.C.Harrison@Intel.com> References: <20211014194238.1078854-1-John.C.Harrison@Intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [igt-dev] [PATCH v2 i-g-t] tests/i915: Skip gem_exec_fair on GuC based platforms X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 14 Oct 2021 12:42:38 -0700, wrote: > > + /* > + * These tests are for a specific scheduling model which is > + * not currently implemented by GuC. So skip on GuC platforms. > + */ > + devid = intel_get_drm_devid(i915); > + igt_require((intel_gen(devid) < 12) || IS_TIGERLAKE(devid) || > + IS_ROCKETLAKE(devid) || IS_ALDERLAKE_S(devid)); As I hinted on v1 let's just do this here: igt_require(gem_has_guc_submission(i915)); So that we can can have a single unified way of detecting if GuC is being used throughout IGT. Today it is gem_has_guc_submission() and it works with the current kernel.