From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [RFC 07/12] drm/i915: Remove I915_READ8 Date: Fri, 07 Jun 2019 16:11:39 +0300 Message-ID: <87k1dxzgj8.fsf@intel.com> References: <20190607120838.20514-1-tvrtko.ursulin@linux.intel.com> <20190607120838.20514-8-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B00AE89D63 for ; Fri, 7 Jun 2019 13:08:37 +0000 (UTC) In-Reply-To: <20190607120838.20514-8-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAwNyBKdW4gMjAxOSwgVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGlu QGludGVsLmNvbT4KPgo+IE9ubHkgYSBmZXcgY2FsbCBzaXRlcyByZW1haW4gd2hpY2ggaGF2ZSBi ZWVuIGNvbnZlcnRlZCB0byB1bmNvcmUgbW1pbwo+IGFjY2Vzc29ycyBhbmQgc28gdGhlIG1hY3Jv IGNhbiBiZSByZW1vdmVkLgo+Cj4gU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRr by51cnN1bGluQGludGVsLmNvbT4KCkkgaGF2ZSBzb21lIHJlc2VydmF0aW9ucyBhYm91dCB0aGlz IG9uZSBhbmQgcGF0Y2ggMTEuIEFnYWluLCBJJ20gZmluZQp3aXRoIG51a2luZyBJOTE1X1JFQUQ4 IGFuZCBJOTE1X1JFQURfTk9UUkFDRSAoaW4gcGF0Y2ggMTEpLiBJIHRoaW5rCnRoZXkncmUgc3Bl Y2lhbCBjYXNlcyBhbmQgaXQncyBva2F5IGlmIHRoZXkgZ3JvdyBpbnRvIGEgYml0IGxvbmdlciBs aW5lcwpvciBtdWx0aXBsZSBsaW5lcy4KClRoZSBwcm9ibGVtIGlzIGNvbnZlcnRpbmcgcmVndWxh ciBJOTE1X1JFQUQgYW5kIEk5MTVfV1JJVEUgaW4gZGlzcGxheQpjb2RlIHdoaWxlIGF0IGl0LgoK SSBkb24ndCB0aGluayBlbiBtYXNzZSBjb252ZXJzaW9uIG9mIHRoZW0gdG8gaW50ZWxfdW5jb3Jl X3JlYWQgYW5kCmludGVsX3VuY29yZV93cml0ZSBkaXJlY3RseSBpcyBnb2luZyB0byBoYXBwZW4g aW4gZGlzcGxheSBjb2RlLCBiZWNhdXNlCnRoZXJlJ3MgdG9vIG11Y2ggY29kZSB0aGF0IGdldHMg dHVybmVkIHRvbyB1Z2x5IHdpdGggdGhlIGluY3JlYXNlIGluCmZ1bmN0aW9uIG5hbWUgbGVuZ3Ro IGFuZCB0aGUgZXh0cmEgcGFzc2VkIHBhcmFtZXRlci4gSSB0aGluayBtYW55IG9mCnRob3NlIHBs YWNlcyBhcmUgcHJldHR5IHVnbHkgYXMgaXQgaXMgYWxyZWFkeS4gVGhhdCdzIG15IGZlZWxpbmcg YW55d2F5LgoKSSB1bmRlcnN0YW5kIHlvdXIgcmVhc29uaW5nIGlzIHRvIGF2b2lkIHRoZSBtaXhl ZCB1c2Ugb2YgaW50ZWxfdW5jb3JlXyoKYW5kIEk5MTVfKi4gQnV0IEkgZmVhciB1c2luZyBpbnRl bF91bmNvcmVfcmVhZCBhbmQgaW50ZWxfdW5jb3JlX3dyaXRlCm5vdyBpcyBnb2luZyB0byBwcm9t b3RlIHRoZWlyIHVzZSBhbGwgb3ZlciB0aGUgcGxhY2UsIGFuZCAqdGhhdCogd2lsbApsZWFkIHRv IG1peGVkIHVzZS4gV2hpY2ggaXMgbm90IG9wdGltYWwgaWYgdGhlIG92ZXJhbGwgZmVlbGluZyBp cyB0aGF0CndlIG5lZWQgdG8gY29tZSB1cCB3aXRoIGEgc2hvcnRlciBmdW5jdGlvbi9tYWNybyBm b3IgZGlzcGxheSBjb2RlIHJlYWRzCmFuZCB3cml0ZXMuCgpJIHByZXN1bWUgVmlsbGUgaGFzIHNv bWV0aGluZyB0byBzYXkgYWJvdXQgdGhlIGd0IHZzLiBkaXNwbGF5IHN0dWZmIGFzCndlbGw7IGRv ZXMgdGhlIHdob2xlIHNlcmllcyBtYWtlIHRoYXQgaGFyZGVyPyBJIGhvcGUgbm90LCBiZWNhdXNl IEkgZG8KbGlrZSB0aGUgcmVzdCBvZiB3aGF0J3MgYmVpbmcgZG9uZSBoZXJlLgoKCkJSLApKYW5p LgoKCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICB8ICAyIC0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NydC5jIHwgNDEgKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyAgfCAgNiAr Ky0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggYjI3NjM3MjFiNzZkLi4xMzgxNTc5 NWUxOTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMjg1Miw4ICsyODUyLDYg QEAgZXh0ZXJuIHZvaWQgaW50ZWxfZGlzcGxheV9wcmludF9lcnJvcl9zdGF0ZShzdHJ1Y3QgZHJt X2k5MTVfZXJyb3Jfc3RhdGVfYnVmICplLAo+ICAjZGVmaW5lIF9fSTkxNV9SRUdfT1Aob3BfXywg ZGV2X3ByaXZfXywgLi4uKSBcCj4gIAlpbnRlbF91bmNvcmVfIyNvcF9fKCYoZGV2X3ByaXZfXykt PnVuY29yZSwgX19WQV9BUkdTX18pCj4gIAo+IC0jZGVmaW5lIEk5MTVfUkVBRDgocmVnX18pCSAg X19JOTE1X1JFR19PUChyZWFkOCwgZGV2X3ByaXYsIChyZWdfXykpCj4gLQo+ICAjZGVmaW5lIEk5 MTVfUkVBRDE2KHJlZ19fKQkgICBfX0k5MTVfUkVHX09QKHJlYWQxNiwgZGV2X3ByaXYsIChyZWdf XykpCj4gICNkZWZpbmUgSTkxNV9XUklURTE2KHJlZ19fLCB2YWxfXykgX19JOTE1X1JFR19PUCh3 cml0ZTE2LCBkZXZfcHJpdiwgKHJlZ19fKSwgKHZhbF9fKSkKPiAgCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NydC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfY3J0LmMKPiBpbmRleCBiYjU2NTE4NTc2YTEuLjNmY2YyZjg0YmNjZSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jcnQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2NydC5jCj4gQEAgLTY0Myw2ICs2NDMsNyBAQCBpbnRlbF9jcnRfbG9hZF9k ZXRlY3Qoc3RydWN0IGludGVsX2NydCAqY3J0LCB1MzIgcGlwZSkKPiAgewo+ICAJc3RydWN0IGRy bV9kZXZpY2UgKmRldiA9IGNydC0+YmFzZS5iYXNlLmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiArCXN0cnVjdCBpbnRlbF91bmNvcmUg KnVuY29yZSA9ICZkZXZfcHJpdi0+dW5jb3JlOwo+ICAJdTMyIHNhdmVfYmNscnBhdDsKPiAgCXUz MiBzYXZlX3Z0b3RhbDsKPiAgCXUzMiB2dG90YWwsIHZhY3RpdmU7Cj4gQEAgLTY2Myw5ICs2NjQs OSBAQCBpbnRlbF9jcnRfbG9hZF9kZXRlY3Qoc3RydWN0IGludGVsX2NydCAqY3J0LCB1MzIgcGlw ZSkKPiAgCXBpcGVjb25mX3JlZyA9IFBJUEVDT05GKHBpcGUpOwo+ICAJcGlwZV9kc2xfcmVnID0g UElQRURTTChwaXBlKTsKPiAgCj4gLQlzYXZlX2JjbHJwYXQgPSBJOTE1X1JFQUQoYmNscnBhdF9y ZWcpOwo+IC0Jc2F2ZV92dG90YWwgPSBJOTE1X1JFQUQodnRvdGFsX3JlZyk7Cj4gLQl2Ymxhbmsg PSBJOTE1X1JFQUQodmJsYW5rX3JlZyk7Cj4gKwlzYXZlX2JjbHJwYXQgPSBpbnRlbF91bmNvcmVf cmVhZCh1bmNvcmUsIGJjbHJwYXRfcmVnKTsKPiArCXNhdmVfdnRvdGFsID0gaW50ZWxfdW5jb3Jl X3JlYWQodW5jb3JlLCB2dG90YWxfcmVnKTsKPiArCXZibGFuayA9IGludGVsX3VuY29yZV9yZWFk KHVuY29yZSwgdmJsYW5rX3JlZyk7Cj4gIAo+ICAJdnRvdGFsID0gKChzYXZlX3Z0b3RhbCA+PiAx NikgJiAweGZmZikgKyAxOwo+ICAJdmFjdGl2ZSA9IChzYXZlX3Z0b3RhbCAmIDB4N2ZmKSArIDE7 Cj4gQEAgLTY3NCwyMSArNjc1LDIzIEBAIGludGVsX2NydF9sb2FkX2RldGVjdChzdHJ1Y3QgaW50 ZWxfY3J0ICpjcnQsIHUzMiBwaXBlKQo+ICAJdmJsYW5rX2VuZCA9ICgodmJsYW5rID4+IDE2KSAm IDB4ZmZmKSArIDE7Cj4gIAo+ICAJLyogU2V0IHRoZSBib3JkZXIgY29sb3IgdG8gcHVycGxlLiAq Lwo+IC0JSTkxNV9XUklURShiY2xycGF0X3JlZywgMHg1MDAwNTApOwo+ICsJaW50ZWxfdW5jb3Jl X3dyaXRlKHVuY29yZSwgYmNscnBhdF9yZWcsIDB4NTAwMDUwKTsKPiAgCj4gIAlpZiAoIUlTX0dF TihkZXZfcHJpdiwgMikpIHsKPiAtCQl1MzIgcGlwZWNvbmYgPSBJOTE1X1JFQUQocGlwZWNvbmZf cmVnKTsKPiAtCQlJOTE1X1dSSVRFKHBpcGVjb25mX3JlZywgcGlwZWNvbmYgfCBQSVBFQ09ORl9G T1JDRV9CT1JERVIpOwo+IC0JCVBPU1RJTkdfUkVBRChwaXBlY29uZl9yZWcpOwo+ICsJCXUzMiBw aXBlY29uZiA9IGludGVsX3VuY29yZV9yZWFkKHVuY29yZSwgcGlwZWNvbmZfcmVnKTsKPiArCQlp bnRlbF91bmNvcmVfd3JpdGUodW5jb3JlLAo+ICsJCQkJICAgcGlwZWNvbmZfcmVnLAo+ICsJCQkJ ICAgcGlwZWNvbmYgfCBQSVBFQ09ORl9GT1JDRV9CT1JERVIpOwo+ICsJCWludGVsX3VuY29yZV9w b3N0aW5nX3JlYWQodW5jb3JlLCBwaXBlY29uZl9yZWcpOwo+ICAJCS8qIFdhaXQgZm9yIG5leHQg VmJsYW5rIHRvIHN1YnN0aXR1ZQo+ICAJCSAqIGJvcmRlciBjb2xvciBmb3IgQ29sb3IgaW5mbyAq Lwo+ICAJCWludGVsX3dhaXRfZm9yX3ZibGFuayhkZXZfcHJpdiwgcGlwZSk7Cj4gLQkJc3QwMCA9 IEk5MTVfUkVBRDgoX1ZHQV9NU1JfV1JJVEUpOwo+ICsJCXN0MDAgPSBpbnRlbF91bmNvcmVfcmVh ZDgodW5jb3JlLCBfVkdBX01TUl9XUklURSk7Cj4gIAkJc3RhdHVzID0gKChzdDAwICYgKDEgPDwg NCkpICE9IDApID8KPiAgCQkJY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQgOgo+ICAJCQljb25u ZWN0b3Jfc3RhdHVzX2Rpc2Nvbm5lY3RlZDsKPiAgCj4gLQkJSTkxNV9XUklURShwaXBlY29uZl9y ZWcsIHBpcGVjb25mKTsKPiArCQlpbnRlbF91bmNvcmVfd3JpdGUodW5jb3JlLCBwaXBlY29uZl9y ZWcsIHBpcGVjb25mKTsKPiAgCX0gZWxzZSB7Cj4gIAkJYm9vbCByZXN0b3JlX3ZibGFuayA9IGZh bHNlOwo+ICAJCWludCBjb3VudCwgZGV0ZWN0Owo+IEBAIC03MDIsOSArNzA1LDEwIEBAIGludGVs X2NydF9sb2FkX2RldGVjdChzdHJ1Y3QgaW50ZWxfY3J0ICpjcnQsIHUzMiBwaXBlKQo+ICAJCQl1 MzIgdnN5bmNfc3RhcnQgPSAodnN5bmMgJiAweGZmZmYpICsgMTsKPiAgCj4gIAkJCXZibGFua19z dGFydCA9IHZzeW5jX3N0YXJ0Owo+IC0JCQlJOTE1X1dSSVRFKHZibGFua19yZWcsCj4gLQkJCQkg ICAodmJsYW5rX3N0YXJ0IC0gMSkgfAo+IC0JCQkJICAgKCh2YmxhbmtfZW5kIC0gMSkgPDwgMTYp KTsKPiArCQkJaW50ZWxfdW5jb3JlX3dyaXRlKHVuY29yZSwKPiArCQkJCQkgICB2YmxhbmtfcmVn LAo+ICsJCQkJCSAgICh2Ymxhbmtfc3RhcnQgLSAxKSB8Cj4gKwkJCQkJICAgKCh2YmxhbmtfZW5k IC0gMSkgPDwgMTYpKTsKPiAgCQkJcmVzdG9yZV92YmxhbmsgPSB0cnVlOwo+ICAJCX0KPiAgCQkv KiBzYW1wbGUgaW4gdGhlIHZlcnRpY2FsIGJvcmRlciwgc2VsZWN0aW5nIHRoZSBsYXJnZXIgb25l ICovCj4gQEAgLTcxNiw5ICs3MjAsMTAgQEAgaW50ZWxfY3J0X2xvYWRfZGV0ZWN0KHN0cnVjdCBp bnRlbF9jcnQgKmNydCwgdTMyIHBpcGUpCj4gIAkJLyoKPiAgCQkgKiBXYWl0IGZvciB0aGUgYm9y ZGVyIHRvIGJlIGRpc3BsYXllZAo+ICAJCSAqLwo+IC0JCXdoaWxlIChJOTE1X1JFQUQocGlwZV9k c2xfcmVnKSA+PSB2YWN0aXZlKQo+ICsJCXdoaWxlIChpbnRlbF91bmNvcmVfcmVhZCh1bmNvcmUs IHBpcGVfZHNsX3JlZykgPj0gdmFjdGl2ZSkKPiAgCQkJOwo+IC0JCXdoaWxlICgoZHNsID0gSTkx NV9SRUFEKHBpcGVfZHNsX3JlZykpIDw9IHZzYW1wbGUpCj4gKwkJd2hpbGUgKChkc2wgPSBpbnRl bF91bmNvcmVfcmVhZCh1bmNvcmUsIHBpcGVfZHNsX3JlZykpIDw9Cj4gKwkJICAgICAgIHZzYW1w bGUpCj4gIAkJCTsKPiAgCQkvKgo+ICAJCSAqIFdhdGNoIFNUMDAgZm9yIGFuIGVudGlyZSBzY2Fu bGluZQo+IEBAIC03MjgsMTQgKzczMywxNCBAQCBpbnRlbF9jcnRfbG9hZF9kZXRlY3Qoc3RydWN0 IGludGVsX2NydCAqY3J0LCB1MzIgcGlwZSkKPiAgCQlkbyB7Cj4gIAkJCWNvdW50Kys7Cj4gIAkJ CS8qIFJlYWQgdGhlIFNUMDAgVkdBIHN0YXR1cyByZWdpc3RlciAqLwo+IC0JCQlzdDAwID0gSTkx NV9SRUFEOChfVkdBX01TUl9XUklURSk7Cj4gKwkJCXN0MDAgPSBpbnRlbF91bmNvcmVfcmVhZDgo dW5jb3JlLCBfVkdBX01TUl9XUklURSk7Cj4gIAkJCWlmIChzdDAwICYgKDEgPDwgNCkpCj4gIAkJ CQlkZXRlY3QrKzsKPiAtCQl9IHdoaWxlICgoSTkxNV9SRUFEKHBpcGVfZHNsX3JlZykgPT0gZHNs KSk7Cj4gKwkJfSB3aGlsZSAoKGludGVsX3VuY29yZV9yZWFkKHVuY29yZSwgcGlwZV9kc2xfcmVn KSA9PSBkc2wpKTsKPiAgCj4gIAkJLyogcmVzdG9yZSB2YmxhbmsgaWYgbmVjZXNzYXJ5ICovCj4g IAkJaWYgKHJlc3RvcmVfdmJsYW5rKQo+IC0JCQlJOTE1X1dSSVRFKHZibGFua19yZWcsIHZibGFu ayk7Cj4gKwkJCWludGVsX3VuY29yZV93cml0ZSh1bmNvcmUsIHZibGFua19yZWcsIHZibGFuayk7 Cj4gIAkJLyoKPiAgCQkgKiBJZiBtb3JlIHRoYW4gMy80IG9mIHRoZSBzY2FubGluZSBkZXRlY3Rl ZCBhIG1vbml0b3IsCj4gIAkJICogdGhlbiBpdCBpcyBhc3N1bWVkIHRvIGJlIHByZXNlbnQuIFRo aXMgd29ya3MgZXZlbiBvbiBpODMwLAo+IEBAIC03NDgsNyArNzUzLDcgQEAgaW50ZWxfY3J0X2xv YWRfZGV0ZWN0KHN0cnVjdCBpbnRlbF9jcnQgKmNydCwgdTMyIHBpcGUpCj4gIAl9Cj4gIAo+ICAJ LyogUmVzdG9yZSBwcmV2aW91cyBzZXR0aW5ncyAqLwo+IC0JSTkxNV9XUklURShiY2xycGF0X3Jl Zywgc2F2ZV9iY2xycGF0KTsKPiArCWludGVsX3VuY29yZV93cml0ZSh1bmNvcmUsIGJjbHJwYXRf cmVnLCBzYXZlX2JjbHJwYXQpOwo+ICAKPiAgCXJldHVybiBzdGF0dXM7Cj4gIH0KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMKPiBpbmRleCBkNzI3MmQ0ZmYyNTguLjkzZTQxMWU2YWQxOSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IEBAIC04MTYwLDE1ICs4MTYwLDE1IEBAIHVuc2lnbmVk IGxvbmcgaTkxNV9jaGlwc2V0X3ZhbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gIAlyZXR1cm4gdmFsOwo+ICB9Cj4gIAo+IC11bnNpZ25lZCBsb25nIGk5MTVfbWNoX3ZhbChz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3Vuc2lnbmVkIGxvbmcgaTkxNV9t Y2hfdmFsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICB7Cj4gIAl1bnNpZ25lZCBs b25nIG0sIHgsIGI7Cj4gIAl1MzIgdHNmczsKPiAgCj4gLQl0c2ZzID0gSTkxNV9SRUFEKFRTRlMp Owo+ICsJdHNmcyA9IGludGVsX3VuY29yZV9yZWFkKCZpOTE1LT51bmNvcmUsIFRTRlMpOwo+ICAK PiAgCW0gPSAoKHRzZnMgJiBUU0ZTX1NMT1BFX01BU0spID4+IFRTRlNfU0xPUEVfU0hJRlQpOwo+ IC0JeCA9IEk5MTVfUkVBRDgoVFIxKTsKPiArCXggPSBpbnRlbF91bmNvcmVfcmVhZDgoJmk5MTUt PnVuY29yZSwgVFIxKTsKPiAgCj4gIAliID0gdHNmcyAmIFRTRlNfSU5UUl9NQVNLOwoKLS0gCkph bmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4