From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915: Double check we didn't miss an unclaimed register access Date: Tue, 04 Sep 2018 15:56:07 +0300 Message-ID: <87k1o15sm0.fsf@gaia.fi.intel.com> References: <20180904111732.24266-1-chris@chris-wilson.co.uk> <87musx5tmj.fsf@gaia.fi.intel.com> <153606470755.2853.15606828676569770073@skylake-alporthouse-com> <153606480826.2853.4803152408895122805@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A87E6E349 for ; Tue, 4 Sep 2018 12:56:15 +0000 (UTC) In-Reply-To: <153606480826.2853.4803152408895122805@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu ZyBDaHJpcyBXaWxzb24gKDIwMTgtMDktMDQgMTM6Mzg6MjcpCj4+IFF1b3RpbmcgTWlrYSBLdW9w cGFsYSAoMjAxOC0wOS0wNCAxMzozNDoxMikKPj4gPiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4gd3JpdGVzOgo+PiA+IAo+PiA+ID4gQ3VycmVudGx5LCBpZiB0aGUgdXNl ciBoYXMgZW5hYmxlZCBtbWlvLWRlYnVnIGFyb3VuZCBlYWNoIHJlZ2lzdGVyCj4+ID4gPiBhY2Nl c3MsIHdlIHByZXN1bWUgdGhhdCB3ZSBoYXZlIHRoZW4gY2hlY2tlZCB0aGVtIGFsbC4gSG93ZXZl ciwgaXQgaXMKPj4gPiA+IHN0aWxsIHBvc3NpYmxlIHRocm91Z2ggb21pc3Npb24gKHJhdyByZWdp c3RlciBhY2Nlc3MpIG9yIGV4dGVybmFsCj4+ID4gPiBpbnRlcmFjdGlvbiB0aGF0IHRoZSB1bmNs YWltZWQgYWNjZXNzIHdhcyBub3QgaGlnaGxpZ2h0ZWQuCj4+ID4gPgo+PiA+ID4gU2lnbmVkLW9m Zi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+ID4gPiBDYzog TWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4+ID4gPiAtLS0K Pj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYyB8IDEzICsrKysrKyst LS0tLS0KPj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9u cygtKQo+PiA+ID4KPj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF91bmNvcmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4+ID4gPiBp bmRleCAyMGYyZjVhZDljM2YuLjA1ZjBjZGExODUwMSAxMDA2NDQKPj4gPiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF91bmNvcmUuYwo+PiA+ID4gQEAgLTIyODMsMTUgKzIyODMsMTYgQEAgYm9v bCBpbnRlbF91bmNvcmVfdW5jbGFpbWVkX21taW8oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+PiA+ID4gIGJvb2wKPj4gPiA+ICBpbnRlbF91bmNvcmVfYXJtX3VuY2xhaW1lZF9t bWlvX2RldGVjdGlvbihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ID4gPiAg ewo+PiA+ID4gLSAgICAgaWYgKHVubGlrZWx5KGk5MTVfbW9kcGFyYW1zLm1taW9fZGVidWcgfHwK Pj4gPiA+IC0gICAgICAgICAgICAgICAgICBkZXZfcHJpdi0+dW5jb3JlLnVuY2xhaW1lZF9tbWlv X2NoZWNrIDw9IDApKQo+PiA+ID4gKyAgICAgaWYgKHVubGlrZWx5KGRldl9wcml2LT51bmNvcmUu dW5jbGFpbWVkX21taW9fY2hlY2sgPD0gMCkpCj4+ID4gPiAgICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKPj4gPiA+Cj4+ID4gCj4+ID4gV2UgY291bGQgY2F0Y2ggdGhlIHJlYWRlcnMgYXR0ZW50 aW9uIGJ5IG1hcmtpbmcgdGhpcyBhcyBSRUFEX09OQ0UuCj4+ID4gCj4+ID4gCj4+ID4gQW5kIHRo ZW4gdGFrZSBzcGlubG9jayBoZXJlIGJlZm9yZSBjaGVja2luZyBmb3IgdW5jbGFpbWVkLgo+PiAK Pj4gQ291bGQgZG8sIGZlZWxzIGxpa2Ugb3ZlcmtpbGwsIGJ1dCBub3QgY29udGVudGlvdXMuCj4K PiBJbXBsaWVkIGhlcmUsIGlzIGltcHJvdmluZyB1bmNsYWltZWRfbW1pb19jaGVjayBhIGZ1bmRh bWVudGFsCj4gcmVxdWlyZW1lbnQgZm9yIHRoaXMgcGF0Y2ggb3IgYWRkaXRpb25hbCB3b3JrPyBJ IHRoaW5rIHRoZSBsYXR0ZXIuCgpBZGRpdGlvbmFsIHdvcmsuIFdhcyBqdXN0IHRoaW5raW5nIGFs b3VkIGFib3V0IHRoZQpwb3NzaWJsZSByYWNlcyBpbiB0aGlzIGFyZWEuCgpQYXRjaCBkb2VzIHdo YXQgaXQgc2F5cy4KClJldmlld2VkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxp bnV4LmludGVsLmNvbT4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==