From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 4/4] drm/i915/lvds: Fixup commentary
Date: Wed, 14 Feb 2018 12:25:45 +0200
Message-ID: <87k1vf6f6e.fsf@intel.com>
References: <20180214092909.27040-1-chris@chris-wilson.co.uk>
 <20180214092909.27040-4-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 747C86E28B
 for <intel-gfx@lists.freedesktop.org>; Wed, 14 Feb 2018 10:25:53 +0000 (UTC)
In-Reply-To: <20180214092909.27040-4-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCAxNCBGZWIgMjAxOCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u
dWs+IHdyb3RlOgo+IFJlbW92ZSB0aGUga2VybmVsZG9jIG1hcmt1cCBhcHBsaWVkIHRvIG5vbi1r
ZXJuZWxkb2MgY29tbWVudHMgYW5kCj4gY29udmVydCB0aGUgbXVsdGlsaW5lIGNvbW1lbnRzIHRv
IHRoZSBjYW5vbmljYWwgc3R5bGUuCj4KPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRz
LmM6MzEzOiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVtYmVyICdlbmNvZGVyJyBu
b3QgZGVzY3JpYmVkIGluICdpbnRlbF9lbmFibGVfbHZkcycKPiBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9sdmRzLmM6MzEzOiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVtYmVy
ICdwaXBlX2NvbmZpZycgbm90IGRlc2NyaWJlZCBpbiAnaW50ZWxfZW5hYmxlX2x2ZHMnCj4gZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jOjMxMzogd2FybmluZzogRnVuY3Rpb24gcGFy
YW1ldGVyIG9yIG1lbWJlciAnY29ubl9zdGF0ZScgbm90IGRlc2NyaWJlZCBpbiAnaW50ZWxfZW5h
YmxlX2x2ZHMnCj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jOjQ1Mzogd2Fybmlu
ZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAnY29ubmVjdG9yJyBub3QgZGVzY3JpYmVk
IGluICdpbnRlbF9sdmRzX2RldGVjdCcKPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRz
LmM6NDUzOiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVtYmVyICdmb3JjZScgbm90
IGRlc2NyaWJlZCBpbiAnaW50ZWxfbHZkc19kZXRlY3QnCj4gZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfbHZkcy5jOjQ3MTogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAn
Y29ubmVjdG9yJyBub3QgZGVzY3JpYmVkIGluICdpbnRlbF9sdmRzX2dldF9tb2RlcycKPiBkcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmM6OTMyOiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJh
bWV0ZXIgb3IgbWVtYmVyICdkZXZfcHJpdicgbm90IGRlc2NyaWJlZCBpbiAnaW50ZWxfbHZkc19p
bml0Jwo+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2x2ZHMuYzo5MzI6IHdhcm5pbmc6IEV4
Y2VzcyBmdW5jdGlvbiBwYXJhbWV0ZXIgJ2RldicgZGVzY3JpcHRpb24gaW4gJ2ludGVsX2x2ZHNf
aW5pdCcKPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29u
LmNvLnVrPgoKUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+
CgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jIHwgNDIgKysrKysr
KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNyBp
bnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRz
LmMKPiBpbmRleCA0Njc3YWMwYjEwZDcuLmQzNWQyZDUwZjU5NSAxMDA2NDQKPiAtLS0gYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9sdmRzLmMKPiBAQCAtMjY4LDcgKzI2OCw5IEBAIHN0YXRpYyB2b2lkIGludGVsX3By
ZV9lbmFibGVfbHZkcyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCS8qIHNldCB0
aGUgY29ycmVzcG9uc2RpbmcgTFZEU19CT1JERVIgYml0ICovCj4gIAl0ZW1wICY9IH5MVkRTX0JP
UkRFUl9FTkFCTEU7Cj4gIAl0ZW1wIHw9IHBpcGVfY29uZmlnLT5nbWNoX3BmaXQubHZkc19ib3Jk
ZXJfYml0czsKPiAtCS8qIFNldCB0aGUgQjAtQjMgZGF0YSBwYWlycyBjb3JyZXNwb25kaW5nIHRv
IHdoZXRoZXIgd2UncmUgZ29pbmcgdG8KPiArCj4gKwkvKgo+ICsJICogU2V0IHRoZSBCMC1CMyBk
YXRhIHBhaXJzIGNvcnJlc3BvbmRpbmcgdG8gd2hldGhlciB3ZSdyZSBnb2luZyB0bwo+ICAJICog
c2V0IHRoZSBEUExMcyBmb3IgZHVhbC1jaGFubmVsIG1vZGUgb3Igbm90Lgo+ICAJICovCj4gIAlp
ZiAobHZkc19lbmNvZGVyLT5pc19kdWFsX2xpbmspCj4gQEAgLTI3Niw3ICsyNzgsOCBAQCBzdGF0
aWMgdm9pZCBpbnRlbF9wcmVfZW5hYmxlX2x2ZHMoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29k
ZXIsCj4gIAllbHNlCj4gIAkJdGVtcCAmPSB+KExWRFNfQjBCM19QT1dFUl9VUCB8IExWRFNfQ0xL
Ql9QT1dFUl9VUCk7Cj4gIAo+IC0JLyogSXQgd291bGQgYmUgbmljZSB0byBzZXQgMjQgdnMgMTgt
Yml0IG1vZGUgKExWRFNfQTNfUE9XRVJfVVApCj4gKwkvKgo+ICsJICogSXQgd291bGQgYmUgbmlj
ZSB0byBzZXQgMjQgdnMgMTgtYml0IG1vZGUgKExWRFNfQTNfUE9XRVJfVVApCj4gIAkgKiBhcHBy
b3ByaWF0ZWx5IGhlcmUsIGJ1dCB3ZSBuZWVkIHRvIGxvb2sgbW9yZSB0aG9yb3VnaGx5IGludG8g
aG93Cj4gIAkgKiBwYW5lbHMgYmVoYXZlIGluIHRoZSB0d28gbW9kZXMuIEZvciBub3csIGxldCdz
IGp1c3QgbWFpbnRhaW4gdGhlCj4gIAkgKiB2YWx1ZSB3ZSBnb3QgZnJvbSB0aGUgQklPUy4KPiBA
QCAtMjg0LDEyICsyODcsMTYgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHJlX2VuYWJsZV9sdmRzKHN0
cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJdGVtcCAmPSB+TFZEU19BM19QT1dFUl9N
QVNLOwo+ICAJdGVtcCB8PSBsdmRzX2VuY29kZXItPmEzX3Bvd2VyOwo+ICAKPiAtCS8qIFNldCB0
aGUgZGl0aGVyaW5nIGZsYWcgb24gTFZEUyBhcyBuZWVkZWQsIG5vdGUgdGhhdCB0aGVyZSBpcyBu
bwo+ICsJLyoKPiArCSAqIFNldCB0aGUgZGl0aGVyaW5nIGZsYWcgb24gTFZEUyBhcyBuZWVkZWQs
IG5vdGUgdGhhdCB0aGVyZSBpcyBubwo+ICAJICogc3BlY2lhbCBsdmRzIGRpdGhlciBjb250cm9s
IGJpdCBvbiBwY2gtc3BsaXQgcGxhdGZvcm1zLCBkaXRoZXJpbmcgaXMKPiAtCSAqIG9ubHkgY29u
dHJvbGxlZCB0aHJvdWdoIHRoZSBQSVBFQ09ORiByZWcuICovCj4gKwkgKiBvbmx5IGNvbnRyb2xs
ZWQgdGhyb3VnaCB0aGUgUElQRUNPTkYgcmVnLgo+ICsJICovCj4gIAlpZiAoSVNfR0VONChkZXZf
cHJpdikpIHsKPiAtCQkvKiBCc3BlYyB3b3JkaW5nIHN1Z2dlc3RzIHRoYXQgTFZEUyBwb3J0IGRp
dGhlcmluZyBvbmx5IGV4aXN0cwo+IC0JCSAqIGZvciAxOGJwcCBwYW5lbHMuICovCj4gKwkJLyoK
PiArCQkgKiBCc3BlYyB3b3JkaW5nIHN1Z2dlc3RzIHRoYXQgTFZEUyBwb3J0IGRpdGhlcmluZyBv
bmx5IGV4aXN0cwo+ICsJCSAqIGZvciAxOGJwcCBwYW5lbHMuCj4gKwkJICovCj4gIAkJaWYgKHBp
cGVfY29uZmlnLT5kaXRoZXIgJiYgcGlwZV9jb25maWctPnBpcGVfYnBwID09IDE4KQo+ICAJCQl0
ZW1wIHw9IExWRFNfRU5BQkxFX0RJVEhFUjsKPiAgCQllbHNlCj4gQEAgLTMwNCw3ICszMTEsNyBA
QCBzdGF0aWMgdm9pZCBpbnRlbF9wcmVfZW5hYmxlX2x2ZHMoc3RydWN0IGludGVsX2VuY29kZXIg
KmVuY29kZXIsCj4gIAlJOTE1X1dSSVRFKGx2ZHNfZW5jb2Rlci0+cmVnLCB0ZW1wKTsKPiAgfQo+
ICAKPiAtLyoqCj4gKy8qCj4gICAqIFNldHMgdGhlIHBvd2VyIHN0YXRlIGZvciB0aGUgcGFuZWwu
Cj4gICAqLwo+ICBzdGF0aWMgdm9pZCBpbnRlbF9lbmFibGVfbHZkcyhzdHJ1Y3QgaW50ZWxfZW5j
b2RlciAqZW5jb2RlciwKPiBAQCAtNDQxLDcgKzQ0OCw3IEBAIHN0YXRpYyBib29sIGludGVsX2x2
ZHNfY29tcHV0ZV9jb25maWcoc3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXIsCj4g
IAlyZXR1cm4gdHJ1ZTsKPiAgfQo+ICAKPiAtLyoqCj4gKy8qCj4gICAqIERldGVjdCB0aGUgTFZE
UyBjb25uZWN0aW9uLgo+ICAgKgo+ICAgKiBTaW5jZSBMVkRTIGRvZXNuJ3QgaGF2ZSBob3RsdWcs
IHdlIHVzZSB0aGUgbGlkIGFzIGEgcHJveHkuICBPcGVuIG1lYW5zCj4gQEAgLTQ2NCw3ICs0NzEs
NyBAQCBpbnRlbF9sdmRzX2RldGVjdChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLCBi
b29sIGZvcmNlKQo+ICAJcmV0dXJuIGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkOwo+ICB9Cj4g
IAo+IC0vKioKPiArLyoKPiAgICogUmV0dXJuIHRoZSBsaXN0IG9mIEREQyBtb2RlcyBpZiBhdmFp
bGFibGUsIG9yIHRoZSBCSU9TIGZpeGVkIG1vZGUgb3RoZXJ3aXNlLgo+ICAgKi8KPiAgc3RhdGlj
IGludCBpbnRlbF9sdmRzX2dldF9tb2RlcyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9y
KQo+IEBAIC04OTMsNyArOTAwLDggQEAgc3RhdGljIGJvb2wgY29tcHV0ZV9pc19kdWFsX2xpbmtf
bHZkcyhzdHJ1Y3QgaW50ZWxfbHZkc19lbmNvZGVyICpsdmRzX2VuY29kZXIpCj4gIAlpZiAoZG1p
X2NoZWNrX3N5c3RlbShpbnRlbF9kdWFsX2xpbmtfbHZkcykpCj4gIAkJcmV0dXJuIHRydWU7Cj4g
IAo+IC0JLyogQklPUyBzaG91bGQgc2V0IHRoZSBwcm9wZXIgTFZEUyByZWdpc3RlciB2YWx1ZSBh
dCBib290LCBidXQKPiArCS8qCj4gKwkgKiBCSU9TIHNob3VsZCBzZXQgdGhlIHByb3BlciBMVkRT
IHJlZ2lzdGVyIHZhbHVlIGF0IGJvb3QsIGJ1dAo+ICAJICogaW4gcmVhbGl0eSwgaXQgZG9lc24n
dCBzZXQgdGhlIHZhbHVlIHdoZW4gdGhlIGxpZCBpcyBjbG9zZWQ7Cj4gIAkgKiB3ZSBuZWVkIHRv
IGNoZWNrICJ0aGUgdmFsdWUgdG8gYmUgc2V0IiBpbiBWQlQgd2hlbiBMVkRTCj4gIAkgKiByZWdp
c3RlciBpcyB1bmluaXRpYWxpemVkLgo+IEBAIC05MDcsMTMgKzkxNSwxNyBAQCBzdGF0aWMgYm9v
bCBjb21wdXRlX2lzX2R1YWxfbGlua19sdmRzKHN0cnVjdCBpbnRlbF9sdmRzX2VuY29kZXIgKmx2
ZHNfZW5jb2RlcikKPiAgCj4gIHN0YXRpYyBib29sIGludGVsX2x2ZHNfc3VwcG9ydGVkKHN0cnVj
dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+IC0JLyogV2l0aCB0aGUgaW50cm9k
dWN0aW9uIG9mIHRoZSBQQ0ggd2UgZ2FpbmVkIGEgZGVkaWNhdGVkCj4gLQkgKiBMVkRTIHByZXNl
bmNlIHBpbiwgdXNlIGl0LiAqLwo+ICsJLyoKPiArCSAqIFdpdGggdGhlIGludHJvZHVjdGlvbiBv
ZiB0aGUgUENIIHdlIGdhaW5lZCBhIGRlZGljYXRlZAo+ICsJICogTFZEUyBwcmVzZW5jZSBwaW4s
IHVzZSBpdC4KPiArCSAqLwo+ICAJaWYgKEhBU19QQ0hfSUJYKGRldl9wcml2KSB8fCBIQVNfUENI
X0NQVChkZXZfcHJpdikpCj4gIAkJcmV0dXJuIHRydWU7Cj4gIAo+IC0JLyogT3RoZXJ3aXNlIExW
RFMgd2FzIG9ubHkgYXR0YWNoZWQgdG8gbW9iaWxlIHByb2R1Y3RzLAo+IC0JICogZXhjZXB0IGZv
ciB0aGUgaW5nbG9yaW91cyA4MzBnbSAqLwo+ICsJLyoKPiArCSAqIE90aGVyd2lzZSBMVkRTIHdh
cyBvbmx5IGF0dGFjaGVkIHRvIG1vYmlsZSBwcm9kdWN0cywKPiArCSAqIGV4Y2VwdCBmb3IgdGhl
IGluZ2xvcmlvdXMgODMwZ20KPiArCSAqLwo+ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPD0g
NCAmJgo+ICAJICAgIElTX01PQklMRShkZXZfcHJpdikgJiYgIUlTX0k4MzAoZGV2X3ByaXYpKQo+
ICAJCXJldHVybiB0cnVlOwo+IEBAIC05MjMsNyArOTM1LDcgQEAgc3RhdGljIGJvb2wgaW50ZWxf
bHZkc19zdXBwb3J0ZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAKPiAg
LyoqCj4gICAqIGludGVsX2x2ZHNfaW5pdCAtIHNldHVwIExWRFMgY29ubmVjdG9ycyBvbiB0aGlz
IGRldmljZQo+IC0gKiBAZGV2OiBkcm0gZGV2aWNlCj4gKyAqIEBkZXZfcHJpdjogaTkxNSBkZXZp
Y2UKPiAgICoKPiAgICogQ3JlYXRlIHRoZSBjb25uZWN0b3IsIHJlZ2lzdGVyIHRoZSBMVkRTIERE
QyBidXMsIGFuZCB0cnkgdG8gZmlndXJlIG91dCB3aGF0Cj4gICAqIG1vZGVzIHdlIGNhbiBkaXNw
bGF5IG9uIHRoZSBMVkRTIHBhbmVsIChpZiBwcmVzZW50KS4KCi0tIApKYW5pIE5pa3VsYSwgSW50
ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA
bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==