From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 4/5] drm/i915/selftests: Hold the rpm wakeref for the reset tests
Date: Mon, 09 Oct 2017 14:50:25 +0300 [thread overview]
Message-ID: <87k204zgji.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20171009110301.21705-4-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> The lowlevel reset functions expect the caller to be holding the rpm
> wakeref for the device access across the reset. We were not explicitly
> doing this in the sefltest, so for simplicity acquire the wakeref for
> the duration of all subtests.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> index 7e1bdd88eda3..71ce06680d66 100644
> --- a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> +++ b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> @@ -878,9 +878,16 @@ int intel_hangcheck_live_selftests(struct drm_i915_private *i915)
> SUBTEST(igt_reset_queue),
> SUBTEST(igt_handle_error),
> };
> + int err;
>
> if (!intel_has_gpu_reset(i915))
> return 0;
>
> - return i915_subtests(tests, i915);
> + intel_runtime_pm_get(i915);
> +
> + err = i915_subtests(tests, i915);
> +
> + intel_runtime_pm_put(i915);
> +
> + return err;
> }
> --
> 2.14.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-09 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 11:02 [PATCH v2 1/5] drm/i915: Make i915_engine_info pretty printer to standalone Chris Wilson
2017-10-09 11:02 ` [PATCH v2 2/5] drm/i915/selftests: Pretty print engine state when requests fail to start Chris Wilson
2017-10-09 11:50 ` Mika Kuoppala
2017-10-09 11:02 ` [PATCH v2 3/5] drm/i915: Hold forcewake for the duration of reset+restart Chris Wilson
2017-10-09 11:32 ` Mika Kuoppala
2017-10-09 11:37 ` Chris Wilson
2017-10-09 11:03 ` [PATCH v2 4/5] drm/i915/selftests: Hold the rpm wakeref for the reset tests Chris Wilson
2017-10-09 11:50 ` Mika Kuoppala [this message]
2017-10-09 11:03 ` [PATCH v2 5/5] drm/i915: Provide an assert for when we expect forcewake to be held Chris Wilson
2017-10-09 11:48 ` [PATCH v2 1/5] drm/i915: Make i915_engine_info pretty printer to standalone Mika Kuoppala
2017-10-09 13:41 ` ✗ Fi.CI.BAT: warning for series starting with [v2,1/5] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k204zgji.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox