From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH v2] drm/i915/dp: Clean up
	intel_dp_check_mst_status
Date: Mon, 25 Sep 2017 15:39:10 +0300
Message-ID: <87k20n3qc1.fsf@nikula.org>
References: <CAA1Hj7Sr84GPhHUJX5gRbpybewEfwKcBQHWtwaB5jUM75Gutkw@mail.gmail.com>
 <20170921185406.2353-1-dhinakaran.pandiyan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D00DC6E319
 for <intel-gfx@lists.freedesktop.org>; Mon, 25 Sep 2017 12:40:06 +0000 (UTC)
In-Reply-To: <20170921185406.2353-1-dhinakaran.pandiyan@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCAyMSBTZXAgMjAxNywgRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5k
aXlhbkBpbnRlbC5jb20+IHdyb3RlOgo+IFJld3JpdGluZyB0aGlzIGNvZGUgd2l0aG91dCB0aGUg
Z290bywgSSBiZWxpZXZlLCBtYWtlcyBpdCBtb3JlIHJlYWRhYmxlLgo+IE9uZSBmdW5jdGlvbmFs
IGNoYW5nZSB0aGF0IGhhcyBiZWVuIGluY2x1ZGVkIGlzIHRoZSBoYW5kbGluZyBvZiBmYWlsZWQg
RVNJCj4gcmVnaXN0ZXIgcmVhZHMuIEluc3RlYWQgb2YgZGlzYWJsaW5nIE1TVCBvbmx5IGZvciB0
aGUgZmlyc3QgZmFpbGVkIHJlYWQsIHdlCj4gbm93IGRpc2FibGUgTVNUIG9uIHN1YnNlcXVlbnQg
ZmFpbGVkIHJlYWRzIHRvby4gQSBmYWlsZWQgRVNJIHJlYWQgaXMKPiBwcm9ibGVtYXRpYyBpcnJl
c3BlY3RpdmUgb2Ygd2hldGhlciBpdCBpcyB0aGUgZmlyc3Qgb3Igbm90Lgo+Cj4gdjI6IERvbid0
IGlnbm9yZSByZXR1cm4gZnJvbSBfbXN0X2hwZF9pcnEoKSAoSmFtZXMpCj4KPiBDYzogSmFtZXMg
QXVzbXVzIDxqYW1lcy5hdXNtdXNAaW50ZWwuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5u
aWt1bGFAaW50ZWwuY29tPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu
dXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5h
a2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgoKSSBwdXNoZWQgZXZlcnl0aGluZyAqZXhjZXB0KiB0
aGlzIHBhdGNoIGluIHRoZSBzZXJpZXMsIHBsZWFzZSByZXBvc3QgaW4KYSBuZXcgdGhyZWFkIGZv
ciBjbGVhbiBDSSByZXN1bHRzLgoKVGhhbmtzLApKYW5pLgoKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2RwLmMgfCA3OCArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgNDQgZGVsZXRp
b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCA5OGU3Yjk2Y2E4MjYuLmFh
OTdiZDgyNTM2OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5j
Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC00MTkxLDU3ICs0
MTkxLDQ3IEBAIHN0YXRpYyB2b2lkIGludGVsX2RwX2hhbmRsZV90ZXN0X3JlcXVlc3Qoc3RydWN0
IGludGVsX2RwICppbnRlbF9kcCkKPiAgc3RhdGljIGludAo+ICBpbnRlbF9kcF9jaGVja19tc3Rf
c3RhdHVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIHsKPiAtCWJvb2wgYnJldDsKPiAr
CXU4IGVzaVtEUF9EUFJYX0VTSV9MRU5dID0geyAwIH07Cj4gKwlzdHJ1Y3QgaW50ZWxfZGlnaXRh
bF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiAgCj4g
LQlpZiAoaW50ZWxfZHAtPmlzX21zdCkgewo+IC0JCXU4IGVzaVtEUF9EUFJYX0VTSV9MRU5dID0g
eyAwIH07Cj4gLQkJaW50IHJldCA9IDA7Cj4gLQkJaW50IHJldHJ5Owo+ICsJaWYgKCFpbnRlbF9k
cC0+aXNfbXN0KQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCXdoaWxlIChpbnRlbF9kcF9n
ZXRfc2lua19pcnFfZXNpKGludGVsX2RwLCBlc2kpKSB7Cj4gKwkJaW50IHJldCwgcmV0cnk7Cj4g
IAkJYm9vbCBoYW5kbGVkOwo+IC0JCWJyZXQgPSBpbnRlbF9kcF9nZXRfc2lua19pcnFfZXNpKGlu
dGVsX2RwLCBlc2kpOwo+IC1nb19hZ2FpbjoKPiAtCQlpZiAoYnJldCA9PSB0cnVlKSB7Cj4gLQo+
IC0JCQkvKiBjaGVjayBsaW5rIHN0YXR1cyAtIGVzaVsxMF0gPSAweDIwMGMgKi8KPiAtCQkJaWYg
KGludGVsX2RwLT5hY3RpdmVfbXN0X2xpbmtzICYmCj4gLQkJCSAgICAhZHJtX2RwX2NoYW5uZWxf
ZXFfb2soJmVzaVsxMF0sIGludGVsX2RwLT5sYW5lX2NvdW50KSkgewo+IC0JCQkJRFJNX0RFQlVH
X0tNUygiY2hhbm5lbCBFUSBub3Qgb2ssIHJldHJhaW5pbmdcbiIpOwo+IC0JCQkJaW50ZWxfZHBf
c3RhcnRfbGlua190cmFpbihpbnRlbF9kcCk7Cj4gLQkJCQlpbnRlbF9kcF9zdG9wX2xpbmtfdHJh
aW4oaW50ZWxfZHApOwo+IC0JCQl9Cj4gIAo+IC0JCQlEUk1fREVCVUdfS01TKCJnb3QgZXNpICUz
cGhcbiIsIGVzaSk7Cj4gLQkJCXJldCA9IGRybV9kcF9tc3RfaHBkX2lycSgmaW50ZWxfZHAtPm1z
dF9tZ3IsIGVzaSwgJmhhbmRsZWQpOwo+IC0KPiAtCQkJaWYgKGhhbmRsZWQpIHsKPiAtCQkJCWZv
ciAocmV0cnkgPSAwOyByZXRyeSA8IDM7IHJldHJ5KyspIHsKPiAtCQkJCQlpbnQgd3JldDsKPiAt
CQkJCQl3cmV0ID0gZHJtX2RwX2RwY2Rfd3JpdGUoJmludGVsX2RwLT5hdXgsCj4gLQkJCQkJCQkJ
IERQX1NJTktfQ09VTlRfRVNJKzEsCj4gLQkJCQkJCQkJICZlc2lbMV0sIDMpOwo+IC0JCQkJCWlm
ICh3cmV0ID09IDMpIHsKPiAtCQkJCQkJYnJlYWs7Cj4gLQkJCQkJfQo+IC0JCQkJfQo+ICsJCURS
TV9ERUJVR19LTVMoIkVTSSAlM3BoXG4iLCBlc2kpOwo+ICAKPiAtCQkJCWJyZXQgPSBpbnRlbF9k
cF9nZXRfc2lua19pcnFfZXNpKGludGVsX2RwLCBlc2kpOwo+IC0JCQkJaWYgKGJyZXQgPT0gdHJ1
ZSkgewo+IC0JCQkJCURSTV9ERUJVR19LTVMoImdvdCBlc2kyICUzcGhcbiIsIGVzaSk7Cj4gLQkJ
CQkJZ290byBnb19hZ2FpbjsKPiAtCQkJCX0KPiAtCQkJfSBlbHNlCj4gLQkJCQlyZXQgPSAwOwo+
ICsJCS8qIGNoZWNrIGxpbmsgc3RhdHVzIC0gZXNpWzEwXSA9IDB4MjAwYyAqLwo+ICsJCWlmIChp
bnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcyAmJgo+ICsJCSAgICAhZHJtX2RwX2NoYW5uZWxfZXFf
b2soJmVzaVsxMF0sIGludGVsX2RwLT5sYW5lX2NvdW50KSkgewo+ICsJCQlpbnRlbF9kcF9zdGFy
dF9saW5rX3RyYWluKGludGVsX2RwKTsKPiArCQkJaW50ZWxfZHBfc3RvcF9saW5rX3RyYWluKGlu
dGVsX2RwKTsKPiArCQl9Cj4gIAo+IC0JCQlyZXR1cm4gcmV0Owo+IC0JCX0gZWxzZSB7Cj4gLQkJ
CXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0gZHBfdG9fZGlnX3Bv
cnQoaW50ZWxfZHApOwo+IC0JCQlEUk1fREVCVUdfS01TKCJmYWlsZWQgdG8gZ2V0IEVTSSAtIGRl
dmljZSBtYXkgaGF2ZSBmYWlsZWRcbiIpOwo+IC0JCQlpbnRlbF9kcC0+aXNfbXN0ID0gZmFsc2U7
Cj4gLQkJCWRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyX3NldF9tc3QoJmludGVsX2RwLT5tc3RfbWdy
LCBpbnRlbF9kcC0+aXNfbXN0KTsKPiAtCQkJLyogc2VuZCBhIGhvdHBsdWcgZXZlbnQgKi8KPiAt
CQkJZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudChpbnRlbF9kaWdfcG9ydC0+YmFzZS5iYXNl
LmRldik7Cj4gKwkJcmV0ID0gZHJtX2RwX21zdF9ocGRfaXJxKCZpbnRlbF9kcC0+bXN0X21nciwg
ZXNpLCAmaGFuZGxlZCk7Cj4gKwkJaWYgKCFoYW5kbGVkKQo+ICsJCQlyZXR1cm4gMDsKPiArCj4g
KwkJaWYgKHJldCkKPiArCQkJRFJNX0RFQlVHX0tNUygiZXJyb3IgaGFuZGxpbmcgTVNUIElSUV9I
UEQgJWRcbiIsIHJldCk7Cj4gKwo+ICsJCWZvciAocmV0cnkgPSAwOyByZXRyeSA8IDM7IHJldHJ5
KyspIHsKPiArCQkJaW50IHdyZXQ7Cj4gKwo+ICsJCQl3cmV0ID0gZHJtX2RwX2RwY2Rfd3JpdGUo
JmludGVsX2RwLT5hdXgsCj4gKwkJCQkJCSBEUF9TSU5LX0NPVU5UX0VTSSArIDEsICZlc2lbMV0s
Cj4gKwkJCQkJCSAzKTsKPiArCQkJaWYgKHdyZXQgPT0gMykKPiArCQkJCWJyZWFrOwo+ICAJCX0K
PiAgCX0KPiArCj4gKwlEUk1fREVCVUdfS01TKCJmYWlsZWQgdG8gZ2V0IEVTSSAtIGRldmljZSBt
YXkgaGF2ZSBmYWlsZWRcbiIpOwo+ICsJaW50ZWxfZHAtPmlzX21zdCA9IGZhbHNlOwo+ICsJZHJt
X2RwX21zdF90b3BvbG9neV9tZ3Jfc2V0X21zdCgmaW50ZWxfZHAtPm1zdF9tZ3IsIGludGVsX2Rw
LT5pc19tc3QpOwo+ICsJZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudChpbnRlbF9kaWdfcG9y
dC0+YmFzZS5iYXNlLmRldik7Cj4gIAlyZXR1cm4gLUVJTlZBTDsKPiAgfQoKLS0gCkphbmkgTmlr
dWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu
dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v
cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK