From: Jani Nikula <jani.nikula@linux.intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH i-g-t 12/12] RFC: meson build system support
Date: Mon, 04 Sep 2017 16:11:17 +0300 [thread overview]
Message-ID: <87k21e622y.fsf@nikula.org> (raw)
In-Reply-To: <20170902170406.8271-12-daniel.vetter@ffwll.ch>
On Sat, 02 Sep 2017, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> +if cc.has_member('struct sysinfo', 'totalram',
> + prefix : '#include <sys/sysinfo.h>')
> + config_h.set('HAVE_STRUCT_SYSINFO_TOTALRAM', 1)
> +endif
> +
> +add_project_arguments('-D_GNU_SOURCE', language : 'c')
Just something that caught my eye that bit me in the past. The project
arguments are *not* passed on to feature tests such as
cc.has_member(). I don't think it matters in this case, but you'll want
to #define _GNU_SOURCE in the prefix if you're testing for GNU
stuff. Otherwise you may end up using compat versions. Just a heads up,
that's all.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-04 13:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 17:03 [PATCH i-g-t 01/12] build: Define _GNU_SOURCE in Makefile.am Daniel Vetter
2017-09-02 17:03 ` [PATCH i-g-t 02/12] build: Nuke #ifdef HAVE_CONFIG_H cargo-cult Daniel Vetter
2017-09-03 9:29 ` Chris Wilson
2017-09-04 8:41 ` Daniel Vetter
2017-09-04 8:28 ` Arkadiusz Hiler
2017-09-04 8:45 ` Daniel Vetter
2017-09-04 9:27 ` Arkadiusz Hiler
2017-09-04 10:26 ` Szwichtenberg, Radoslaw
2017-09-04 10:35 ` Arkadiusz Hiler
2017-09-02 17:03 ` [PATCH i-g-t 03/12] build: use HAVE_LIBGEN_H consistently Daniel Vetter
2017-09-02 17:03 ` [PATCH i-g-t 04/12] build: remove _GNU_SOURCE from source files Daniel Vetter
2017-09-02 17:03 ` [PATCH i-g-t 05/12] tests/gem_spin_batch: Fix warning Daniel Vetter
2017-09-03 4:39 ` Eric Anholt
2017-09-02 17:04 ` [PATCH i-g-t 06/12] lib: prefix frame_dump_path Daniel Vetter
2017-09-02 17:04 ` [PATCH i-g-t 07/12] lib: clean up header includes Daniel Vetter
2017-09-02 17:04 ` [PATCH i-g-t 08/12] tests/igt_command_line.sh: Allow testing individual tests Daniel Vetter
2017-09-02 17:04 ` [PATCH i-g-t 09/12] lib/uwildmat: Use include paths Daniel Vetter
2017-09-02 17:04 ` [PATCH i-g-t 10/12] demos: remove Daniel Vetter
2017-09-02 17:04 ` [PATCH i-g-t 11/12] assembler/test: Prep work for meson Daniel Vetter
2017-09-02 17:04 ` [PATCH i-g-t 12/12] RFC: meson build system support Daniel Vetter
2017-09-04 9:11 ` Daniel Vetter
2017-09-04 13:11 ` Jani Nikula [this message]
2017-09-04 14:49 ` Daniel Vetter
2017-09-03 9:27 ` [PATCH i-g-t 01/12] build: Define _GNU_SOURCE in Makefile.am Chris Wilson
2017-09-04 8:48 ` Daniel Vetter
2017-09-04 9:08 ` [PATCH i-g-t 1/7] lib/ioctl_wrappers: make the valgrind wrapper always emit a statement:w Daniel Vetter
2017-09-04 9:08 ` [PATCH i-g-t 2/7] tests/kms_plane: Appease gcc -Wempty-body Daniel Vetter
2017-09-04 9:08 ` [PATCH i-g-t 3/7] meson: Add some compiler flags to reduce warnings Daniel Vetter
2017-09-04 9:08 ` [PATCH i-g-t 4/7] meson: Don't build the igt audio test without gsl available Daniel Vetter
2017-09-04 9:08 ` [PATCH i-g-t 5/7] meson: Use static libs to handle IGT_LOG_DOMAIN Daniel Vetter
2017-09-04 9:08 ` [PATCH i-g-t 6/7] meson: detect cc flags Daniel Vetter
2017-09-04 9:08 ` [PATCH i-g-t 7/7] meson: add manpage support Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k21e622y.fsf@nikula.org \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox