intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
@ 2017-01-30 10:44 Chris Wilson
  2017-01-30 10:44 ` [PATCH v2 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check Chris Wilson
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Chris Wilson @ 2017-01-30 10:44 UTC (permalink / raw)
  To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi, Zanoni, Paulo R

As we add new generations, we should keep detecting new pre-production
system development platforms that were temporarily enabled to facilitate
initial development and now superseded by production systems. To make
it easier to add more platforms, split the if into a series of logical
operations.

v2: s/sdv/pre/ - not all system development vehicles are for
preproduction usage.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 008fc1e62a69..b55ad5199967 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -782,8 +782,12 @@ static void i915_workqueues_cleanup(struct drm_i915_private *dev_priv)
  */
 static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
 {
-	if (IS_HSW_EARLY_SDV(dev_priv) ||
-	    IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
+	bool pre = false;
+
+	pre |= IS_HSW_EARLY_SDV(dev_priv);
+	pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
+
+	if (pre)
 		DRM_ERROR("This is a pre-production stepping. "
 			  "It may not be fully functional.\n");
 }
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2017-01-31 16:10 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-30 10:44 [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Chris Wilson
2017-01-30 10:44 ` [PATCH v2 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check Chris Wilson
2017-01-30 12:31   ` Joonas Lahtinen
2017-01-30 13:25     ` Chris Wilson
2017-01-30 10:44 ` [PATCH v2 3/3] drm/i915: Add early BXT sdv to the list of preproduction machines Chris Wilson
2017-01-30 12:36   ` Joonas Lahtinen
2017-01-30 12:35 ` [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Joonas Lahtinen
2017-01-30 13:11   ` Jani Nikula
2017-01-30 13:18     ` Chris Wilson
2017-01-30 17:54 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/3] " Patchwork
2017-01-31 16:10   ` Chris Wilson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).