From: Jani Nikula <jani.nikula@linux.intel.com>
To: Zhi Wang <zhi.a.wang@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Zhiyuan Lv <zhiyuan.lv@intel.com>
Subject: Re: [PATCH] drm/i915: Fix a typo in vgt_balloon_space()
Date: Tue, 17 Jan 2017 16:27:04 +0200 [thread overview]
Message-ID: <87k29t4v9j.fsf@intel.com> (raw)
In-Reply-To: <1484661972-9366-1-git-send-email-zhi.a.wang@intel.com>
On Tue, 17 Jan 2017, Zhi Wang <zhi.a.wang@intel.com> wrote:
> From: Zhenyu Wang <zhenyuw@linux.intel.com>
>
> Commit 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a
> helper") introduces this typo which can cause a driver loading failure
> in Linux GVT-g guest.
The proper format for fixes is:
Fixes: 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a helper")
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Zhiyuan Lv <zhiyuan.lv@intel.com>
> Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> ---
> drivers/gpu/drm/i915/i915_vgpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_vgpu.c b/drivers/gpu/drm/i915/i915_vgpu.c
> index f1ad4fb..d0abfd0 100644
> --- a/drivers/gpu/drm/i915/i915_vgpu.c
> +++ b/drivers/gpu/drm/i915/i915_vgpu.c
> @@ -122,7 +122,7 @@ static int vgt_balloon_space(struct i915_ggtt *ggtt,
> {
> unsigned long size = end - start;
>
> - if (start <= end)
> + if (start >= end)
> return -EINVAL;
>
> DRM_INFO("balloon space: range [ 0x%lx - 0x%lx ] %lu KiB.\n",
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-17 14:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 14:06 [PATCH] drm/i915: Fix a typo in vgt_balloon_space() Zhi Wang
2017-01-17 14:06 ` [PATCH] drm/i915: Re-enable preallocated top level PDPs support Zhi Wang
2017-01-19 11:52 ` Michał Winiarski
2017-01-19 12:09 ` Chris Wilson
2017-01-20 9:11 ` Wang, Zhi A
2017-01-17 14:27 ` Jani Nikula [this message]
2017-01-17 15:11 ` [PATCH] drm/i915: Fix a typo in vgt_balloon_space() Chris Wilson
2017-01-18 5:42 ` Zhi Wang
2017-01-17 14:37 ` Chris Wilson
2017-01-18 5:43 ` Zhi Wang
2017-01-17 14:54 ` ✓ Fi.CI.BAT: success for drm/i915: Fix a typo in vgt_balloon_space() (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k29t4v9j.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhi.a.wang@intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox