intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v3 4/4] drm/i915: Implement Link Rate fallback on Link training failure
Date: Wed, 09 Nov 2016 15:07:11 +0200	[thread overview]
Message-ID: <87k2ccg5ts.fsf@intel.com> (raw)
In-Reply-To: <20161107192439.GA24899@intel.com>

On Mon, 07 Nov 2016, Manasi Navare <manasi.d.navare@intel.com> wrote:
> Jani, could you please take a look at this patch? 
> I have addressed your comments on the previous revision.
> The common_rates array can be moved into Intel dp
> structure in a follow up patch since that would require changes
> in a lot of places other than the link rate fallback implementation.

I think this is looking good. I think you need to put this together in a
series that doesn't add something first, and then remove it, i.e. build
a coherent story from the start. It's not that many patches. Then you
need to post all patches on both intel-gfx and dri-devel, preferrably in
a fresh thread, not replying to previous versions. The thread is too
confusing now with so many versions.

Then we need to get r-b and acks for the drm changes. Daniel, can you
help with the last part?

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-11-09 13:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-29  1:07 [PATCH v2 0/4] Handle link training failure during modeset for DDI Manasi Navare
2016-10-29  1:07 ` [PATCH v2 1/4] drm: Add a new connector property for link status Manasi Navare
2016-10-31 13:16   ` Jani Nikula
2016-10-31 21:29   ` [PATCH v3 " Manasi Navare
2016-11-09 13:45     ` Jani Nikula
2016-10-29  1:07 ` [PATCH v2 2/4] drm/i915: Set link status property for DP connector Manasi Navare
2016-10-31 16:08   ` Jani Nikula
2016-10-29  1:07 ` [PATCH v2 3/4] drm/i915: Find fallback link rate/lane count Manasi Navare
2016-10-29  1:07 ` [PATCH v2 4/4] drm/i915: Implement Link Rate fallback on Link training failure Manasi Navare
2016-11-01  8:49   ` Jani Nikula
2016-11-01 16:26     ` Manasi Navare
2016-11-01 19:16       ` Jani Nikula
2016-11-01 19:34         ` Manasi Navare
2016-11-02  0:29           ` Manasi Navare
2016-11-02 20:55   ` [PATCH v3 " Manasi Navare
2016-11-07 19:24     ` Manasi Navare
2016-11-09 13:07       ` Jani Nikula [this message]
2016-11-09 13:04     ` Jani Nikula
2016-11-09 22:05       ` Manasi Navare
2016-10-29  1:55 ` ✗ Fi.CI.BAT: failure for Handle link training failure during modeset for DDI Patchwork
2016-10-31 21:55 ` ✗ Fi.CI.BAT: failure for Handle link training failure during modeset for DDI (rev2) Patchwork
2016-11-02 21:24 ` ✗ Fi.CI.BAT: failure for Handle link training failure during modeset for DDI (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2ccg5ts.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=manasi.d.navare@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).