Re: [PATCH 5/7] drm/i915: Update kerneldoc for intel_dpll_mgr.c

Daniel Vetter
2016-10-20T06:50:37Z

On Wed, Oct 19, 2016 at 06:29:13PM +0300, Jani Nikula wrote:
> On Wed, 19 Oct 2016, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> > On Thu, 2016-10-13 at 15:46 +0200, Daniel Vetter wrote:
> >> > + /**
> >> > +  * @hw_state: hardware configuration for the DPLL.
> >> "... stored in struct &intel_dpll_hw_state." - I love my hyperlinks ;-)
> >
> > I'll add that, but I think it's silly. The type of the field is struct
> > intel_dpll_hw_state, so I think it would be more natural if the documentation
> > tool would add that link automatically.
>
> Agreed.

Someone volunteering? I'd hope it would be at most a bit of shuffling with
the generator, we should have the type and all that handy already. Except
maybe lots of corner-cases ...

And ack on the struct layout bikeshed I had.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation