Re: [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

From: Jani Nikula <jani.nikula@linux.intel.com>
To: imre.deak@intel.com, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT
Date: Mon, 17 Oct 2016 17:56:37 +0300	[thread overview]
Message-ID: <87k2d7rplm.fsf@intel.com> (raw)
In-Reply-To: <1476715610.32479.26.camel@intel.com>

On Mon, 17 Oct 2016, Imre Deak <imre.deak@intel.com> wrote:
> On ma, 2016-10-17 at 16:32 +0200, Daniel Vetter wrote:
>> On Mon, Oct 17, 2016 at 03:39:04PM +0300, Imre Deak wrote:
>> > Add gem_exec_suspend/basic-s3-devices and basic-s4-devices subtests
>> > to
>> > BAT. At the same time remove basic-s4 from the list, which is atm
>> > implicitly disabled via HIBERNATION=n in kconfig. We would need at
>> > least
>> > basic S4 coverage provided by basic-s4-devices, which requires
>> > HIBERNATION=y.
>> > 
>> > Signed-off-by: Imre Deak <imre.deak@intel.com>
>> 
>> What's the impact on BAT runtime with this? 
>
> I measured 8 sec for S3-devices and 9 sec for S4-devices on my APL.
>
>> Afaik we're already over budget ... Where do you safe the time to
>> afford this?
>
> I didn't, but we don't have any S4 coverage in CI atm and it's the
> minimum that can be added. The S3-devices subtest is not critical,
> although it would be useful for cases where we wouldn't get any logs
> for the full S3 test.

If our CI was sufficiently clever, it could detect these patches to
change the test list, and let us all know what the impact is...

BR,
Jani.

>
> --Imre
>
>> -Daniel
>> 
>> > ---
>> >  tests/intel-ci/fast-feedback.testlist | 3 ++-
>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> > 
>> > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-
>> > ci/fast-feedback.testlist
>> > index f59ec98..efa7e86 100644
>> > --- a/tests/intel-ci/fast-feedback.testlist
>> > +++ b/tests/intel-ci/fast-feedback.testlist
>> > @@ -73,8 +73,9 @@ igt@gem_exec_store@basic-default
>> >  igt@gem_exec_store@basic-render
>> >  igt@gem_exec_store@basic-vebox
>> >  igt@gem_exec_suspend@basic
>> > +igt@gem_exec_suspend@basic-s3-devices
>> >  igt@gem_exec_suspend@basic-s3
>> > -igt@gem_exec_suspend@basic-s4
>> > +igt@gem_exec_suspend@basic-s4-devices
>> >  igt@gem_flink_basic@bad-flink
>> >  igt@gem_flink_basic@bad-open
>> >  igt@gem_flink_basic@basic
>> > -- 
>> > 2.5.0
>> > 
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx