Re: [PATCH] drm/i915/bxt: add bxt dsi gpio element support

From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bxt: add bxt dsi gpio element support
Date: Thu, 07 Apr 2016 15:55:48 +0300	[thread overview]
Message-ID: <87k2k9wpbf.fsf@intel.com> (raw)
In-Reply-To: <20160407122155.GD4329@intel.com>

On Thu, 07 Apr 2016, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Apr 07, 2016 at 02:47:52PM +0300, Jani Nikula wrote:
>> Request the GPIO by index through the consumer API. For now, use a quick
>> hack to store the already requested ones, simply because I have no idea
>> whether this actually works or not, and I have no way to test it.
>
> Would be cool if someone dumped out the relevant ACPI table(s) on
> a machine that needs this stuff, so that we can see if things look
> sane on that level.

I know, I've been asking.

BR,
Jani.

>
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 28 +++++++++++++++++++++++++++-
>>  1 file changed, 27 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
>> index 5e2c31d9a748..7e6a21c05c6a 100644
>> --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
>> +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
>> @@ -29,6 +29,7 @@
>>  #include <drm/drm_edid.h>
>>  #include <drm/i915_drm.h>
>>  #include <drm/drm_panel.h>
>> +#include <linux/gpio.h>
>>  #include <linux/slab.h>
>>  #include <video/mipi_display.h>
>>  #include <asm/intel-mid.h>
>> @@ -295,6 +296,31 @@ static void chv_exec_gpio(struct drm_i915_private *dev_priv,
>>  	mutex_unlock(&dev_priv->sb_lock);
>>  }
>>  
>> +static void bxt_exec_gpio(struct drm_i915_private *dev_priv,
>> +			  u8 gpio_source, u8 gpio_index, bool value)
>> +{
>> +	/* XXX: this table is a quick ugly hack. */
>> +	static struct gpio_desc *bxt_gpio_table[U8_MAX + 1];
>> +	struct gpio_desc *gpio_desc = bxt_gpio_table[gpio_index];
>> +
>> +	if (!gpio_desc) {
>> +		gpio_desc = devm_gpiod_get_index(dev_priv->dev->dev,
>> +						 NULL, gpio_index,
>> +						 value ? GPIOD_OUT_LOW :
>> +						 GPIOD_OUT_HIGH);
>> +
>> +		if (IS_ERR_OR_NULL(gpio_desc)) {
>> +			DRM_ERROR("GPIO index %u request failed (%ld)\n",
>> +				  gpio_index, PTR_ERR(gpio_desc));
>> +			return;
>> +		}
>> +
>> +		bxt_gpio_table[gpio_index] = gpio_desc;
>> +	}
>> +
>> +	gpiod_set_value(gpio_desc, value);
>> +}
>> +
>>  static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
>>  {
>>  	struct drm_device *dev = intel_dsi->base.base.dev;
>> @@ -321,7 +347,7 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
>>  	else if (IS_CHERRYVIEW(dev_priv))
>>  		chv_exec_gpio(dev_priv, gpio_source, gpio_index, value);
>>  	else
>> -		DRM_DEBUG_KMS("GPIO element not supported on this platform\n");
>> +		bxt_exec_gpio(dev_priv, gpio_source, gpio_index, value);
>>  
>>  	return data;
>>  }
>> -- 
>> 2.1.4

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx