Re: [PATCH] i915: correctly handling failed allocation

Insu Yun
2015-12-30T15:56:09Z

[-- Attachment #1.1: Type: text/plain, Size: 1202 bytes --]

On Wed, Dec 30, 2015 at 4:16 AM, Jani Nikula <jani.nikula@linux.intel.com>
wrote:

> On Tue, 29 Dec 2015, Insu Yun <wuninsu@gmail.com> wrote:
> > Signed-off-by: Insu Yun <wuninsu@gmail.com>
> > ---
> > drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> > index a5e99ac..4e279dd 100644
> > --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> > +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> > @@ -666,6 +666,8 @@ struct drm_panel *vbt_panel_init(struct intel_dsi
> *intel_dsi, u16 panel_id)
> >
> > /* This is cheating a bit with the cleanup. */
> > vbt_panel = devm_kzalloc(dev->dev, sizeof(*vbt_panel), GFP_KERNEL);
> > + if (!vbt_pannel)
> > + return NULL;
>

Oh sorry. There was a type.

>
> We have build bots and CI, but the least you must do is build the code
> you change before submitting patches.
>

Yes. Sorry.

>
> BR,
> Jani.
>
>
> >
> > vbt_panel->intel_dsi = intel_dsi;
> > drm_panel_init(&vbt_panel->panel);
>
> --
> Jani Nikula, Intel Open Source Technology Center
>

--
Regards
Insu Yun

[-- Attachment #1.2: Type: text/html, Size: 2232 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org