Re: [PATCH 01/49] drm/i915/bxt: Add BXT PCI ids

Antti Koskipää
2015-03-23T09:54:51Z

Reviewed-by: Antti Koskipää <antti.koskipaa@linux.intel.com>

On 03/17/2015 11:39 AM, Imre Deak wrote:
> From: Damien Lespiau <damien.lespiau@intel.com>
>
> v2: Switch to info->ring_mask and add VEBOX support.
> v3: Fold in update from Damien.
> v4: Add GEN_DEFAULT_PIPEOFFSETS and IVB_CURSOR_OFFSETS
> v5: set no-LLC (imre)
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> (v1,v4)
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> (v4)
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 14 +++++++++++++-
> include/drm/i915_pciids.h | 6 ++++++
> 2 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 82f8be4..4d50785 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -381,6 +381,17 @@ static const struct intel_device_info intel_skylake_gt3_info = {
> IVB_CURSOR_OFFSETS,
> };
>
> +static const struct intel_device_info intel_broxton_info = {
> + .is_preliminary = 1,
> + .gen = 9,
> + .need_gfx_hws = 1, .has_hotplug = 1,
> + .ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING,
> + .num_pipes = 3,
> + .has_ddi = 1,
> + GEN_DEFAULT_PIPEOFFSETS,
> + IVB_CURSOR_OFFSETS,
> +};
> +
> /*
> * Make sure any device matches here are from most specific to most
> * general. For example, since the Quanta match is based on the subsystem
> @@ -420,7 +431,8 @@ static const struct intel_device_info intel_skylake_gt3_info = {
> INTEL_CHV_IDS(&intel_cherryview_info), \
> INTEL_SKL_GT1_IDS(&intel_skylake_info), \
> INTEL_SKL_GT2_IDS(&intel_skylake_info), \
> - INTEL_SKL_GT3_IDS(&intel_skylake_gt3_info) \
> + INTEL_SKL_GT3_IDS(&intel_skylake_gt3_info), \
> + INTEL_BXT_IDS(&intel_broxton_info)
>
> static const struct pci_device_id pciidlist[] = { /* aka */
> INTEL_PCI_IDS,
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 6133723..bd0d644 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -287,4 +287,10 @@
> INTEL_SKL_GT3_IDS(info)
>
>
> +#define INTEL_BXT_IDS(info) \
> + INTEL_VGA_DEVICE(0x0A84, info), \
> + INTEL_VGA_DEVICE(0x0A85, info), \
> + INTEL_VGA_DEVICE(0x0A86, info), \
> + INTEL_VGA_DEVICE(0x0A87, info)
> +
> #endif /* _I915_PCIIDS_H */