Re: [PATCH 06/49] drm/i915/bxt: Broxton has 3 sprite planes on pipe A/B, 2 on pipe C

Daniel Vetter
2015-03-31T11:16:13Z

On Tue, Mar 17, 2015 at 11:39:32AM +0200, Imre Deak wrote:
> From: Damien Lespiau <damien.lespiau@intel.com>
>
> v2: Rebase on top of the for_each_pipe() change adding dev_priv as first
> argument.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/i915_dma.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index d49ed68..a94a970 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -585,7 +585,11 @@ static void intel_device_info_runtime_init(struct drm_device *dev)
>
> info = (struct intel_device_info *)&dev_priv->info;
>
> - if (IS_VALLEYVIEW(dev) || INTEL_INFO(dev)->gen == 9)
> + if (IS_BROXTON(dev)) {
> + info->num_sprites[PIPE_A] = 3;
> + info->num_sprites[PIPE_B] = 3;
> + info->num_sprites[PIPE_C] = 2;

Same todo as with skl: The last sprite plane is actually also the cursor,
and we really shouldn't expose both. Damien is signed up to fix that since
I don't want to drop the prelim_hw_support label for skl before we fix
this abi issue.
-Daniel

> + } else if (IS_VALLEYVIEW(dev) || INTEL_INFO(dev)->gen == 9)
> for_each_pipe(dev_priv, pipe)
> info->num_sprites[pipe] = 2;
> else
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation