Re: [PATCH 48/49] drm/i915/bxt: VSwing programming sequence

Sivakumar Thulasimani
2015-03-24T09:19:32Z

[-- Attachment #1.1: Type: text/plain, Size: 681 bytes --]

On 3/17/2015 3:10 PM, Imre Deak wrote:
> From: Vandana Kannan <vandana.kannan@intel.com>
>
> VSwing programming sequence as specified in the updated BXT BSpec
> ...
> ...
>
> +void bxt_ddi_vswing_sequence(struct drm_device *dev, u32 level,
> + enum port port, int type)
> +{
> + struct drm_i915_private *dev_priv = dev->dev_private;
> + const struct bxt_ddi_buf_trans *ddi_translations;
> + u32 n_entries, i;
> + uint32_t val;
> +
> + if (type == INTEL_OUTPUT_DISPLAYPORT || type == INTEL_OUTPUT_EDP) {
INTEL_OUPPUT_DP_MST might be needed here, please check once. otherwise
fine with the changes.
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>

[-- Attachment #1.2: Type: text/html, Size: 1482 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]