Re: [PATCH v2 23/49] drm/i915/bxt: Increase DDI buf idle timeout

Jani Nikula
2015-04-08T09:21:31Z

On Fri, 27 Mar 2015, Imre Deak <imre.deak@intel.com> wrote:
> From: Vandana Kannan <vandana.kannan@intel.com>
>
> For BXT, DDI buf idle timeout delay needs to be increased to 16us.
>
> Since this is a timeout value and we return as soon as the condition is
> realized, no penalty incurred for other platforms.
>
> v2:
> - remove TIMEOUT macro used only at a single place (Daniel)
>
> Suggested-by: Satheeshakrishna M <satheeshakrishna.m@intel.com>
> Cc: Satheeshakrishna M <satheeshakrishna.m@intel.com>
> Cc: Damien Lespiau <damien.lespiau@intel.com>
> Signed-off-by: Vandana Kannan <vandana.kannan@intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> (v1)

Might have a comment about bxt vs. others in there, but either way,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 8aee7d7..e24cd6f 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -322,7 +322,7 @@ static void intel_wait_ddi_buf_idle(struct drm_i915_private *dev_priv,
> uint32_t reg = DDI_BUF_CTL(port);
> int i;
>
> - for (i = 0; i < 8; i++) {
> + for (i = 0; i < 16; i++) {
> udelay(1);
> if (I915_READ(reg) & DDI_BUF_IS_IDLE)
> return;
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Technology Center