Re: [PATCH 05/89] drm/i915/skl: i915_swizzle_info gen9 fix

Daniel Vetter
2014-09-04T13:14:24Z

On Thu, Sep 04, 2014 at 12:26:31PM +0100, Damien Lespiau wrote:
> From: Robert Beckett <robert.beckett@intel.com>
>
> Fix ARB_MODE register read for gen >= 8 in i915_swizzle_info
>
> Signed-off-by: Robert Beckett <robert.beckett@intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

given that the swizzle stuff is gone, shouldn't we just have a gen9+
check to do nothing?
-Daniel

> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index d8389b2..88a4643 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1971,7 +1971,7 @@ static int i915_swizzle_info(struct seq_file *m, void *data)
> I915_READ(MAD_DIMM_C2));
> seq_printf(m, "TILECTL = 0x%08x\n",
> I915_READ(TILECTL));
> - if (IS_GEN8(dev))
> + if (INTEL_INFO(dev)->gen >= 8)
> seq_printf(m, "GAMTARBMODE = 0x%08x\n",
> I915_READ(GAMTARBMODE));
> else
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch