Re: [PATCH 74/89 v4] drm/i915/skl: Implement queue_flip

Damien Lespiau
2014-09-30T12:19:22Z

On Tue, Sep 30, 2014 at 09:08:35AM -0300, Paulo Zanoni wrote:
> > +static int intel_gen9_queue_flip(struct drm_device *dev,
> > + struct drm_crtc *crtc,
> > + struct drm_framebuffer *fb,
> > + struct drm_i915_gem_object *obj,
> > + struct intel_engine_cs *ring,
> > + uint32_t flags)
> > +{
> > + struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
> > + uint32_t plane = 0, stride;
> > + int ret;
> > +
> > + switch(intel_crtc->pipe) {
>
> I just noticed that the gen7 function checks for intel_crtc->plane
> instead of ->pipe. This shouldn't be a problem on Gen 9, right?
>
> If that's not a problem: Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Indeed, not a problem for all the platforms where crtc->plane ==
crtc->pipe (and I used pipe because I wanted to forget about that dark
past).

AFAICS, the only case where crtc->plane != crtc->pipe is when:

(HAS_FBC(dev) && INTEL_INFO(dev)->gen < 4) is true

(see intel_primary_plane_create())

Thanks for the review!

--
Damien