Re: [PATCH 59/89] drm/i915/skl: Structure/enum definitions for SKL clocks

Damien Lespiau
2014-11-04T16:13:23Z

On Mon, Sep 22, 2014 at 03:25:30PM -0300, Paulo Zanoni wrote:
> 2014-09-04 8:27 GMT-03:00 Damien Lespiau <damien.lespiau@intel.com>:
> > From: Satheeshakrishna M <satheeshakrishna.m@intel.com>
> >
> > Adding structure/enum for SKL clocking implementation.
> >
> > v2: Addressed Damien's comment
> > - Removed internal structure from this header file
> >
> > v3: Stove this into the generic intel_dpll_id enum and give them the established
> > DPLL_ID_ prefixes. (Daniel)
> >
> > v4: - We'll only try to share DPLL1/2/3, leaving DPLL0 to eDP
> > - Use SKL in the skylake shared DPLL names
> > - Re-add the skl_dpll enum
> > (Damien)
> >
> > v5: Remove SKL_DPLL_NONE (Daniel)
> >
> > Signed-off-by: Satheeshakrishna M <satheeshakrishna.m@intel.com> (v2)
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> (v4,v5)
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> (v3)
>
> The changes contained on this patch should be part of another patch. I
> can't really review this if I don't know how those things, especially
> enum skl_dpll are going to be used. And it also makes the lives of
> backporters harder.
>
> Also, I guess that a patch with 3 signed-off-by stamps shouldn't
> really need an additional reviewed-by stamp, right? So maybe this
> should just be merged.

Well, I can add my r-b tag here, why not.

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org