Re: [PATCH 57/89] drm/i915: Rewrite ABS_DIFF() in a safer manner

Damien Lespiau
2014-09-04T12:32:39Z

On Thu, Sep 04, 2014 at 03:11:24PM +0300, Jani Nikula wrote:
> On Thu, 04 Sep 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> > The new version of the macro does a few things better:
> > - protect the arguments,
> > - only evaluate the arguments once,
> > - check that the arguments are of the same type,
> >
> > Change LC_FREQ_2K to be a unsigned 64bit constant and removed the '()'
> > from the caller as a result.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Can be picked up for dinq separate from this series, right?

Yes, it can indeed.

--
Damien