Re: [PATCH 30/89] drm/i915/skl: SKL backlight enabling

Rodrigo Vivi
2014-09-17T01:56:42Z

[-- Attachment #1.1: Type: text/plain, Size: 1492 bytes --]

This is wrong.

A skl_enable_backlight must be created setting c8254 propperly without the
shift 16. Also maybe setting c8354h.

On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau <damien.lespiau@intel.com>
wrote:

> From: Satheeshakrishna M <satheeshakrishna.m@intel.com>
>
> Extending the BDW backlight implementation to SKL.
>
> Signed-off-by: Satheeshakrishna M <satheeshakrishna.m@intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/intel_panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_panel.c
> b/drivers/gpu/drm/i915/intel_panel.c
> index 1878447..d69a3cb6 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -1317,7 +1317,7 @@ void intel_panel_init_backlight_funcs(struct
> drm_device *dev)
> {
> struct drm_i915_private *dev_priv = dev->dev_private;
>
> - if (IS_BROADWELL(dev)) {
> + if (IS_BROADWELL(dev) || (INTEL_INFO(dev)->gen >= 9)) {
> dev_priv->display.setup_backlight = bdw_setup_backlight;
> dev_priv->display.enable_backlight = bdw_enable_backlight;
> dev_priv->display.disable_backlight =
> pch_disable_backlight;
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>

--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

[-- Attachment #1.2: Type: text/html, Size: 2453 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org