Re: [PATCH 30/89] drm/i915/skl: SKL backlight enabling

Rodrigo Vivi
2014-09-17T14:56:04Z

[-- Attachment #1.1: Type: text/plain, Size: 3003 bytes --]

Oh Jani showed me that I was looking to the wrong spec.

So just ignore my previous comments and use:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

On Wed, Sep 17, 2014 at 6:46 AM, Rodrigo Vivi <rodrigo.vivi@gmail.com>
wrote:

> besides the override bit,
> c8254h for bdw has the pwm frequency on 31:16 and on skl the frequency on
> same register address is from 31:0 and also a pwm 2 register on c8354h.
> So I think this patch can be right if there is an if IS_SKL without the >>
> 16 part inside bdw_enable_backlight.
>
>
> On Wed, Sep 17, 2014 at 5:09 AM, Jani Nikula <jani.nikula@linux.intel.com>
> wrote:
>
>> On Wed, 17 Sep 2014, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
>> > This is wrong.
>> >
>> > A skl_enable_backlight must be created setting c8254 propperly without
>> the
>> > shift 16. Also maybe setting c8354h.
>>
>> Nope, this is all right for skl/spt, with the small exception that it'll
>> need the equivalent of [1]. I'll post another version addressing Ville's
>> comments.
>>
>> BR,
>> Jani.
>>
>>
>> [1] http://mid.gmane.org/87y4tzefmz.fsf@intel.com
>>
>>
>> >
>> >
>> > On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau <
>> damien.lespiau@intel.com>
>> > wrote:
>> >
>> >> From: Satheeshakrishna M <satheeshakrishna.m@intel.com>
>> >>
>> >> Extending the BDW backlight implementation to SKL.
>> >>
>> >> Signed-off-by: Satheeshakrishna M <satheeshakrishna.m@intel.com>
>> >> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>> >> ---
>> >> drivers/gpu/drm/i915/intel_panel.c | 2 +-
>> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/gpu/drm/i915/intel_panel.c
>> >> b/drivers/gpu/drm/i915/intel_panel.c
>> >> index 1878447..d69a3cb6 100644
>> >> --- a/drivers/gpu/drm/i915/intel_panel.c
>> >> +++ b/drivers/gpu/drm/i915/intel_panel.c
>> >> @@ -1317,7 +1317,7 @@ void intel_panel_init_backlight_funcs(struct
>> >> drm_device *dev)
>> >> {
>> >> struct drm_i915_private *dev_priv = dev->dev_private;
>> >>
>> >> - if (IS_BROADWELL(dev)) {
>> >> + if (IS_BROADWELL(dev) || (INTEL_INFO(dev)->gen >= 9)) {
>> >> dev_priv->display.setup_backlight =
>> bdw_setup_backlight;
>> >> dev_priv->display.enable_backlight =
>> bdw_enable_backlight;
>> >> dev_priv->display.disable_backlight =
>> >> pch_disable_backlight;
>> >> --
>> >> 1.8.3.1
>> >>
>> >> _______________________________________________
>> >> Intel-gfx mailing list
>> >> Intel-gfx@lists.freedesktop.org
>> >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> >>
>> >
>> >
>> >
>> > --
>> > Rodrigo Vivi
>> > Blog: http://blog.vivi.eng.br
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>
>> --
>> Jani Nikula, Intel Open Source Technology Center
>>
>
>
>
> --
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br
>
>

--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

[-- Attachment #1.2: Type: text/html, Size: 5271 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org