From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: i915: reduce memory footprint when debugging Date: Mon, 01 Sep 2014 15:32:54 +0300 Message-ID: <87k35nfrm1.fsf@intel.com> References: <1409569921-29757-1-git-send-email-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 919F66E1A2 for ; Mon, 1 Sep 2014 05:33:01 -0700 (PDT) In-Reply-To: <1409569921-29757-1-git-send-email-andriy.shevchenko@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, David Airlie , ville.syrjala@linux.intel.com Cc: Andy Shevchenko List-Id: intel-gfx@lists.freedesktop.org On Mon, 01 Sep 2014, Andy Shevchenko wrote: > There is no need to use hex_dump_to_buffer() since we have a kernel helper to > dump up to 64 bytes just via printk(). In our case the actual size is 15 bytes. Reviewed-by: Jani Nikula > Signed-off-by: Andy Shevchenko > --- > drivers/gpu/drm/i915/intel_dp.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 6db84bf..00b79f5 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -3318,15 +3318,11 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp) > struct drm_device *dev = dig_port->base.base.dev; > struct drm_i915_private *dev_priv = dev->dev_private; > > - char dpcd_hex_dump[sizeof(intel_dp->dpcd) * 3]; > - > if (intel_dp_dpcd_read_wake(&intel_dp->aux, 0x000, intel_dp->dpcd, > sizeof(intel_dp->dpcd)) < 0) > return false; /* aux transfer failed */ > > - hex_dump_to_buffer(intel_dp->dpcd, sizeof(intel_dp->dpcd), > - 32, 1, dpcd_hex_dump, sizeof(dpcd_hex_dump), false); > - DRM_DEBUG_KMS("DPCD: %s\n", dpcd_hex_dump); > + DRM_DEBUG_KMS("DPCD: %*ph\n", sizeof(intel_dp->dpcd), intel_dp->dpcd); > > if (intel_dp->dpcd[DP_DPCD_REV] == 0) > return false; /* DPCD not present */ > -- > 2.1.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center