From: Jani Nikula <jani.nikula@linux.intel.com>
To: Paulo Zanoni <przanoni@gmail.com>,
Damien Lespiau <damien.lespiau@intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: Supporting fused display configurations v4
Date: Tue, 07 Jan 2014 10:23:58 +0200 [thread overview]
Message-ID: <87k3ecci8x.fsf@intel.com> (raw)
In-Reply-To: <CA+gsUGSQf8YPegJxyyiRU+0KkYv7aRRFeYgrtNefKEzNvKNhSA@mail.gmail.com>
On Tue, 07 Jan 2014, Paulo Zanoni <przanoni@gmail.com> wrote:
> - You removed INTEL_INFO, but all those IS_SOMETHING and HAS_SOMETHING
> macros still accept dev as argument instead of dev_priv. Do we have
> plans to change this too? I can remember many places where I had to
> add a "dev" variable just because of these macros. Perhaps maybe the
> new goal is a series removing the to_i915 macro? I could see a lot of
> code getting almost entirely rid of "dev" with these changes.
You can get from dev to dev_priv and back easily enough. Replacing dev
with dev_priv in function parameters seems like pointless churn to
me. If (and that's a big if) we wanted to "standardize" on one or the
other, I'd go for struct drm_device *dev.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-01-07 8:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 19:17 Supporting fused display configurations v4 Damien Lespiau
2014-01-06 19:17 ` [PATCH 01/12] drm/i915: Get rid of the INTEL_INFO() usage in i915_drv.h Damien Lespiau
2014-01-06 19:17 ` [PATCH 02/12] drm/i915: Convert a few WM functions to use struct drm_i915_private directly Damien Lespiau
2014-01-06 19:17 ` [PATCH 03/12] drm/i915: Mass replace INTEL_INFO() by dev_priv->info Damien Lespiau
2014-01-06 19:17 ` [PATCH 04/12] drm/i915: Finish replacing INTEL_INFO() by direct dev_priv usage Damien Lespiau
2014-01-06 19:17 ` [PATCH 05/12] drm/i915: Remove INTEL_INFO() Damien Lespiau
2014-01-26 15:09 ` Daniel Vetter
2014-01-06 19:17 ` [PATCH 06/12] drm/i915: Constify the drm_i915_private pointer a bit more Damien Lespiau
2014-01-06 19:17 ` [PATCH 07/12] drm/i915: Make the intel_device_info structure kept in dev_priv writable Damien Lespiau
2014-01-06 19:17 ` [PATCH 08/12] drm/i915: Move num_plane to the intel_device_info structure Damien Lespiau
2014-01-06 19:17 ` [PATCH 09/12] drm/i915: Consolidate FUSE_STRAP in one set of defines Damien Lespiau
2014-01-06 19:17 ` [PATCH 10/12] drm/i915: Disable display when fused off Damien Lespiau
2014-01-06 19:17 ` [PATCH 11/12] drm/i915: Remove the Quanta special case Damien Lespiau
2014-01-06 19:17 ` [PATCH 12/12] drm/i915: Use I915_MAX_PIPES in the pipe/plane_to_crtc_mapping definitions Damien Lespiau
2014-01-06 22:05 ` Supporting fused display configurations v4 Paulo Zanoni
2014-01-07 8:07 ` Daniel Vetter
2014-01-07 16:55 ` Damien Lespiau
2014-01-07 8:23 ` Jani Nikula [this message]
2014-01-07 10:00 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3ecci8x.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox