From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH] drm/i915: Kill dangerous pending-flip
	debugging
Date: Wed, 26 May 2010 14:12:01 -0700
Message-ID: <87k4qql65a.fsf@pollan.anholt.net>
References: <1273913823-29591-1-git-send-email-chris@chris-wilson.co.uk>
	<20100515093117.254dfb1b@blake>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1984776485=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <20100515093117.254dfb1b@blake>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Mime-version: 1.0
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>, Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, stable@kernel.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1984776485==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Sat, 15 May 2010 09:31:17 -0700, Jesse Barnes <jbarnes@virtuousgeek.org>=
 wrote:
> On Sat, 15 May 2010 09:57:03 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>=20
> > We can, by virtue of a vblank interrupt firing in the middle of
> > setting up the unpin work (i.e. after we set the unpin_work field and
> > before we write to the ringbuffer) enter intel_finish_page_flip()
> > prior to receiving the pending flip notification. Therefore we can
> > expect to hit intel_finish_page_flip() under normal circumstances
> > without a pending flip and even without installing the
> > pending_flip_obj. This is exacerbated by aperture thrashing whilst
> > binding the framebuffer
> >=20
> > References:
> >=20
> >   Bug 28079 - "glresize" causes kernel panic in
> > intel_finish_page_flip.
> > https://bugs.freedesktop.org/show_bug.cgi?id=3D28079
>=20
> Yeah, that's true.  Good catch.
>=20
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Applied.  Thanks!

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkv9jqEACgkQHUdvYGzw6vfPEgCggb6ar5rZTEOz5ebOPqjvnDkY
18AAn3WM/K2YRoJz9vyB4bzCD7Vb36I2
=ijsA
-----END PGP SIGNATURE-----
--=-=-=--

--===============1984776485==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1984776485==--