Re: [PATCH 1/6] drm/nouveau/acr/ga102: remove unused but set variable

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 31 Jan 2024, Danilo Krummrich <dakr@redhat.com> wrote:
> On 1/10/24 18:39, Jani Nikula wrote:
>> Fix the W=1 warning -Wunused-but-set-variable.
>> 
>> Cc: Karol Herbst <kherbst@redhat.com>
>> Cc: Lyude Paul <lyude@redhat.com>
>> Cc: Danilo Krummrich <dakr@redhat.com>
>> Cc: nouveau@lists.freedesktop.org
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Danilo Krummrich <dakr@redhat.com>

Thanks, pushed to drm-misc-next.

>
>> ---
>>   drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
>> index f36a359d4531..bd104a030243 100644
>> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
>> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
>> @@ -218,7 +218,7 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
>>   		const struct firmware *hsbl;
>>   		const struct nvfw_ls_hsbl_bin_hdr *hdr;
>>   		const struct nvfw_ls_hsbl_hdr *hshdr;
>> -		u32 loc, sig, cnt, *meta;
>> +		u32 sig, cnt, *meta;
>>   
>>   		ret = nvkm_firmware_load_name(subdev, path, "hs_bl_sig", ver, &hsbl);
>>   		if (ret)
>> @@ -227,7 +227,6 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
>>   		hdr = nvfw_ls_hsbl_bin_hdr(subdev, hsbl->data);
>>   		hshdr = nvfw_ls_hsbl_hdr(subdev, hsbl->data + hdr->header_offset);
>>   		meta = (u32 *)(hsbl->data + hshdr->meta_data_offset);
>> -		loc = *(u32 *)(hsbl->data + hshdr->patch_loc);
>>   		sig = *(u32 *)(hsbl->data + hshdr->patch_sig);
>>   		cnt = *(u32 *)(hsbl->data + hshdr->num_sig);
>>   
>

-- 
Jani Nikula, Intel