From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBB24C07545 for ; Wed, 25 Oct 2023 12:08:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 75DEB10E59A; Wed, 25 Oct 2023 12:08:09 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 167EF10E59A for ; Wed, 25 Oct 2023 12:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698235687; x=1729771687; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=evn2sMULPbDhmy7wW8R+xytYxNYPPIZr3HY9je6TDyA=; b=iDz7ifWIvaC/DB6ioDi8Fl94U0xm+Gtf1LiFgZcMhGhwLASdqlZiWPcM zVhD4bXB+v+RIy1NouPUYt7cq01SyCheCoKYaZhHiAckYchB9pQAepAbJ mub10U8hg4P6DqXX/O/Hb2d03huirhfs53mjwmZwOYj12jxKFzsDqUpfW txuTL1ldZAfPCRfgI0djOwuqnuExDSeKf292AgbQVK55pt7ZzMVT9x757 jFVEb/jlJI5sJpA6LQKHAlTcHXW3pVOYBNE6H7QWi0LozKrJNPX4GBgU/ BQcw6U2rhHEW1XPpC+XHdjZeWtPb1++wS2vZrnAEO/iGa1pYT9RHKuzXG w==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="387109274" X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="387109274" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 05:08:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="6537194" Received: from dtorrice-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.33.83]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 05:06:45 -0700 From: Jani Nikula To: "Borah, Chaitanya Kumar" , "Govindapillai, Vinod" , "intel-gfx@lists.freedesktop.org" In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231018102723.16915-1-vinod.govindapillai@intel.com> <20231018102723.16915-2-vinod.govindapillai@intel.com> Date: Wed, 25 Oct 2023 15:08:02 +0300 Message-ID: <87lebq9a71.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH v4 1/2] drm/i915/display: debugfs entry to list display capabilities X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 19 Oct 2023, "Borah, Chaitanya Kumar" wrote: >> -----Original Message----- >> From: Govindapillai, Vinod >> Sent: Wednesday, October 18, 2023 3:57 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Govindapillai, Vinod ; Sharma, Swati2 >> ; Borah, Chaitanya Kumar >> >> Subject: [PATCH v4 1/2] drm/i915/display: debugfs entry to list display >> capabilities >> >> Create a separate debugfs entry to list the display capabilities IGT can rely on >> this debugfs entry for tests that depend on display device and display runtime >> info for both xe and i915 drivers. >> >> v2: rename the entry to i915_display_capabilities (Chaitanya) >> >> Signed-off-by: Vinod Govindapillai > > Assuming that it has no other impact in user-space. The change looks LGTM. > > Reviewed-by: Chaitanya Kumar Borah Thanks for the patches and review, pushed the first patch. Please get the igt change merged before pushing the second patch. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c >> b/drivers/gpu/drm/i915/display/intel_display_debugfs.c >> index fbe75d47a165..b0248dfa8dea 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c >> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c >> @@ -641,6 +641,17 @@ static int i915_display_info(struct seq_file *m, void >> *unused) >> return 0; >> } >> >> +static int i915_display_capabilities(struct seq_file *m, void *unused) >> +{ >> + struct drm_i915_private *i915 = node_to_i915(m->private); >> + struct drm_printer p = drm_seq_file_printer(m); >> + >> + intel_display_device_info_print(DISPLAY_INFO(i915), >> + DISPLAY_RUNTIME_INFO(i915), &p); >> + >> + return 0; >> +} >> + >> static int i915_shared_dplls_info(struct seq_file *m, void *unused) { >> struct drm_i915_private *dev_priv = node_to_i915(m->private); @@ >> -1059,6 +1070,7 @@ static const struct drm_info_list >> intel_display_debugfs_list[] = { >> {"i915_gem_framebuffer", i915_gem_framebuffer_info, 0}, >> {"i915_power_domain_info", i915_power_domain_info, 0}, >> {"i915_display_info", i915_display_info, 0}, >> + {"i915_display_capabilities", i915_display_capabilities, 0}, >> {"i915_shared_dplls_info", i915_shared_dplls_info, 0}, >> {"i915_dp_mst_info", i915_dp_mst_info, 0}, >> {"i915_ddb_info", i915_ddb_info, 0}, >> -- >> 2.34.1 > -- Jani Nikula, Intel