Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Sanitize the display fused-off check on GEN7/8

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 08 Feb 2023, Imre Deak <imre.deak@intel.com> wrote:
> Detecting in intel_device_info_runtime_init() that the display is fused
> off or not present should only zero intel_runtime_info::pipe_mask, while
> the other related masks will be accordingly zeroed later in the
> function. Remove the redundant zeroing of the related fields on GEN7/8.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_device_info.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index e07deb4630f97..b9ec184b5aab5 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -465,8 +465,6 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
>  			drm_info(&dev_priv->drm,
>  				 "Display fused off, disabling\n");
>  			runtime->pipe_mask = 0;
> -			runtime->cpu_transcoder_mask = 0;
> -			runtime->fbc_mask = 0;
>  		} else if (fuse_strap & IVB_PIPE_C_DISABLE) {
>  			drm_info(&dev_priv->drm, "PipeC fused off\n");
>  			runtime->pipe_mask &= ~BIT(PIPE_C);

-- 
Jani Nikula, Intel Open Source Graphics Center