From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872C1C4338F for ; Tue, 24 Aug 2021 16:27:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 460AC61248 for ; Tue, 24 Aug 2021 16:27:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 460AC61248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC33E6E063; Tue, 24 Aug 2021 16:27:54 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6602D6E063 for ; Tue, 24 Aug 2021 16:27:53 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10086"; a="217380116" X-IronPort-AV: E=Sophos;i="5.84,347,1620716400"; d="scan'208";a="217380116" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2021 09:27:52 -0700 X-IronPort-AV: E=Sophos;i="5.84,347,1620716400"; d="scan'208";a="526685039" Received: from romerosa-mobl.amr.corp.intel.com (HELO localhost) ([10.249.44.170]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2021 09:27:51 -0700 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210823093645.10464-1-jani.nikula@intel.com> Date: Tue, 24 Aug 2021 19:27:48 +0300 Message-ID: <87lf4qg64b.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH] drm/i915/fdi: make intel_fdi_link_freq() return int X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 24 Aug 2021, Ville Syrj=C3=A4l=C3=A4 wrote: > On Mon, Aug 23, 2021 at 12:36:45PM +0300, Jani Nikula wrote: >> The unsigned doesn't help us here. >>=20 >> Cc: Ville Syrj=C3=A4l=C3=A4 >> Suggested-by: Ville Syrj=C3=A4l=C3=A4 >> Signed-off-by: Jani Nikula > > Reviewed-by: Ville Syrj=C3=A4l=C3=A4 Thanks, pushed. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_fdi.c | 2 +- >> drivers/gpu/drm/i915/display/intel_fdi.h | 4 +--- >> 2 files changed, 2 insertions(+), 4 deletions(-) >>=20 >> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c b/drivers/gpu/drm/= i915/display/intel_fdi.c >> index 970a57369b05..13f8ba4c9188 100644 >> --- a/drivers/gpu/drm/i915/display/intel_fdi.c >> +++ b/drivers/gpu/drm/i915/display/intel_fdi.c >> @@ -95,7 +95,7 @@ static int ilk_check_fdi_lanes(struct drm_device *dev,= enum pipe pipe, >> } >> } >>=20=20 >> -u32 intel_fdi_link_freq(struct drm_i915_private *i915, >> +int intel_fdi_link_freq(struct drm_i915_private *i915, >> const struct intel_crtc_state *pipe_config) >> { >> if (HAS_DDI(i915)) >> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.h b/drivers/gpu/drm/= i915/display/intel_fdi.h >> index fd63a6a53fca..2c8ffd9ceaed 100644 >> --- a/drivers/gpu/drm/i915/display/intel_fdi.h >> +++ b/drivers/gpu/drm/i915/display/intel_fdi.h >> @@ -6,15 +6,13 @@ >> #ifndef _INTEL_FDI_H_ >> #define _INTEL_FDI_H_ >>=20=20 >> -#include >> - >> struct drm_i915_private; >> struct intel_crtc; >> struct intel_crtc_state; >> struct intel_encoder; >>=20=20 >> #define I915_DISPLAY_CONFIG_RETRY 1 >> -u32 intel_fdi_link_freq(struct drm_i915_private *i915, >> +int intel_fdi_link_freq(struct drm_i915_private *i915, >> const struct intel_crtc_state *pipe_config); >> int ilk_fdi_compute_config(struct intel_crtc *intel_crtc, >> struct intel_crtc_state *pipe_config); >> --=20 >> 2.20.1 --=20 Jani Nikula, Intel Open Source Graphics Center