From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3F0C4743C for ; Wed, 23 Jun 2021 16:45:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 334F2610A0 for ; Wed, 23 Jun 2021 16:45:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 334F2610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D67766E957; Wed, 23 Jun 2021 16:45:28 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE0076E977 for ; Wed, 23 Jun 2021 16:45:27 +0000 (UTC) IronPort-SDR: xiWl8GuTxxfbYr/8J+z+PyD+slwT8rYbwvcER48GG6mquDe3FInzirPwLq07RAfrYMIcNCYcC+ X5IbC/J3O7vw== X-IronPort-AV: E=McAfee;i="6200,9189,10024"; a="207241083" X-IronPort-AV: E=Sophos;i="5.83,294,1616482800"; d="scan'208";a="207241083" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2021 09:45:24 -0700 IronPort-SDR: j7IIqjtzLTLV5KmRzVZ7vMmPtBVLYmNfAQqZ01MkHv+aQnsXBaaq5gHzEUNMQjwlHGeSUooHKA FyeraWIBD45Q== X-IronPort-AV: E=Sophos;i="5.83,294,1616482800"; d="scan'208";a="487382429" Received: from huynhn-mobl1.amr.corp.intel.com (HELO localhost) ([10.249.35.176]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2021 09:45:20 -0700 From: Jani Nikula To: Lee Shawn C , intel-gfx@lists.freedesktop.org In-Reply-To: <20210622153225.24578-1-shawn.c.lee@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210622133107.7422-1-shawn.c.lee@intel.com> <20210622153225.24578-1-shawn.c.lee@intel.com> Date: Wed, 23 Jun 2021 19:45:17 +0300 Message-ID: <87lf70ttr6.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v3] drm/i915: keep backlight_enable on until turn eDP display off X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cooper Chiou Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 22 Jun 2021, Lee Shawn C wrote: > This workaround is specific for a particular panel on Google > chromebook project. When user space daemon enter idle state. > It request adjust brightness to 0, turn backlight_enable signal > off and keep eDP main link active. > > On general LCD, this behavior might not be a problem. > But on this panel, its tcon would expect source to execute > full eDP power off sequence after drop backlight_enable signal. > Without eDP power off sequence. Even source try to turn > backlight_enable signal on and restore proper brightness level. > This panel is not able to light on again. > > This WA ignored the request from user space daemon to disable > backlight_enable signal and keep it on always. When user space > request kernel to turn eDP display off, kernel driver still > can control backlight_enable signal properly. It would not > impact standard eDP power off sequence. > > v2: modify the quirk name and debug messages. > unregister backlight.power callback for specific device. > > Cc: Ville Syrjala > Cc: Imre Deak > Cc: Jani Nikula > Cc: Cooper Chiou > > Signed-off-by: Lee Shawn C > --- > drivers/gpu/drm/i915/display/intel_dp.c | 3 +- > drivers/gpu/drm/i915/display/intel_quirks.c | 34 +++++++++++++++++++++ > drivers/gpu/drm/i915/i915_drv.h | 1 + > 3 files changed, 37 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 6cc03b9e4321..d3312b9bcc6f 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5238,7 +5238,8 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, > } > > intel_panel_init(&intel_connector->panel, fixed_mode, downclock_mode); > - intel_connector->panel.backlight.power = intel_pps_backlight_power; > + if (!(dev_priv->quirks & QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK)) > + intel_connector->panel.backlight.power = intel_pps_backlight_power; > intel_panel_setup_backlight(connector, pipe); > > if (fixed_mode) { > diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c > index 98dd787b00e3..5f3cb006db01 100644 > --- a/drivers/gpu/drm/i915/display/intel_quirks.c > +++ b/drivers/gpu/drm/i915/display/intel_quirks.c > @@ -53,6 +53,12 @@ static void quirk_increase_ddi_disabled_time(struct drm_i915_private *i915) > drm_info(&i915->drm, "Applying Increase DDI Disabled quirk\n"); > } > > +static void quirk_no_pps_backlight_power_hook(struct drm_i915_private *i915) > +{ > + i915->quirks |= QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK; > + drm_info(&i915->drm, "Applying no pps backlight power quirk\n"); > +} > + > struct intel_quirk { > int device; > int subsystem_vendor; > @@ -72,6 +78,12 @@ static int intel_dmi_reverse_brightness(const struct dmi_system_id *id) > return 1; > } > > +static int intel_dmi_no_pps_backlight(const struct dmi_system_id *id) > +{ > + DRM_INFO("This workaround prevented panel backlight issue on %s device\n", id->ident); Not sure I like the verbose "This workaround ..." style messages. Contrast with what the messages for reverse polarity would be via dmi: "Backlight polarity reversed on %s\n" -> "applying inverted panel brightness quirk\n" > + return 1; > +} > + > static const struct intel_dmi_quirk intel_dmi_quirks[] = { > { > .dmi_id_list = &(const struct dmi_system_id[]) { > @@ -96,6 +108,28 @@ static const struct intel_dmi_quirk intel_dmi_quirks[] = { > }, > .hook = quirk_invert_brightness, > }, > + { > + .dmi_id_list = &(const struct dmi_system_id[]) { > + { > + .callback = intel_dmi_no_pps_backlight, > + .ident = "Google Lillipup", > + .matches = {DMI_MATCH(DMI_BOARD_VENDOR, "Google"), > + DMI_MATCH(DMI_BOARD_NAME, "Lindar"), > + DMI_MATCH(DMI_PRODUCT_SKU, "sku524294"), > + }, > + }, > + { > + .callback = intel_dmi_no_pps_backlight, > + .ident = "Google Lillipup", > + .matches = {DMI_MATCH(DMI_BOARD_VENDOR, "Google"), > + DMI_MATCH(DMI_BOARD_NAME, "Lindar"), > + DMI_MATCH(DMI_PRODUCT_SKU, "sku524295"), > + }, I think you should use DMI_EXACT_MATCH instead of DMI_MATCH. The former users strcmp while the latter uses strstr for comparison. The .ident string should probably be different for the two cases; otherwise the DRM_INFO() logging above does not differentiate between the two. Sorry for not catching all of these at v1 review. Anyway, this is just small details, the approach is fine. BR, Jani. > + }, > + { } > + }, > + .hook = quirk_no_pps_backlight_power_hook, > + }, > }; > > static struct intel_quirk intel_quirks[] = { > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 01e11fe38642..5a065be0792a 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -467,6 +467,7 @@ struct i915_drrs { > #define QUIRK_PIN_SWIZZLED_PAGES (1<<5) > #define QUIRK_INCREASE_T12_DELAY (1<<6) > #define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7) > +#define QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK (1<<8) > > struct intel_fbdev; > struct intel_fbc_work; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx