From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4E9FC3F2D1 for ; Mon, 2 Mar 2020 16:20:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C191821D56 for ; Mon, 2 Mar 2020 16:20:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C191821D56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B3EA6E560; Mon, 2 Mar 2020 16:20:06 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D8936E554 for ; Mon, 2 Mar 2020 16:20:04 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 08:20:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,507,1574150400"; d="scan'208";a="286662535" Received: from gaia.fi.intel.com ([10.237.72.192]) by FMSMGA003.fm.intel.com with ESMTP; 02 Mar 2020 08:20:03 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 5BD0C5C1DA2; Mon, 2 Mar 2020 18:18:48 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200302085812.4172450-8-chris@chris-wilson.co.uk> References: <20200302085812.4172450-1-chris@chris-wilson.co.uk> <20200302085812.4172450-8-chris@chris-wilson.co.uk> Date: Mon, 02 Mar 2020 18:18:48 +0200 Message-ID: <87lfoi7ms7.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 08/22] drm/i915: Wrap i915_active in a simple kreffed struct X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > For conveniences of callers that just want to use an i915_active to > track a wide array of concurrent timelines, wrap the base i915_active > struct inside a kref. This i915_active will self-destruct after use. > I looks ok and I would buy this. However I didn't manage to find user. -Mika > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_active.c | 53 ++++++++++++++++++++++++++++++ > drivers/gpu/drm/i915/i915_active.h | 4 +++ > 2 files changed, 57 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c > index 7b3d6c12ad61..1826de14d2da 100644 > --- a/drivers/gpu/drm/i915/i915_active.c > +++ b/drivers/gpu/drm/i915/i915_active.c > @@ -881,6 +881,59 @@ void i915_active_noop(struct dma_fence *fence, struct dma_fence_cb *cb) > active_fence_cb(fence, cb); > } > > +struct auto_active { > + struct i915_active base; > + struct kref ref; > +}; > + > +struct i915_active *i915_active_get(struct i915_active *ref) > +{ > + struct auto_active *aa = container_of(ref, typeof(*aa), base); > + > + kref_get(&aa->ref); > + return &aa->base; > +} > + > +static void auto_release(struct kref *ref) > +{ > + struct auto_active *aa = container_of(ref, typeof(*aa), ref); > + > + i915_active_fini(&aa->base); > + kfree(aa); > +} > + > +void i915_active_put(struct i915_active *ref) > +{ > + struct auto_active *aa = container_of(ref, typeof(*aa), base); > + > + kref_put(&aa->ref, auto_release); > +} > + > +static int auto_active(struct i915_active *ref) > +{ > + i915_active_get(ref); > + return 0; > +} > + > +static void auto_retire(struct i915_active *ref) > +{ > + i915_active_put(ref); > +} > + > +struct i915_active *i915_active_create(void) > +{ > + struct auto_active *aa; > + > + aa = kmalloc(sizeof(*aa), GFP_KERNEL); > + if (!aa) > + return NULL; > + > + kref_init(&aa->ref); > + i915_active_init(&aa->base, auto_active, auto_retire); > + > + return &aa->base; > +} > + > #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) > #include "selftests/i915_active.c" > #endif > diff --git a/drivers/gpu/drm/i915/i915_active.h b/drivers/gpu/drm/i915/i915_active.h > index 973ff0447c6c..7e438501333e 100644 > --- a/drivers/gpu/drm/i915/i915_active.h > +++ b/drivers/gpu/drm/i915/i915_active.h > @@ -215,4 +215,8 @@ void i915_request_add_active_barriers(struct i915_request *rq); > void i915_active_print(struct i915_active *ref, struct drm_printer *m); > void i915_active_unlock_wait(struct i915_active *ref); > > +struct i915_active *i915_active_create(void); > +struct i915_active *i915_active_get(struct i915_active *ref); > +void i915_active_put(struct i915_active *ref); > + > #endif /* _I915_ACTIVE_H_ */ > -- > 2.25.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx