From: Jani Nikula <jani.nikula@linux.intel.com>
To: fred gao <fred.gao@intel.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhi Wang <zhi.a.wang@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Cc: Christos Gkekas <chris.gekas@gmail.com>
Subject: Re: [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser
Date: Mon, 16 Oct 2017 12:08:19 +0300 [thread overview]
Message-ID: <87lgkbmpdo.fsf@intel.com> (raw)
In-Reply-To: <1508106723-17935-1-git-send-email-chris.gekas@gmail.com>
On Sun, 15 Oct 2017, Christos Gkekas <chris.gekas@gmail.com> wrote:
> Delete variables 'gma_bottom' that are set but never used.
Please use common sense in choosing the mailing lists and maintainers
you send patches to. In this case, intel-gvt-dev would have been
sufficient, with intel-gfx more than enough. Including Dave or dri-devel
or LKML is excessive. Arguably including Joonas, Rodrigo and myself is
also too much.
Please at least put it in context. This is a non-functional change
removing some dead code, not an urgent fix to some hair rising jaw
dropping bug.
Thanks,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-16 9:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 22:32 [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser Christos Gkekas
2017-10-16 9:08 ` Jani Nikula [this message]
2017-10-16 19:02 ` Christos Gkekas
2017-10-17 7:25 ` Jani Nikula
2017-10-16 10:31 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-16 16:14 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-10-23 16:35 ` [PATCH] " Zhi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgkbmpdo.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris.gekas@gmail.com \
--cc=fred.gao@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox