[maintainer-tools PATCH 0/4] dim: shellcheck fixes

[maintainer-tools PATCH 0/4] dim: shellcheck fixes

[Jani Nikula]

Thou shalt not push dim patches before passing 'make check'.

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>


Jani Nikula (4):
  dim: Fix shellcheck SC1083
  dim: Fix shellcheck SC2162 and SC2166
  dim: Fix shellcheck SC2153
  dim: Fix shellcheck SC2053

 dim | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[maintainer-tools PATCH 1/4] dim: Fix shellcheck SC1083

[Jani Nikula]

Fixes: 7968b1c836f6 ("dim: Enforce review requirements")
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 dim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dim b/dim
index f576fca0488a..28a137221535 100755
--- a/dim
+++ b/dim
@@ -707,7 +707,7 @@ function dim_push_branch
 
 	committer_email=$(git_committer_email)
 
-	for sha1 in $(git rev-list $branch@{u}..$branch --committer="$committer_email" --no-merges) ; do
+	for sha1 in $(git rev-list "$branch@{u}..$branch" --committer="$committer_email" --no-merges) ; do
 		checkpatch_commit_push $sha1
 	done
 
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[maintainer-tools PATCH 2/4] dim: Fix shellcheck SC2162 and SC2166

[Jani Nikula]

Fixes: 809748225c4e ("dim: Add add-missing-cc command")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 dim | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/dim b/dim
index 28a137221535..070b199c699b 100755
--- a/dim
+++ b/dim
@@ -1959,7 +1959,9 @@ function dim_fixes
 
 function dim_add_missing_cc
 {
-	git show | scripts/get_maintainer.pl --email --norolestats --pattern-depth 1 | while read cc; do
+	local email name matches
+
+	git show | scripts/get_maintainer.pl --email --norolestats --pattern-depth 1 | while read -r cc; do
 		email="$(echo "$cc" | sed -e 's/.*<//' -e 's/>.*//')"
 		name=''
 
@@ -1968,15 +1970,15 @@ function dim_add_missing_cc
 		fi
 
 		# Don't add main mailing lists
-		if [ "$email" = "dri-devel@lists.freedesktop.org" -o \
-		     "$email" = "linux-kernel@vger.kernel.org}" ]; then
+		if [[ "$email" = "dri-devel@lists.freedesktop.org" || \
+		      "$email" = "linux-kernel@vger.kernel.org}" ]]; then
 			continue
 		fi
 
 		# Variables from the while loop don't propagate,
 		# print out a 1 on success
 		matches=$(
-			git show -s | grep -i "^    Cc:" | sed 's/^ *[Cc][Cc]: *//' | while read testcc; do
+			git show -s | grep -i "^    Cc:" | sed 's/^ *[Cc][Cc]: *//' | while read -r testcc; do
 				testemail="$(echo "$testcc" | sed -e 's/.*<//' -e 's/>.*//')"
 
 				if [ "$testemail" != "$email" ]; then
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[maintainer-tools PATCH 3/4] dim: Fix shellcheck SC2153

[Jani Nikula]

The fix is a bit artificial, but mute the warning.

Fixes: 809748225c4e ("dim: Add add-missing-cc command")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 dim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dim b/dim
index 070b199c699b..f614533c5b09 100755
--- a/dim
+++ b/dim
@@ -350,7 +350,7 @@ function git_branch_exists # branch
 function git_committer_email
 {
 	if ! committer_email=$(git config --get user.email) ; then
-		committer_email=$EMAIL
+		committer_email=${EMAIL-}
 	fi
 
 	echo $committer_email
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[maintainer-tools PATCH 4/4] dim: Fix shellcheck SC2053

[Jani Nikula]

Fixes: 3cb0514bf1ca ("dim: add checks for author and committer sign-off-by")
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 dim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dim b/dim
index f614533c5b09..2b377cb3a3f3 100755
--- a/dim
+++ b/dim
@@ -685,7 +685,7 @@ function checkpatch_commit_push
 	fi
 
 	# check for committer != author
-	if [[ $committer  != $author ]]; then
+	if [[ "$committer" != "$author" ]]; then
 		return
 	fi
 
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [maintainer-tools PATCH 0/4] dim: shellcheck fixes

[Daniel Vetter]

On Thu, Aug 10, 2017 at 05:08:12PM +0300, Jani Nikula wrote:
> Thou shalt not push dim patches before passing 'make check'.

On the series:

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> 
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> 
> 
> Jani Nikula (4):
>   dim: Fix shellcheck SC1083
>   dim: Fix shellcheck SC2162 and SC2166
>   dim: Fix shellcheck SC2153
>   dim: Fix shellcheck SC2053
> 
>  dim | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> -- 
> 2.11.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [maintainer-tools PATCH 0/4] dim: shellcheck fixes

[Jani Nikula]

On Fri, 11 Aug 2017, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Aug 10, 2017 at 05:08:12PM +0300, Jani Nikula wrote:
>> Thou shalt not push dim patches before passing 'make check'.
>
> On the series:
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Thanks, pushed.

BR,
Jani.

>
>> 
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
>> 
>> 
>> Jani Nikula (4):
>>   dim: Fix shellcheck SC1083
>>   dim: Fix shellcheck SC2162 and SC2166
>>   dim: Fix shellcheck SC2153
>>   dim: Fix shellcheck SC2053
>> 
>>  dim | 16 +++++++++-------
>>  1 file changed, 9 insertions(+), 7 deletions(-)
>> 
>> -- 
>> 2.11.0
>> 

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx