From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 3/3] drm: handle override edid and firmware EDID at drm_do_get_edid() level Date: Thu, 16 Feb 2017 20:59:13 +0200 Message-ID: <87lgt6dkse.fsf@intel.com> References: <20170216154132.GF31595@intel.com> <87tw7udnt3.fsf@intel.com> <20170216181808.GM31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170216181808.GM31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxNiBGZWIgMjAxNywgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gVGh1LCBGZWIgMTYsIDIwMTcgYXQgMDc6NTQ6MDBQTSAr MDIwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IE9uIFRodSwgMTYgRmViIDIwMTcsIFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+PiA+IE9uIFRo dSwgRmViIDE2LCAyMDE3IGF0IDEyOjM2OjQ1UE0gKzAyMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+ PiA+PiBIYW5kbGUgZGVidWdmcyBvdmVycmlkZSBlZGlkIGFuZCBmaXJtd2FyZSBlZGlkIGF0IHRo ZSBsb3cgbGV2ZWwgdG8KPj4gPj4gdHJhbnNwYXJlbnRseSBhbmQgY29tcGxldGVseSByZXBsYWNl IHRoZSByZWFsIGVkaWQuIFByZXZpb3VzbHksIHdlCj4+ID4+IHByYWN0aWNhbGx5IG9ubHkgdXNl ZCB0aGUgbW9kZXMgZnJvbSB0aGUgb3ZlcnJpZGUgRURJRCwgYW5kIG5vbmUgb2YgdGhlCj4+ID4+ IG90aGVyIGRhdGEuIFRoaXMgYWxzbyBwcmV2ZW50cyBhY3R1YWwgRURJRCByZWFkcyB3aGVuIHRo ZSBFRElEIGlzIHRvIGJlCj4+ID4+IG92ZXJyaWRkZW4sIGJ1dCByZXRhaW5zIHRoZSBEREMgcHJv YmUuCj4+ID4KPj4gPiBIbW0uIElzbid0IHRoYXQgYSBiYWQgdGhpbmc/IElmIHNvbWVvbmUgaGFz IGJyb2tlbiBEREMgb24gdGhlaXIgY2FibGUgb3IKPj4gPiBzb21ldGhpZ24gdGhlbiB0aGUgb3Zl cnJpZGUgRURJRCB3b3VsZG4ndCBiZSByZXR1cm5lZCBieSBkcm1fZ2V0X2VkaWQoKS4KPj4gCj4+ IElzbid0IHRoaXMgaW4gbGluZSB3aXRoIGhvdyB0aGlzIGN1cnJlbnRseSB3b3Jrcz8KPgo+IE5v dCByZWFsbHkuIElmIGNvbm5lY3Rvci0+Zm9yY2UgaXMgdXNlZCBhbmQgYW4gb3ZlcnJpZGUgRURJ RCBpcwo+IHByb3ZpZGVkLCB0aGVuIGRybV9nZXRfZWRpZCgpIGxpa2VseSBuZXZlciBnZXRzIGNh bGxlZCwgYW5kIHRoZSBtb2Rlcwo+IGNvbWUgZGlyZWN0bHkgZnJvbSB0aGUgb3ZlcmlkZSBFRElE LiBXaXRoIHlvdXIgY2hhbmdlIGZvcmNpbmcgdGhlCj4gY29ubmVjdG9yIHN0YXRlIHdvdWxkbid0 IGJlY2F1c2Ugd2Ugc3RpbGwgd291bGRuJ3QgZ2V0IGFueSBtb2Rlcwo+IGZyb20gdGhlIG92ZXJy aWRlIEVESUQgZHVlIHRvIHRoZSBEREMgY2hlY2suCgpSaWdodC4KCj4gSSBndWVzcyBvbmUgd2F5 IGFyb3VuZCB0aGlzIHdvdWxkIGJlIHRvIHNraXAgdGhlIEREQyBjaGVjayBpZiB0aGUKPiBjb25u ZWN0b3Igc3RhdGUgaGFzIGJlZW4gZm9yY2VkLgoKSSBndWVzcyBJJ20gYXNraW5nIGlmIHlvdSB0 aGluayB0aGUgd2hvbGUgYXBwcm9hY2ggaGVyZSBpcwp3b3JrYWJsZS4gV2hhdCB3ZSBjdXJyZW50 bHkgaGF2ZSBpcyBzbyBmbGFreS4KCkJSLApKYW5pLgoKPgo+PiAKPj4gQlIsCj4+IEphbmkuCj4+ IAo+PiAKPj4gPgo+PiA+PiAKPj4gPj4gRklYTUU6IHZhbGlkYXRlIG92ZXJyaWRlIGVkaWQsIGRl ZHVwbGljYXRlIGZpcm13YXJlIGVkaWQgdmFsaWRhdGlvbi4KPj4gPj4gCj4+ID4+IFNpZ25lZC1v ZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4+ID4+IC0tLQo+PiA+ PiAgZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMgICAgICAgICB8IDE1ICsrKysrKysrKysrKysr Kwo+PiA+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYyB8IDE5ICstLS0tLS0t LS0tLS0tLS0tLS0KPj4gPj4gIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTgg ZGVsZXRpb25zKC0pCj4+ID4+IAo+PiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9lZGlkLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+PiA+PiBpbmRleCAzNjIwMzYz NjA3MjQuLjA1NGUyZDc0ZWFmYyAxMDA2NDQKPj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9lZGlkLmMKPj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMKPj4gPj4gQEAg LTEzMDksNiArMTMwOSwxMCBAQCBzdGF0aWMgdm9pZCBjb25uZWN0b3JfYmFkX2VkaWQoc3RydWN0 IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPj4gPj4gICAqIGxldmVsLCBkcml2ZXJzIG11c3Qg bWFrZSBhbGwgcmVhc29uYWJsZSBlZmZvcnRzIHRvIGV4cG9zZSBpdCBhcyBhbiBJMkMKPj4gPj4g ICAqIGFkYXB0ZXIgYW5kIHVzZSBkcm1fZ2V0X2VkaWQoKSBpbnN0ZWFkIG9mIGFidXNpbmcgdGhp cyBmdW5jdGlvbi4KPj4gPj4gICAqCj4+ID4+ICsgKiBUaGUgRURJRCBtYXkgYmUgb3ZlcnJpZGRl biB1c2luZyBkZWJ1Z2ZzIG92ZXJyaWRlX2VkaWQgb3IgZmlybWFyZSBFRElECj4+ID4+ICsgKiAo ZHJtX2xvYWRfZWRpZF9maXJtd2FyZSgpKSwgaW4gdGhpcyBwcmlvcml0eSBvcmRlci4gSGF2aW5n IGVpdGhlciBvZiB0aGVtCj4+ID4+ICsgKiBieXBhc3NlcyBhY3R1YWwgRURJRCByZWFkcy4KPj4g Pj4gKyAqCj4+ID4+ICAgKiBSZXR1cm46IFBvaW50ZXIgdG8gdmFsaWQgRURJRCBvciBOVUxMIGlm IHdlIGNvdWxkbid0IGZpbmQgYW55Lgo+PiA+PiAgICovCj4+ID4+ICBzdHJ1Y3QgZWRpZCAqZHJt X2RvX2dldF9lZGlkKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4+ID4+IEBAIC0x MzE4LDYgKzEzMjIsMTcgQEAgc3RydWN0IGVkaWQgKmRybV9kb19nZXRfZWRpZChzdHJ1Y3QgZHJt X2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+PiA+PiAgewo+PiA+PiAgCWludCBpLCBqID0gMCwgdmFs aWRfZXh0ZW5zaW9ucyA9IDA7Cj4+ID4+ICAJdTggKmVkaWQsICpuZXc7Cj4+ID4+ICsJc3RydWN0 IGVkaWQgKm92ZXJyaWRlID0gTlVMTDsKPj4gPj4gKwo+PiA+PiArCWlmIChjb25uZWN0b3ItPm92 ZXJyaWRlX2VkaWQpCj4+ID4+ICsJCW92ZXJyaWRlID0gZHJtX2VkaWRfZHVwbGljYXRlKChjb25z dCBzdHJ1Y3QgZWRpZCAqKQo+PiA+PiArCQkJCQkgICAgICBjb25uZWN0b3ItPmVkaWRfYmxvYl9w dHItPmRhdGEpOwo+PiA+PiArCj4+ID4+ICsJaWYgKCFvdmVycmlkZSkKPj4gPj4gKwkJb3ZlcnJp ZGUgPSBkcm1fbG9hZF9lZGlkX2Zpcm13YXJlKGNvbm5lY3Rvcik7Cj4+ID4+ICsKPj4gPj4gKwlp ZiAoIUlTX0VSUl9PUl9OVUxMKG92ZXJyaWRlKSkKPj4gPj4gKwkJcmV0dXJuIG92ZXJyaWRlOwo+ PiA+PiAgCj4+ID4+ICAJaWYgKChlZGlkID0ga21hbGxvYyhFRElEX0xFTkdUSCwgR0ZQX0tFUk5F TCkpID09IE5VTEwpCj4+ID4+ICAJCXJldHVybiBOVUxMOwo+PiA+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJv YmVfaGVscGVyLmMKPj4gPj4gaW5kZXggMzU4OTU3MTE4Y2E5Li44NzEzMjZjYmM0NjUgMTAwNjQ0 Cj4+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMKPj4gPj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYwo+PiA+PiBAQCAtMTk5LDggKzE5 OSw2IEBAIGRybV9jb25uZWN0b3JfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0 b3IsIGJvb2wgZm9yY2UpCj4+ID4+ICAgKiAgICBkcm1fbW9kZV9wcm9iZWRfYWRkKCkuIE5ldyBt b2RlcyBzdGFydCB0aGVpciBsaWZlIHdpdGggc3RhdHVzIGFzIE9LLgo+PiA+PiAgICogICAgTW9k ZXMgYXJlIGFkZGVkIGZyb20gYSBzaW5nbGUgc291cmNlIHVzaW5nIHRoZSBmb2xsb3dpbmcgcHJp b3JpdHkgb3JkZXIuCj4+ID4+ICAgKgo+PiA+PiAtICogICAgLSBkZWJ1Z2ZzICdvdmVycmlkZV9l ZGlkJyAodXNlZCBmb3IgdGVzdGluZyBvbmx5KQo+PiA+PiAtICogICAgLSBmaXJtd2FyZSBFRElE IChkcm1fbG9hZF9lZGlkX2Zpcm13YXJlKCkpCj4+ID4+ICAgKiAgICAtICZkcm1fY29ubmVjdG9y X2hlbHBlcl9mdW5jcy5nZXRfbW9kZXMgdmZ1bmMKPj4gPj4gICAqICAgIC0gaWYgdGhlIGNvbm5l Y3RvciBzdGF0dXMgaXMgY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQsIHN0YW5kYXJkCj4+ID4+ ICAgKiAgICAgIFZFU0EgRE1UIG1vZGVzIHVwIHRvIDEwMjR4NzY4IGFyZSBhdXRvbWF0aWNhbGx5 IGFkZGVkCj4+ID4+IEBAIC0zMDUsMjIgKzMwMyw3IEBAIGludCBkcm1faGVscGVyX3Byb2JlX3Np bmdsZV9jb25uZWN0b3JfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPj4g Pj4gIAkJZ290byBwcnVuZTsKPj4gPj4gIAl9Cj4+ID4+ICAKPj4gPj4gLQlpZiAoY29ubmVjdG9y LT5vdmVycmlkZV9lZGlkKSB7Cj4+ID4+IC0JCXN0cnVjdCBlZGlkICplZGlkID0gKHN0cnVjdCBl ZGlkICopIGNvbm5lY3Rvci0+ZWRpZF9ibG9iX3B0ci0+ZGF0YTsKPj4gPj4gLQo+PiA+PiAtCQlj b3VudCA9IGRybV9hZGRfZWRpZF9tb2Rlcyhjb25uZWN0b3IsIGVkaWQpOwo+PiA+PiAtCQlkcm1f ZWRpZF90b19lbGQoY29ubmVjdG9yLCBlZGlkKTsKPj4gPj4gLQl9IGVsc2Ugewo+PiA+PiAtCQlz dHJ1Y3QgZWRpZCAqZWRpZCA9IGRybV9sb2FkX2VkaWRfZmlybXdhcmUoY29ubmVjdG9yKTsKPj4g Pj4gLQkJaWYgKCFJU19FUlJfT1JfTlVMTChlZGlkKSkgewo+PiA+PiAtCQkJZHJtX21vZGVfY29u bmVjdG9yX3VwZGF0ZV9lZGlkX3Byb3BlcnR5KGNvbm5lY3RvciwgZWRpZCk7Cj4+ID4+IC0JCQlj b3VudCA9IGRybV9hZGRfZWRpZF9tb2Rlcyhjb25uZWN0b3IsIGVkaWQpOwo+PiA+PiAtCQkJZHJt X2VkaWRfdG9fZWxkKGNvbm5lY3RvciwgZWRpZCk7Cj4+ID4+IC0JCQlrZnJlZShlZGlkKTsKPj4g Pj4gLQkJfQo+PiA+PiAtCQlpZiAoY291bnQgPT0gMCkKPj4gPj4gLQkJCWNvdW50ID0gKCpjb25u ZWN0b3JfZnVuY3MtPmdldF9tb2RlcykoY29ubmVjdG9yKTsKPj4gPj4gLQl9Cj4+ID4+ICsJY291 bnQgPSAoKmNvbm5lY3Rvcl9mdW5jcy0+Z2V0X21vZGVzKShjb25uZWN0b3IpOwo+PiA+PiAgCj4+ ID4+ICAJaWYgKGNvdW50ID09IDAgJiYgY29ubmVjdG9yLT5zdGF0dXMgPT0gY29ubmVjdG9yX3N0 YXR1c19jb25uZWN0ZWQpCj4+ID4+ICAJCWNvdW50ID0gZHJtX2FkZF9tb2Rlc19ub2VkaWQoY29u bmVjdG9yLCAxMDI0LCA3NjgpOwo+PiA+PiAtLSAKPj4gPj4gMi4xLjQKPj4gCj4+IC0tIAo+PiBK YW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKCi0tIApKYW5p IE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==