public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Mark the end of intel_ring_begin() and check in intel_ring_advance()
Date: Tue, 07 Feb 2017 13:02:29 +0200	[thread overview]
Message-ID: <87lgtis1q2.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20170206204443.GQ12434@nuc-i3427.alporthouse.com>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> On Mon, Feb 06, 2017 at 07:52:15PM -0000, Patchwork wrote:
>> == Series Details ==
>> 
>> Series: series starting with [CI,1/2] drm/i915: Mark the end of intel_ring_begin() and check in intel_ring_advance()
>> URL   : https://patchwork.freedesktop.org/series/19169/
>> State : success
>> 
>> == Summary ==
>> 
>> Series 19169v1 Series without cover letter
>> https://patchwork.freedesktop.org/api/1.0/series/19169/revisions/1/mbox/
>> 
>> Test kms_force_connector_basic:
>>         Subgroup force-connector-state:
>>                 skip       -> PASS       (fi-snb-2520m)
>
> Ok, I pushed this as given Mika's feedback this may be responsible for
> skl (at least) sporadically dieing in CI. I'm sure the macros for the
> conditional code I added can and will be improved.

Observations with my kbl indicate that the retirement freed the request's
context, which then got referenced by the GEM_BUG_ON. Instead of neat
trace, full system hang ensued.

With this patch, my kbl seems very stable again.

I suspect that atleast some incomplete CI results we have seen,
on execlist machines, were due to this.

-Mika

> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2017-02-07 11:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 17:05 [CI 1/2] drm/i915: Mark the end of intel_ring_begin() and check in intel_ring_advance() Chris Wilson
2017-02-06 17:05 ` [CI 2/2] drm/i915: Avoid unguarded reads from the request pointer Chris Wilson
2017-02-06 19:52 ` ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Mark the end of intel_ring_begin() and check in intel_ring_advance() Patchwork
2017-02-06 20:44   ` Chris Wilson
2017-02-07 11:02     ` Mika Kuoppala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgtis1q2.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox