From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH v2 2/2] drm/i915: fix intel_prepare_ddi
Date: Thu, 30 Apr 2015 12:37:28 +0300
Message-ID: <87lhha9ctj.fsf@intel.com>
References: <1429271890-7949-1-git-send-email-imre.deak@intel.com>
 <1429288282-7162-2-git-send-email-imre.deak@intel.com>
 <20150427172950.GC3503@strange.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 07CD06E0D2
 for <intel-gfx@lists.freedesktop.org>; Thu, 30 Apr 2015 02:35:29 -0700 (PDT)
In-Reply-To: <20150427172950.GC3503@strange.ger.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>, Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org, paulo.r.zanoni@intel.com
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAyNyBBcHIgMjAxNSwgRGFtaWVuIExlc3BpYXUgPGRhbWllbi5sZXNwaWF1QGludGVs
LmNvbT4gd3JvdGU6Cj4gT24gRnJpLCBBcHIgMTcsIDIwMTUgYXQgMDc6MzE6MjJQTSArMDMwMCwg
SW1yZSBEZWFrIHdyb3RlOgo+PiBBdCB0aGUgbW9tZW50IGludGVsX3ByZXBhcmVfZGRpIGJ1ZmZl
ciB3aWxsIGl0ZXJhdGUgdGhyb3VnaCBib3RoIE1TVCBhbmQKPj4gQ1JUIGVuY29kZXJzLCB3aGlj
aCBpcyBpbmNvcnJlY3QuIE5laXRoZXIgb2YgdGhlc2UgZW5jb2RlciB0eXBlcyBoYXZlIGFuCj4+
IGVtYmVkZGluZyBpbnRlbF9kaWdpdGFsX3BvcnQgb2JqZWN0LCBzbyBmb3IgdGhlc2UgZW5jb2Rl
ciB0eXBlcyB3ZSB3aWxsCj4+IHVzZSByYW5kb20gZGF0YSB3aGVuIGRlcmVmZXJlbmNpbmcgdGhl
IGNvcnJlc3BvbmRpbmcKPj4gaW50ZWxfZGlnaXRhbF9wb3J0LT5wb3J0IGZpZWxkLgo+PiAKPj4g
SW50cm9kdWNlZCBpbgo+PiBjb21taXQgYjQwMzc0NWM4NDU5MmIyNmEwNzEzZTY5NDRjMmIxMDlm
NmRmNWM4Mgo+PiBBdXRob3I6IERhbWllbiBMZXNwaWF1IDxkYW1pZW4ubGVzcGlhdUBpbnRlbC5j
b20+Cj4+IERhdGU6ICAgTW9uIEF1ZyA0IDIyOjAxOjMzIDIwMTQgKzAxMDAKPj4gCj4+ICAgICBk
cm0vaTkxNTogSXRlcmF0ZSB0aHJvdWdoIHRoZSBpbml0aWFsaXplZCBERElzIHRvIHByZXBhcmUg
dGhlaXIgYnVmZmVycwo+PiAKPj4gdjI6Cj4+IC0gZml4IGdldHRpbmcgYXQgdGhlIHBvcnQgZm9y
IE1TVCBlbmNvZGVycyB0b28KPj4gLSBtYWtlIHN1cmUgdGhhdCBpbnRlbF9wcmVwYXJlX2RkaV9i
dWZmZXJzKCkgZ2V0cyBjYWxsZWQgZm9yIHBvcnQgRSB0b28KPj4gICAoUGF1bG8pCj4+IAo+PiBT
aWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4KPiBSZXZpZXdl
ZC1ieTogRGFtaWVuIExlc3BpYXUgPGRhbWllbi5sZXNwaWF1QGludGVsLmNvbT4KCkJvdGggcHVz
aGVkIHRvIGRybS1pbnRlbC1uZXh0LXF1ZXVlZCwgd2l0aCB0aGUgQnVnemlsbGE6IHRhZyBtb3Zl
ZCB0bwoyLzIgd2hpY2ggYWN0dWFsbHkgZml4ZXMgdGhlIGJ1Zy4gVGhhbmtzIGZvciB0aGUgcGF0
Y2hlcyBhbmQgcmV2aWV3LgoKQlIsCkphbmkuCgoKPgo+IC0tIAo+IERhbWllbgo+Cj4+IC0tLQo+
PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgfCAgNSAtLS0tLQo+PiAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgfCAyOCArKysrKysrKysrKysrKysrKystLS0tLS0t
LS0tCj4+ICAyIGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygt
KQo+PiAKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IGluZGV4IDQwZWY2NzIuLmM0NjFiNTYg
MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiBAQCAtMjUxLDExICsyNTEsNiBAQCBl
bnVtIGhwZF9waW4gewo+PiAgCQkJICAgICZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rvcl9saXN0
LAlcCj4+ICAJCQkgICAgYmFzZS5oZWFkKQo+PiAgCj4+IC0jZGVmaW5lIGZvcl9lYWNoX2RpZ2l0
YWxfcG9ydChkZXYsIGRpZ2l0YWxfcG9ydCkJCVwKPj4gLQlsaXN0X2Zvcl9lYWNoX2VudHJ5KGRp
Z2l0YWxfcG9ydCwJCQlcCj4+IC0JCQkgICAgJmRldi0+bW9kZV9jb25maWcuZW5jb2Rlcl9saXN0
LAlcCj4+IC0JCQkgICAgYmFzZS5iYXNlLmhlYWQpCj4+IC0KPj4gICNkZWZpbmUgZm9yX2VhY2hf
ZW5jb2Rlcl9vbl9jcnRjKGRldiwgX19jcnRjLCBpbnRlbF9lbmNvZGVyKSBcCj4+ICAJbGlzdF9m
b3JfZWFjaF9lbnRyeSgoaW50ZWxfZW5jb2RlciksICYoZGV2KS0+bW9kZV9jb25maWcuZW5jb2Rl
cl9saXN0LCBiYXNlLmhlYWQpIFwKPj4gIAkJaWYgKChpbnRlbF9lbmNvZGVyKS0+YmFzZS5jcnRj
ID09IChfX2NydGMpKQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZGRpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+PiBpbmRleCA5MDNkMzk1
Li45YzFlNzRhIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGku
Ywo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+PiBAQCAtMjU2LDEy
ICsyNTYsMTEgQEAgaW50ZWxfZGlnX3BvcnRfc3VwcG9ydHNfaGRtaShjb25zdCBzdHJ1Y3QgaW50
ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCkKPj4gICAqIGluIGVpdGhlciBGREkgb3Ig
RFAgbW9kZXMgb25seSwgYXMgSERNSSBjb25uZWN0aW9ucyB3aWxsIHdvcmsgd2l0aCBib3RoCj4+
ICAgKiBvZiB0aG9zZQo+PiAgICovCj4+IC1zdGF0aWMgdm9pZCBpbnRlbF9wcmVwYXJlX2RkaV9i
dWZmZXJzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+IC0JCQkJICAgICAgc3RydWN0IGludGVs
X2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQpCj4+ICtzdGF0aWMgdm9pZCBpbnRlbF9wcmVw
YXJlX2RkaV9idWZmZXJzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGVudW0gcG9ydCBwb3J0LAo+
PiArCQkJCSAgICAgIGJvb2wgc3VwcG9ydHNfaGRtaSkKPj4gIHsKPj4gIAlzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+PiAgCXUzMiByZWc7Cj4+
IC0JaW50IHBvcnQgPSBpbnRlbF9kaWdfcG9ydC0+cG9ydDsKPj4gIAlpbnQgaSwgbl9oZG1pX2Vu
dHJpZXMsIG5fZHBfZW50cmllcywgbl9lZHBfZW50cmllcywgaGRtaV9kZWZhdWx0X2VudHJ5LAo+
PiAgCSAgICBzaXplOwo+PiAgCWludCBoZG1pX2xldmVsID0gZGV2X3ByaXYtPnZidC5kZGlfcG9y
dF9pbmZvW3BvcnRdLmhkbWlfbGV2ZWxfc2hpZnQ7Cj4+IEBAIC0yNzIsNyArMjcxLDcgQEAgc3Rh
dGljIHZvaWQgaW50ZWxfcHJlcGFyZV9kZGlfYnVmZmVycyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2
LAo+PiAgCWNvbnN0IHN0cnVjdCBkZGlfYnVmX3RyYW5zICpkZGlfdHJhbnNsYXRpb25zOwo+PiAg
Cj4+ICAJaWYgKElTX0JST1hUT04oZGV2KSkgewo+PiAtCQlpZiAoIWludGVsX2RpZ19wb3J0X3N1
cHBvcnRzX2hkbWkoaW50ZWxfZGlnX3BvcnQpKQo+PiArCQlpZiAoIXN1cHBvcnRzX2hkbWkpCj4+
ICAJCQlyZXR1cm47Cj4+ICAKPj4gIAkJLyogVnN3aW5nIHByb2dyYW1taW5nIGZvciBIRE1JICov
Cj4+IEBAIC0zNjAsNyArMzU5LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHJlcGFyZV9kZGlfYnVm
ZmVycyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAgCQlyZWcgKz0gNDsKPj4gIAl9Cj4+ICAK
Pj4gLQlpZiAoIWludGVsX2RpZ19wb3J0X3N1cHBvcnRzX2hkbWkoaW50ZWxfZGlnX3BvcnQpKQo+
PiArCWlmICghc3VwcG9ydHNfaGRtaSkKPj4gIAkJcmV0dXJuOwo+PiAgCj4+ICAJLyogQ2hvb3Nl
IGEgZ29vZCBkZWZhdWx0IGlmIFZCVCBpcyBiYWRseSBwb3B1bGF0ZWQgKi8KPj4gQEAgLTM4MCwx
OCArMzc5LDI3IEBAIHN0YXRpYyB2b2lkIGludGVsX3ByZXBhcmVfZGRpX2J1ZmZlcnMoc3RydWN0
IGRybV9kZXZpY2UgKmRldiwKPj4gICAqLwo+PiAgdm9pZCBpbnRlbF9wcmVwYXJlX2RkaShzdHJ1
Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgewo+PiAtCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQg
KmludGVsX2RpZ19wb3J0Owo+PiArCXN0cnVjdCBpbnRlbF9lbmNvZGVyICppbnRlbF9lbmNvZGVy
Owo+PiAgCWJvb2wgdmlzaXRlZFtJOTE1X01BWF9QT1JUU10gPSB7IDAsIH07Cj4+ICAKPj4gIAlp
ZiAoIUhBU19EREkoZGV2KSkKPj4gIAkJcmV0dXJuOwo+PiAgCj4+IC0JZm9yX2VhY2hfZGlnaXRh
bF9wb3J0KGRldiwgaW50ZWxfZGlnX3BvcnQpIHsKPj4gLQkJaWYgKHZpc2l0ZWRbaW50ZWxfZGln
X3BvcnQtPnBvcnRdKQo+PiArCWZvcl9lYWNoX2ludGVsX2VuY29kZXIoZGV2LCBpbnRlbF9lbmNv
ZGVyKSB7Cj4+ICsJCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0Owo+
PiArCQllbnVtIHBvcnQgcG9ydDsKPj4gKwkJYm9vbCBzdXBwb3J0c19oZG1pOwo+PiArCj4+ICsJ
CWRkaV9nZXRfZW5jb2Rlcl9wb3J0KGludGVsX2VuY29kZXIsICZpbnRlbF9kaWdfcG9ydCwgJnBv
cnQpOwo+PiArCj4+ICsJCWlmICh2aXNpdGVkW3BvcnRdKQo+PiAgCQkJY29udGludWU7Cj4+ICAK
Pj4gLQkJaW50ZWxfcHJlcGFyZV9kZGlfYnVmZmVycyhkZXYsIGludGVsX2RpZ19wb3J0KTsKPj4g
LQkJdmlzaXRlZFtpbnRlbF9kaWdfcG9ydC0+cG9ydF0gPSB0cnVlOwo+PiArCQlzdXBwb3J0c19o
ZG1pID0gaW50ZWxfZGlnX3BvcnQgJiYKPj4gKwkJCQlpbnRlbF9kaWdfcG9ydF9zdXBwb3J0c19o
ZG1pKGludGVsX2RpZ19wb3J0KTsKPj4gKwo+PiArCQlpbnRlbF9wcmVwYXJlX2RkaV9idWZmZXJz
KGRldiwgcG9ydCwgc3VwcG9ydHNfaGRtaSk7Cj4+ICsJCXZpc2l0ZWRbcG9ydF0gPSB0cnVlOwo+
PiAgCX0KPj4gIH0KPj4gIAo+PiAtLSAKPj4gMi4xLjAKPj4gCj4gX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4g
SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv
cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwg
T3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz
dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9pbnRlbC1nZngK