From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"François Tigeot" <ftigeot@wolfpond.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: logical-not-parenthesis gcc 5.0 fixes
Date: Mon, 23 Feb 2015 11:25:33 +0200 [thread overview]
Message-ID: <87lhjpq8s2.fsf@intel.com> (raw)
In-Reply-To: <20150222220423.GA22852@nuc-i3427.alporthouse.com>
On Mon, 23 Feb 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Sun, Feb 22, 2015 at 08:10:11PM +0100, François Tigeot wrote:
>> * Originally added by John Marino in DragonFly's eecf6c3c3b6f7127edd8b8f8c2a83e2f882ed0da
>> commit.
...
>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> index 3b0fe9f..91264b2 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -13299,7 +13299,7 @@ intel_check_plane_mapping(struct intel_crtc *crtc)
>> val = I915_READ(reg);
>>
>> if ((val & DISPLAY_PLANE_ENABLE) &&
>> - (!!(val & DISPPLANE_SEL_PIPE_MASK) == crtc->pipe))
>> + (!!( (val & DISPPLANE_SEL_PIPE_MASK) == crtc->pipe) ))
>
> That's wrong.
Indeed; this has introduced a bug in DragonFly. Not that I care, but so
you know.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-23 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 19:10 [PATCH] drm/i915: logical-not-parenthesis gcc 5.0 fixes François Tigeot
2015-02-22 22:04 ` Chris Wilson
2015-02-23 9:25 ` Jani Nikula [this message]
2015-02-23 13:52 ` Dave Gordon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhjpq8s2.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=ftigeot@wolfpond.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox