From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 6/6] drm/i915: Remove most INVALID_PIPE checks from VLV backlight code Date: Fri, 07 Nov 2014 14:24:46 +0200 Message-ID: <87lhnn19m9.fsf@intel.com> References: <1415351764-3514-1-git-send-email-ville.syrjala@linux.intel.com> <1415351764-3514-7-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 124616E438 for ; Fri, 7 Nov 2014 04:24:52 -0800 (PST) In-Reply-To: <1415351764-3514-7-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAwNyBOb3YgMjAxNCwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pgo+IE5vdyB0aGF0IHRoZSBiYWNrbGlnaHQgZGV2aWNlIG5vIGxvbmdlciBnZXRzIHJlZ2lzdGVy ZWQgdG9vIGVhcmx5IHdlCj4gc2hvdWxkIGJlIGFibGUgdG8gZHJvcCBtb3N0IG9mIHRoZSBJTlZB TElEX1BJUEUgY2hlY2tzIGZvcm0gdGhlIFZMVi9DSFYKPiBiYWNrbGlnaHQgY29kZS4KClRoZSBz dWJqZWN0IGFuZCB0aGlzIHBhcmFncmFwaCByZWZlciB0byBWTFYvQ0hWIGJ1dCB0aGlzIGlzbid0 IHJlYWxseQpzcGVjaWZpYyB0byB0aG9zZSBwbGF0Zm9ybXMuCgo+IElmIHdlIHN0aWxsIG1hbmFn ZSB0byBnZXQgaGVyZSB3aXRoIElOVkFMSURfUElQRSB3ZSB3aWxsIG5vdyBnZXQgYSBXQVJOCj4g ZnJvbSB0aGUgbG93ZXIgbGV2ZWwgZnVuY3Rpb25zIGFuZCBjYW4gdGhlbiBhY3R1YWxseSBpbnZl c3RpZ2F0ZSBmdXJ0aGVyLgo+Cj4gdmx2X2dldF9iYWNrbGlnaHQoKSBzdGlsbCBuZWVkcyB0aGUg Y2hlY2sgc2luY2UgdGhhdCBnZXRzIGNhbGxlZCBpbgo+IHJlc3BvbnNlIHRvIHVzZXJzcGFjZSBh Y3R1YWxfYnJpZ2h0bmVzcyByZWFkcy4KCklJVUMgdGhpcyBiaXQgd29uJ3QgYmUgdHJ1ZSBpZiB5 b3UgYWRkIHRoZSBiYWNrbGlnaHQuZW5hYmxlZCBjaGVjayBhcyBJCnN1Z2dlc3RlZCBlYXJsaWVy LgoKPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMg fCAxMSArKysrLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA3IGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bh bmVsLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4gaW5kZXggMmJjMzMw OS4uMGUyY2IxMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5l bC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+IEBAIC02MzQs MTAgKzYzNCw5IEBAIHN0YXRpYyB2b2lkIGludGVsX3BhbmVsX3NldF9iYWNrbGlnaHQoc3RydWN0 IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9 IGNvbm5lY3Rvci0+YmFzZS5kZXY7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICAJc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCA9ICZj b25uZWN0b3ItPnBhbmVsOwo+IC0JZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9nZXRfcGlwZV9mcm9t X2Nvbm5lY3Rvcihjb25uZWN0b3IpOwo+ICAJdTMyIGh3X2xldmVsOwo+ICAKPiAtCWlmICghcGFu ZWwtPmJhY2tsaWdodC5wcmVzZW50IHx8IHBpcGUgPT0gSU5WQUxJRF9QSVBFKQo+ICsJaWYgKCFw YW5lbC0+YmFja2xpZ2h0LnByZXNlbnQpCj4gIAkJcmV0dXJuOwo+ICAKPiAgCW11dGV4X2xvY2so JmRldl9wcml2LT5iYWNrbGlnaHRfbG9jayk7Cj4gQEAgLTY2MiwxMCArNjYxLDkgQEAgdm9pZCBp bnRlbF9wYW5lbF9zZXRfYmFja2xpZ2h0X2FjcGkoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29u bmVjdG9yLAo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNvbm5lY3Rvci0+YmFzZS5kZXY7 Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRl Owo+ICAJc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCA9ICZjb25uZWN0b3ItPnBhbmVsOwo+IC0J ZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9nZXRfcGlwZV9mcm9tX2Nvbm5lY3Rvcihjb25uZWN0b3Ip Owo+ICAJdTMyIGh3X2xldmVsOwo+ICAKPiAtCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50 IHx8IHBpcGUgPT0gSU5WQUxJRF9QSVBFKQo+ICsJaWYgKCFwYW5lbC0+YmFja2xpZ2h0LnByZXNl bnQpCj4gIAkJcmV0dXJuOwoKSSBoYXZlIGEgZmVlbGluZyB3ZSBtYXkgZ2V0IHRoZXNlIHJlcXVl c3RzIGZyb20gdGhlIEJJT1Mgd2hlbmV2ZXIuIEluCnRoZW9yeSB3ZSBzaG91bGQgdXNlIHRoZSBv cHJlZ2lvbiBBUkRZIGZpZWxkIG9yIHNvbWVzdWNoIHRvIGNvbW11bmljYXRlCndoZXRoZXIgd2Un cmUgcmVhZHkgb3Igbm90ICh3ZSBhbHdheXMgc2F5IHdlJ3JlIHJlYWR5IGxpa2UgYSBzY291dCkg YnV0CmV2ZW4gc28gd2UgY2FuJ3QgdHJ1c3QgdGhlIEJJT1MgdG8gbGlzdGVuIHRvIHdoYXQgd2Ug c2F5LiBMb25nIHN0b3J5CnNob3J0IHdlIHNob3VsZCBwcm9iYWJseSBsZWF2ZSB0aGlzIGNoZWNr IGluLgoKV2l0aCB0aG9zZSBmaXhlZCB0aGlzIExHVE0uCgpCUiwKSmFuaS4KCgo+ICAKPiAgCW11 dGV4X2xvY2soJmRldl9wcml2LT5iYWNrbGlnaHRfbG9jayk7Cj4gQEAgLTc0MCw5ICs3MzgsOCBA QCB2b2lkIGludGVsX3BhbmVsX2Rpc2FibGVfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0 b3IgKmNvbm5lY3RvcikKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjb25uZWN0b3ItPmJh c2UuZGV2Owo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZf cHJpdmF0ZTsKPiAgCXN0cnVjdCBpbnRlbF9wYW5lbCAqcGFuZWwgPSAmY29ubmVjdG9yLT5wYW5l bDsKPiAtCWVudW0gcGlwZSBwaXBlID0gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3IoY29u bmVjdG9yKTsKPiAgCj4gLQlpZiAoIXBhbmVsLT5iYWNrbGlnaHQucHJlc2VudCB8fCBwaXBlID09 IElOVkFMSURfUElQRSkKPiArCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50KQo+ICAJCXJl dHVybjsKPiAgCj4gIAkvKgo+IEBAIC05NDksNyArOTQ2LDcgQEAgdm9pZCBpbnRlbF9wYW5lbF9l bmFibGVfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgCXN0 cnVjdCBpbnRlbF9wYW5lbCAqcGFuZWwgPSAmY29ubmVjdG9yLT5wYW5lbDsKPiAgCWVudW0gcGlw ZSBwaXBlID0gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3IoY29ubmVjdG9yKTsKPiAgCj4g LQlpZiAoIXBhbmVsLT5iYWNrbGlnaHQucHJlc2VudCB8fCBwaXBlID09IElOVkFMSURfUElQRSkK PiArCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50KQo+ICAJCXJldHVybjsKPiAgCj4gIAlE Uk1fREVCVUdfS01TKCJwaXBlICVjXG4iLCBwaXBlX25hbWUocGlwZSkpOwo+IC0tIAo+IDIuMC40 Cj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IElu dGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoK LS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=