Re: [PATCH] [v2] drm/i915/vma: Correct use after free in eviction

Chris Wilson
2013-08-16T22:31:20Z

On Fri, Aug 16, 2013 at 01:29:33PM -0700, Ben Widawsky wrote:
> The vma will [possibly] be destroyed during unbind in eviction.
> Immediately after this, we try to delete the list entry.
>
> Chris and Ville did the debug on this before I woke up, I just get to
> take credit for the fix :p
>
> v2: Missed the drm_object_unreference use after free (Ville)
>
> Reported-by: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Should have spotted this earlier :(

Can I have a couple more lines of whitespace?
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre