From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19D69C76188 for ; Wed, 5 Apr 2023 11:41:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6CDB410E8F2; Wed, 5 Apr 2023 11:41:00 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 57E3810E8F2 for ; Wed, 5 Apr 2023 11:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680694857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FMtfoXjFIQVrdCvOYQIUXDgwaN1CMspVz9VQYCn9+jg=; b=a5mTOogrOG01oqhA9XIsdrx7nwivuH3a9UIsiGdCVERDTKDYEBb6h9bSejSLiPKC84Yl3B zZiFphlBu7u3AGm2rm2Hn89iUFLA8vsvhtGwmG3X8aOMLJpqWItDhrC5iEyYdeSfK6G7RW WoD1ndmVRmlyG062bY4wVPfb0+mgYlo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-DgTbOkpSNgy0i9gZzbNDCg-1; Wed, 05 Apr 2023 07:40:56 -0400 X-MC-Unique: DgTbOkpSNgy0i9gZzbNDCg-1 Received: by mail-wm1-f70.google.com with SMTP id n3-20020a05600c3b8300b003f048e0e09eso1027239wms.1 for ; Wed, 05 Apr 2023 04:40:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680694853; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FMtfoXjFIQVrdCvOYQIUXDgwaN1CMspVz9VQYCn9+jg=; b=mqlShQrFWqnOo5uwnWb3lolEuJZmuw++t428zjhHb48asu7jcOArqD2HqcdXuh0Nu7 xq4QytS63o1zenZ7jbT7S5DgHAOOZnRNrRu7X8aS8OjQZHmr+Ent5nGLLnskaVajOajt hhEbtsSbgbj++taan1erMjeWqrCu3b1ZILsuNaG2qn4YHWtuW5u+AsF1+2I/Q71lYh7O GiM4ivzJ/TZazbtek2ULGOx1k3pYL7iZu00/sWd4PnUN/LYZfcdZp7hItMZm0G+qLbiR RCIDst69sYxIq4ocOqMR3TXEfEOXxTRYfHEgs1nlWEvCAKdPt3Lz+pS2s+YQJ2H71FNJ 0xQg== X-Gm-Message-State: AAQBX9f5sXYyLLD3VEuybAvJXtAv93Xn2SAZYQM5+wB7DIfvz2TUf3mb OkIH1UKhtDnTof0QUKWzPx3GSC4K877L4Y/94dooXv0zs09tEUpitNDlRR1auibrG7KKyy3WlLH ZSrmJ8N6F3l3to00vaY7wGG2jTwDN X-Received: by 2002:a5d:5145:0:b0:2d4:e666:cab4 with SMTP id u5-20020a5d5145000000b002d4e666cab4mr3875076wrt.30.1680694853766; Wed, 05 Apr 2023 04:40:53 -0700 (PDT) X-Google-Smtp-Source: AKy350YRI/C35exI7PaTkklaXJEKQwXJQOY29/Mn3ZPywaIUFNmaLxIzI36isEe9GLJeCe7pAxVLeA== X-Received: by 2002:a5d:5145:0:b0:2d4:e666:cab4 with SMTP id u5-20020a5d5145000000b002d4e666cab4mr3875063wrt.30.1680694853484; Wed, 05 Apr 2023 04:40:53 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id g22-20020a7bc4d6000000b003ed1f111fdesm1916150wmk.20.2023.04.05.04.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 04:40:53 -0700 (PDT) From: Javier Martinez Canillas To: Daniel Vetter , DRI Development In-Reply-To: <20230404201842.567344-8-daniel.vetter@ffwll.ch> References: <20230404201842.567344-1-daniel.vetter@ffwll.ch> <20230404201842.567344-8-daniel.vetter@ffwll.ch> Date: Wed, 05 Apr 2023 13:40:47 +0200 Message-ID: <87mt3mblq8.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 8/8] fbdev: Simplify fb_is_primary_device for x86 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Daniel Vetter , Daniel Vetter , Intel Graphics Development , Dave Hansen , Ingo Molnar , Borislav Petkov , Thomas Zimmermann , "H. Peter Anvin" , Daniel Vetter , Thomas Gleixner , Helge Deller Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Daniel Vetter writes: > vga_default_device really is supposed to cover all corners, at least > for x86. Additionally checking for rom shadowing should be redundant, > because the bios/fw only does that for the boot vga device. > > If this turns out to be wrong, then most likely that's a special case > which should be added to the vgaarb code, not replicated all over. > > Patch motived by changes to the aperture helpers, which also have this > open code in a bunch of places, and which are all removed in a > clean-up series. This function here is just for selecting the default > fbdev device for fbcon, but I figured for consistency it might be good > to throw this patch in on top. > > Note that the shadow rom check predates vgaarb, which was only wired > up in 88674088d10c ("x86: Use vga_default_device() when determining > whether an fb is primary"). That patch doesn't explain why we still > fall back to the shadow rom check. > > Signed-off-by: Daniel Vetter > Cc: Daniel Vetter > Cc: Helge Deller > Cc: Daniel Vetter > Cc: Javier Martinez Canillas > Cc: Thomas Zimmermann > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > --- > arch/x86/video/fbdev.c | 13 +------------ [...] > + if (pci_dev == vga_default_device()) > return 1; > return 0; or just return pci_dev == vga_default_device() ; Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat