From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CA98C4332F for ; Tue, 18 Oct 2022 10:39:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7289910E5ED; Tue, 18 Oct 2022 10:39:57 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB69A10E7BA for ; Tue, 18 Oct 2022 10:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666089590; x=1697625590; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=lzXb7AHTO48IZ3S+XyWFsLcfa2guUZPB+Oqhyo+jfTk=; b=iaF/aoK/gMY62pzjjHTUZgQNZ6kZUWvd7U2Fgbhr0cYAC9PEf/4Y/A/R +VC2Nbg0mTJuD8OQ0Q7mfKYyAMCAa+nW72cql5+MQ1LA1uEBKXEwCOkHi E/6QIL/1CsIOQ2c1cSad/iwR8GgeqdWOJnu5Hbcsd/xfJkAWE5IFYQuXb GQcReb4EFkEY7W0xJRvB7OA8HokdnCP/Nk3sKkt/3BZ00KQ7MaxJDlhcS O+v7ngH87Smjhl3Gq4LAjlCaYxIzzQPsfHhdZIml025+Vm0GRrL18lkxi pzVWR/3pG49M2FR8+WVjVpbrN639fPRCvdbHRaCQIoKN77AECQWhCjuuk Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="368094575" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="368094575" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 03:39:49 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="691743959" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="691743959" Received: from ineznano-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.44.87]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 03:39:46 -0700 From: Jani Nikula To: "Kahola, Mika" , "intel-gfx@lists.freedesktop.org" In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220929131747.2592092-1-mika.kahola@intel.com> <20220929131747.2592092-4-mika.kahola@intel.com> <87k05lw6lq.fsf@intel.com> Date: Tue, 18 Oct 2022 13:39:44 +0300 Message-ID: <87mt9tiff3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 3/5] drm/i915/mtl: Add support for C10 phy programming X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 14 Oct 2022, "Kahola, Mika" wrote: > Maybe these could be moved into intel_cx0_reg_defs.h file? Register definitions to intel_cx0_regs.h. See $ find drivers/gpu/drm/i915/ -name "*_regs.h" Any common helpers such as REG_FIELD_GET8() and friends to i915_reg_defs.h where we already have some other sized helpers. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center