From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31CB8ECAAA3 for ; Fri, 26 Aug 2022 07:41:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DE32110E6DD; Fri, 26 Aug 2022 07:41:38 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95BF610E6DD; Fri, 26 Aug 2022 07:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661499693; x=1693035693; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=4a+mq/UD4p7syg3FmT8VtB/pV7z7yScjTYhENi1QEF4=; b=R/giv+cGwWNeguvduEk7CE81SDDKmJwV/GSbJb5ApCEkB5WHH6YC3uwa ijeMuWwkrXbQzlav+70kqh8xYG7zxcQihYVBBh6Dinu+j1qwz/9jKDPXu HxRoaDODqMawg0Lf8LBcxLUIralz5wASwDiuV+McInWeH6gYP0c1uEPjO w88crV5IAvzruMHMUbmCICgtbbfyPzbM+RU0w3tMiJCQ8C7c18cWHAg8E 9vJc/2UBtjMUK2LPnT3fFmtvyhL0W6JTD6cbHHCgmF+/USVo1kGBbf2Ax BEkTg2I+t2VG0Fbky69smq3zQFRZL3gKri4+ShcsFUuDxhsw7W7OrxuBN Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10450"; a="274200532" X-IronPort-AV: E=Sophos;i="5.93,264,1654585200"; d="scan'208";a="274200532" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2022 00:41:31 -0700 X-IronPort-AV: E=Sophos;i="5.93,264,1654585200"; d="scan'208";a="671361734" Received: from plomuzio-mobl.ger.corp.intel.com (HELO localhost) ([10.252.40.203]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2022 00:41:28 -0700 From: Jani Nikula To: Joonas Lahtinen , Intel graphics driver community testing & development In-Reply-To: <20220826072438.147598-1-joonas.lahtinen@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220826072438.147598-1-joonas.lahtinen@linux.intel.com> Date: Fri, 26 Aug 2022 10:41:23 +0300 Message-ID: <87mtbrh2os.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Remove log size module parameters X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alan Previn , Direct Rendering Infrastructure - Development , Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 26 Aug 2022, Joonas Lahtinen wrote: > Remove the module parameters for configuring GuC log size. > > We should instead rely on tuning the defaults to be usable for > reporting bugs. Reviewed-by: Jani Nikula > > Fixes: 8ad0152afb1b ("drm/i915/guc: Make GuC log sizes runtime configurable") > Signed-off-by: Joonas Lahtinen > Cc: Jani Nikula > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: John Harrison > Cc: Alan Previn > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 7 +++---- > drivers/gpu/drm/i915/i915_params.c | 12 ------------ > drivers/gpu/drm/i915/i915_params.h | 3 --- > 3 files changed, 3 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > index 3a2243b4ac9f..909e5079657b 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > @@ -79,9 +79,9 @@ static void _guc_log_init_sizes(struct intel_guc_log *log) > } > }; > s32 params[GUC_LOG_SECTIONS_LIMIT] = { > - i915->params.guc_log_size_crash, > - i915->params.guc_log_size_debug, > - i915->params.guc_log_size_capture, > + GUC_LOG_DEFAULT_CRASH_BUFFER_SIZE, > + GUC_LOG_DEFAULT_DEBUG_BUFFER_SIZE, > + GUC_LOG_DEFAULT_CAPTURE_BUFFER_SIZE, > }; > int i; > > @@ -90,7 +90,6 @@ static void _guc_log_init_sizes(struct intel_guc_log *log) > > /* If debug size > 1MB then bump default crash size to keep the same units */ > if (log->sizes[GUC_LOG_SECTIONS_DEBUG].bytes >= SZ_1M && > - (i915->params.guc_log_size_crash == -1) && > GUC_LOG_DEFAULT_CRASH_BUFFER_SIZE < SZ_1M) > log->sizes[GUC_LOG_SECTIONS_CRASH].bytes = SZ_1M; > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 06ca5b822111..6fc475a5db61 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -171,18 +171,6 @@ i915_param_named(guc_log_level, int, 0400, > "GuC firmware logging level. Requires GuC to be loaded. " > "(-1=auto [default], 0=disable, 1..4=enable with verbosity min..max)"); > > -i915_param_named(guc_log_size_crash, int, 0400, > - "GuC firmware logging buffer size for crash dumps (in MB)" > - "(-1=auto [default], NB: max = 4, other restrictions apply)"); > - > -i915_param_named(guc_log_size_debug, int, 0400, > - "GuC firmware logging buffer size for debug logs (in MB)" > - "(-1=auto [default], NB: max = 16, other restrictions apply)"); > - > -i915_param_named(guc_log_size_capture, int, 0400, > - "GuC error capture register dump buffer size (in MB)" > - "(-1=auto [default], NB: max = 4, other restrictions apply)"); > - > i915_param_named_unsafe(guc_firmware_path, charp, 0400, > "GuC firmware path to use instead of the default one"); > > diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h > index f684d1ab8707..2733cb6cfe09 100644 > --- a/drivers/gpu/drm/i915/i915_params.h > +++ b/drivers/gpu/drm/i915/i915_params.h > @@ -61,9 +61,6 @@ struct drm_printer; > param(int, invert_brightness, 0, 0600) \ > param(int, enable_guc, -1, 0400) \ > param(int, guc_log_level, -1, 0400) \ > - param(int, guc_log_size_crash, -1, 0400) \ > - param(int, guc_log_size_debug, -1, 0400) \ > - param(int, guc_log_size_capture, -1, 0400) \ > param(char *, guc_firmware_path, NULL, 0400) \ > param(char *, huc_firmware_path, NULL, 0400) \ > param(char *, dmc_firmware_path, NULL, 0400) \ -- Jani Nikula, Intel Open Source Graphics Center