From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E0DEC433EF for ; Mon, 18 Oct 2021 08:25:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C640E603E7 for ; Mon, 18 Oct 2021 08:25:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C640E603E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6CE8F6E096; Mon, 18 Oct 2021 08:25:08 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 850DF6E096 for ; Mon, 18 Oct 2021 08:25:06 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10140"; a="251652935" X-IronPort-AV: E=Sophos;i="5.85,381,1624345200"; d="scan'208";a="251652935" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 01:25:05 -0700 X-IronPort-AV: E=Sophos;i="5.85,381,1624345200"; d="scan'208";a="482633977" Received: from foboril-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.44.188]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 01:25:03 -0700 From: Jani Nikula To: Rodrigo Vivi , intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi , Joonas Lahtinen In-Reply-To: <20211015091650.87270-1-rodrigo.vivi@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211015091650.87270-1-rodrigo.vivi@intel.com> Date: Mon, 18 Oct 2021 11:25:00 +0300 Message-ID: <87mtn6u4df.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915: Don't propagate the gen split confusion further X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 15 Oct 2021, Rodrigo Vivi wrote: > There's no such thing as gen13. It is either display 13 > or graphics 13. Don't propagate the gen12 confusion > further. Reviewed-by: Jani Nikula > > Cc: Joonas Lahtinen > Cc: Jani Nikula > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index da9055c3ebf0..1e221fbe37fd 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -8263,7 +8263,7 @@ enum { > > /* > * The below are numbered starting from "S1" on gen11/gen12, but starting > - * with gen13 display, the bspec switches to a 0-based numbering scheme > + * with display 13, the bspec switches to a 0-based numbering scheme > * (although the addresses stay the same so new S0 = old S1, new S1 = old S2). > * We'll just use the 0-based numbering here for all platforms since it's the > * way things will be named by the hardware team going forward, plus it's more -- Jani Nikula, Intel Open Source Graphics Center