From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A06BCC4338F for ; Tue, 10 Aug 2021 11:51:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64A6260E09 for ; Tue, 10 Aug 2021 11:51:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 64A6260E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AB0D89E0D; Tue, 10 Aug 2021 11:51:41 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE18489E0C; Tue, 10 Aug 2021 11:51:39 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="214871368" X-IronPort-AV: E=Sophos;i="5.84,310,1620716400"; d="scan'208";a="214871368" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 04:51:38 -0700 X-IronPort-AV: E=Sophos;i="5.84,310,1620716400"; d="scan'208";a="515767016" Received: from aktiwary-mobl3.amr.corp.intel.com (HELO localhost) ([10.249.40.8]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 04:51:34 -0700 From: Jani Nikula To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Matthew Auld , Maarten Lankhorst In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210810084128.17242-1-jani.nikula@intel.com> Date: Tue, 10 Aug 2021 14:51:30 +0300 Message-ID: <87mtppo6v1.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem/ttm: prefer kernel types X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 10 Aug 2021, Daniel Vetter wrote: > On Tue, Aug 10, 2021 at 11:41:28AM +0300, Jani Nikula wrote: >> Avoid uintXX_t types in the driver. >>=20 >> Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object back= end") >> Cc: Thomas Hellstr=C3=B6m >> Cc: Matthew Auld >> Cc: Maarten Lankhorst >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i= 915/gem/i915_gem_ttm.c >> index 771eb2963123..ffda88156e32 100644 >> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c >> @@ -168,7 +168,7 @@ i915_ttm_placement_from_obj(const struct drm_i915_ge= m_object *obj, >> } >>=20=20 >> static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo, >> - uint32_t page_flags) >> + u32 page_flags) > > It's for the ttm_device_funcs ops table, I thinhk we should fix it there > and across the board? > > Otherwise a bit ocd mismatch :-) Well, the above is the only uintXX_t reference in i915. BR, Jani. > -Daniel > >> { >> struct ttm_resource_manager *man =3D >> ttm_manager_type(bo->bdev, bo->resource->mem_type); >> --=20 >> 2.20.1 >>=20 --=20 Jani Nikula, Intel Open Source Graphics Center