From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6360CC35257 for ; Wed, 16 Sep 2020 07:43:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 007C22078D for ; Wed, 16 Sep 2020 07:43:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 007C22078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F9CB6E9CF; Wed, 16 Sep 2020 07:43:39 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id A22FB6E9CB; Wed, 16 Sep 2020 07:43:37 +0000 (UTC) IronPort-SDR: +MTtykf2saFNZ2Fd+pfIVkzWfudYHvqawwjXDwYokjtLEDFw3C3OobFXnqIbm+tz7kpvySx0nd a04SmcCvA2FA== X-IronPort-AV: E=McAfee;i="6000,8403,9745"; a="139430565" X-IronPort-AV: E=Sophos;i="5.76,432,1592895600"; d="scan'208";a="139430565" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 00:43:36 -0700 IronPort-SDR: OZ7tMty0VP/hRXfVXL0x4qgPXpQXMNVgdmQghv9OU0GOtBg6LdI4ZajhNrKK03UbRAXfRCzuQ8 uyjHu6wOhSvw== X-IronPort-AV: E=Sophos;i="5.76,432,1592895600"; d="scan'208";a="483196147" Received: from djgriffi-mobl.ger.corp.intel.com (HELO localhost) ([10.252.8.217]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 00:43:30 -0700 From: Jani Nikula To: Rodrigo Vivi , Lyude Paul In-Reply-To: <20200915190639.GC503362@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200915172939.2810538-1-lyude@redhat.com> <20200915172939.2810538-2-lyude@redhat.com> <20200915190639.GC503362@intel.com> Date: Wed, 16 Sep 2020 10:43:35 +0300 Message-ID: <87mu1qw4ig.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [RFC 1/5] drm/i915/dp: Program source OUI on eDP panels X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, open list , dri-devel@lists.freedesktop.org, Vasily Khoruzhick , Sean Paul , Wambui Karuga Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 15 Sep 2020, Rodrigo Vivi wrote: > On Tue, Sep 15, 2020 at 01:29:35PM -0400, Lyude Paul wrote: >> Since we're about to start adding support for Intel's magic HDR >> backlight interface over DPCD, we need to ensure we're properly >> programming this field so that Intel specific sink services are exposed. >> Otherwise, 0x300-0x3ff will just read zeroes. >> >> We also take care not to reprogram the source OUI if it already matches >> what we expect. This is just to be careful so that we don't accidentally >> take the panel out of any backlight control modes we found it in. (For whatever reason I didn't receive the original message.) >> >> Signed-off-by: Lyude Paul >> Cc: thaytan@noraisin.net >> Cc: Vasily Khoruzhick >> --- >> drivers/gpu/drm/i915/display/intel_dp.c | 32 +++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c >> index 4bd10456ad188..b591672ec4eab 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp.c >> @@ -3428,6 +3428,7 @@ void intel_dp_sink_set_decompression_state(struct intel_dp *intel_dp, >> void intel_dp_sink_dpms(struct intel_dp *intel_dp, int mode) >> { >> struct drm_i915_private *i915 = dp_to_i915(intel_dp); >> + u8 edp_oui[] = { 0x00, 0xaa, 0x01 }; > > what are these values? An OUI lookup confirms these are Intel OUI. > >> int ret, i; >> >> /* Should have a valid DPCD by this point */ >> @@ -3443,6 +3444,14 @@ void intel_dp_sink_dpms(struct intel_dp *intel_dp, int mode) >> } else { >> struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp); >> >> + /* Write the source OUI as early as possible */ >> + if (intel_dp_is_edp(intel_dp)) { >> + ret = drm_dp_dpcd_write(&intel_dp->aux, DP_SOURCE_OUI, edp_oui, >> + sizeof(edp_oui)); >> + if (ret < 0) >> + drm_err(&i915->drm, "Failed to write eDP source OUI\n"); >> + } >> + >> /* >> * When turning on, we need to retry for 1ms to give the sink >> * time to wake up. >> @@ -4530,6 +4539,23 @@ static void intel_dp_get_dsc_sink_cap(struct intel_dp *intel_dp) >> } >> } >> >> +static void >> +intel_edp_init_source_oui(struct intel_dp *intel_dp) >> +{ >> + struct drm_i915_private *i915 = dp_to_i915(intel_dp); >> + u8 oui[] = { 0x00, 0xaa, 0x01 }; >> + u8 buf[3] = { 0 }; >> + >> + if (drm_dp_dpcd_read(&intel_dp->aux, DP_SOURCE_OUI, buf, sizeof(buf)) < 0) >> + drm_err(&i915->drm, "Failed to read source OUI\n"); >> + >> + if (memcmp(oui, buf, sizeof(oui)) == 0) >> + return; >> + >> + if (drm_dp_dpcd_write(&intel_dp->aux, DP_SOURCE_OUI, oui, sizeof(oui)) < 0) >> + drm_err(&i915->drm, "Failed to write source OUI\n"); >> +} Maybe add this function with a parameter to force write or write only if necessary, and call from both places that set source OUI? >> + >> static bool >> intel_edp_init_dpcd(struct intel_dp *intel_dp) >> { >> @@ -4607,6 +4633,12 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp) >> if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) >> intel_dp_get_dsc_sink_cap(intel_dp); >> >> + /* >> + * Program our source OUI so we can make various Intel-specific AUX >> + * services available (such as HDR backlight controls) >> + */ >> + intel_edp_init_source_oui(intel_dp); > > I believe we should restrict this to the supported platforms: cfl, whl, cml, icl, tgl > no? Mmh, this just exposes sink behaviour that I think can be supported by any platform. I don't understand the notion of "supported platforms" here. > >> + >> return true; >> } >> >> -- >> 2.26.2 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx