From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEDCDC4BA06 for ; Thu, 27 Feb 2020 08:29:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FE63222C2 for ; Thu, 27 Feb 2020 08:29:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FE63222C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 356206EC45; Thu, 27 Feb 2020 08:29:46 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 936A86EC3A; Thu, 27 Feb 2020 08:29:44 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 00:29:41 -0800 X-IronPort-AV: E=Sophos;i="5.70,491,1574150400"; d="scan'208";a="231747674" Received: from lohmeies-mobl.ger.corp.intel.com (HELO localhost) ([10.252.50.249]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 00:29:29 -0800 From: Jani Nikula To: "Laxminarayan Bharadiya\, Pankaj" , Chris Wilson In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200225134709.6153-1-pankaj.laxminarayan.bharadiya@intel.com> <20200225134709.6153-2-pankaj.laxminarayan.bharadiya@intel.com> <158263931977.26598.171017617509031302@skylake-alporthouse-com> Date: Thu, 27 Feb 2020 10:29:50 +0200 Message-ID: <87mu94qvpd.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 01/10] drm/i915: Add i915 device based MISSING_CASE macro X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 27 Feb 2020, "Laxminarayan Bharadiya, Pankaj" wrote: > Hi Chris, > >> -----Original Message----- >> From: Chris Wilson >> Sent: 25 February 2020 19:32 >> To: David Airlie ; Joonas Lahtinen >> ; Laxminarayan Bharadiya, Pankaj >> ; Vivi, Rodrigo >> ; daniel@ffwll.ch; dri-devel@lists.freedesktop.org; >> intel-gfx@lists.freedesktop.org; jani.nikula@linux.intel.com >> Cc: Laxminarayan Bharadiya, Pankaj >> >> Subject: Re: [Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based >> MISSING_CASE macro >> >> Quoting Pankaj Bharadiya (2020-02-25 13:47:00) >> > Now that we have struct drm_device based drm_WARN, introduce struct >> > drm_i915_private based i915_MISSING_CASE macro which uses >> drm_WARN so >> > that device specific information will also get printed in backtrace. >> > >> > i915_MISSING_CASE macro should be preferred over MISSING_CASE, >> > wherever possible. >> >> Whatever for? MISSING_CASE() itself should be a complete picture for the >> forgotten code. > > Are you saying, no need to have a new device specific macro? > > We want convert all the calls of WARN* with device specific drm_WARN* > in i915, hence I introduced new i915_MISSING_CASE macro. > > Jani, Will you please share your opinion on this? In general, many or most WARNs are device specific, and the device information is useful. However MISSING_CASE is about the *code*. That was the intent anyway. Perhaps there are cases where the device information might be useful, but for most cases probably not. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx