Re: [PATCH v1 0/2] drm: drop uapi dependencies from include/drm

From: Jani Nikula <jani.nikula@linux.intel.com>
To: Emil Velikov <emil.l.velikov@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	David Airlie <airlied@linux.ie>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v1 0/2] drm: drop uapi dependencies from include/drm
Date: Mon, 24 Jun 2019 13:55:35 +0300	[thread overview]
Message-ID: <87mui7s15k.fsf@intel.com> (raw)
In-Reply-To: <CACvgo53j8XEiTO3+g_692GkcvzHAViMzhh_ZuK+-6W4kHm0pgw@mail.gmail.com>

On Mon, 24 Jun 2019, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> On Mon, 24 Jun 2019 at 09:21, Daniel Vetter <daniel@ffwll.ch> wrote:
>
>> > drm_legacy.h
>> > - needs drm_map_type and drm_map_flags. Seems legit.
>>
>> enum in uapi, sweet (never do this, it's not portable across compilers,
>> #defines all the way).
>
> Don't look too closely then
> $ git grep enum -- include/uapi/drm/ | wc -l
> 96
>
> A handful of those are legacy stuff, yet quite a few are not :-\

Enums are just fine for *values* as long as they're not used as types in
struct members or function parameters or return types, right?

So we do have some we've screwed up, but it's not nearly as bad as the
git grep above would lead you to believe.

The ones in question are used in struct drm_map which is used in
DRM_IOCTL_GET_MAP, DRM_IOCTL_ADD_MAP, and DRM_IOCTL_RM_MAP.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx