From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/8] drm/i915: Stop retiring along engine Date: Fri, 14 Jun 2019 17:23:15 +0300 Message-ID: <87muik8cvg.fsf@gaia.fi.intel.com> References: <20190612093111.11684-1-chris@chris-wilson.co.uk> <20190612093111.11684-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26A458993B for ; Fri, 14 Jun 2019 14:23:19 +0000 (UTC) In-Reply-To: <20190612093111.11684-3-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gV2Ugbm8g bG9uZ2VyIHRyYWNrIHRoZSBleGVjdXRpb24gb3JkZXIgYWxvbmcgdGhlIGVuZ2luZSBhbmQgc28g bm8gbG9uZ2VyCj4gbmVlZCB0byBlbmZvcmNlIG9yZGVyaW5nIG9mIHJldGlyZSBhbG9uZyB0aGUg ZW5naW5lLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jIHwg MTI4ICsrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUyIGlu c2VydGlvbnMoKyksIDc2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1 ZXN0LmMKPiBpbmRleCA5ZWZmOWRlN2ZhMTAuLjljNThhZTZlNGFmYiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfcmVxdWVzdC5jCj4gQEAgLTE4Myw3MiArMTgzLDIzIEBAIHN0YXRpYyB2b2lk IGZyZWVfY2FwdHVyZV9saXN0KHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJlcXVlc3QpCj4gIAl9Cj4g IH0KPiAgCj4gLXN0YXRpYyB2b2lkIF9fcmV0aXJlX2VuZ2luZV9yZXF1ZXN0KHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAtCQkJCSAgICBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSkK PiAtewo+IC0JR0VNX1RSQUNFKCIlcyglcykgZmVuY2UgJWxseDolbGxkLCBjdXJyZW50ICVkXG4i LAo+IC0JCSAgX19mdW5jX18sIGVuZ2luZS0+bmFtZSwKPiAtCQkgIHJxLT5mZW5jZS5jb250ZXh0 LCBycS0+ZmVuY2Uuc2Vxbm8sCj4gLQkJICBod3NwX3NlcW5vKHJxKSk7Cj4gLQo+IC0JR0VNX0JV R19PTighaTkxNV9yZXF1ZXN0X2NvbXBsZXRlZChycSkpOwo+IC0KPiAtCWxvY2FsX2lycV9kaXNh YmxlKCk7Cj4gLQo+IC0Jc3Bpbl9sb2NrKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2spOwo+IC0JR0VN X0JVR19PTighbGlzdF9pc19maXJzdCgmcnEtPmxpbmssICZlbmdpbmUtPnRpbWVsaW5lLnJlcXVl c3RzKSk7Cj4gLQlsaXN0X2RlbF9pbml0KCZycS0+bGluayk7Cj4gLQlzcGluX3VubG9jaygmZW5n aW5lLT50aW1lbGluZS5sb2NrKTsKPiAtCj4gLQlzcGluX2xvY2soJnJxLT5sb2NrKTsKPiAtCWk5 MTVfcmVxdWVzdF9tYXJrX2NvbXBsZXRlKHJxKTsKPiAtCWlmICghaTkxNV9yZXF1ZXN0X3NpZ25h bGVkKHJxKSkKPiAtCQlkbWFfZmVuY2Vfc2lnbmFsX2xvY2tlZCgmcnEtPmZlbmNlKTsKPiAtCWlm ICh0ZXN0X2JpdChETUFfRkVOQ0VfRkxBR19FTkFCTEVfU0lHTkFMX0JJVCwgJnJxLT5mZW5jZS5m bGFncykpCj4gLQkJaTkxNV9yZXF1ZXN0X2NhbmNlbF9icmVhZGNydW1iKHJxKTsKPiAtCWlmIChy cS0+d2FpdGJvb3N0KSB7Cj4gLQkJR0VNX0JVR19PTighYXRvbWljX3JlYWQoJnJxLT5pOTE1LT5n dF9wbS5ycHMubnVtX3dhaXRlcnMpKTsKPiAtCQlhdG9taWNfZGVjKCZycS0+aTkxNS0+Z3RfcG0u cnBzLm51bV93YWl0ZXJzKTsKPiAtCX0KPiAtCXNwaW5fdW5sb2NrKCZycS0+bG9jayk7Cj4gLQo+ IC0JbG9jYWxfaXJxX2VuYWJsZSgpOwo+IC19Cj4gLQo+IC1zdGF0aWMgdm9pZCBfX3JldGlyZV9l bmdpbmVfdXB0byhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gLQkJCQkgc3RydWN0 IGk5MTVfcmVxdWVzdCAqcnEpCj4gLXsKPiAtCXN0cnVjdCBpOTE1X3JlcXVlc3QgKnRtcDsKPiAt Cj4gLQlpZiAobGlzdF9lbXB0eSgmcnEtPmxpbmspKQo+IC0JCXJldHVybjsKPiAtCj4gLQlkbyB7 Cj4gLQkJdG1wID0gbGlzdF9maXJzdF9lbnRyeSgmZW5naW5lLT50aW1lbGluZS5yZXF1ZXN0cywK PiAtCQkJCSAgICAgICB0eXBlb2YoKnRtcCksIGxpbmspOwo+IC0KPiAtCQlHRU1fQlVHX09OKHRt cC0+ZW5naW5lICE9IGVuZ2luZSk7Cj4gLQkJX19yZXRpcmVfZW5naW5lX3JlcXVlc3QoZW5naW5l LCB0bXApOwo+IC0JfSB3aGlsZSAodG1wICE9IHJxKTsKPiAtfQo+IC0KPiAtc3RhdGljIHZvaWQg aTkxNV9yZXF1ZXN0X3JldGlyZShzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICtzdGF0 aWMgYm9vbCBpOTE1X3JlcXVlc3RfcmV0aXJlKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxKQo+ICB7 Cj4gIAlzdHJ1Y3QgaTkxNV9hY3RpdmVfcmVxdWVzdCAqYWN0aXZlLCAqbmV4dDsKPiAgCj4gLQlH RU1fVFJBQ0UoIiVzIGZlbmNlICVsbHg6JWxsZCwgY3VycmVudCAlZFxuIiwKPiAtCQkgIHJlcXVl c3QtPmVuZ2luZS0+bmFtZSwKPiAtCQkgIHJlcXVlc3QtPmZlbmNlLmNvbnRleHQsIHJlcXVlc3Qt PmZlbmNlLnNlcW5vLAo+IC0JCSAgaHdzcF9zZXFubyhyZXF1ZXN0KSk7Cj4gKwlsb2NrZGVwX2Fz c2VydF9oZWxkKCZycS0+aTkxNS0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4gKwlpZiAoIWk5MTVfcmVx dWVzdF9jb21wbGV0ZWQocnEpKQo+ICsJCXJldHVybiBmYWxzZTsKPiAgCj4gLQlsb2NrZGVwX2Fz c2VydF9oZWxkKCZyZXF1ZXN0LT5pOTE1LT5kcm0uc3RydWN0X211dGV4KTsKPiAtCUdFTV9CVUdf T04oIWk5MTVfc3dfZmVuY2Vfc2lnbmFsZWQoJnJlcXVlc3QtPnN1Ym1pdCkpOwo+IC0JR0VNX0JV R19PTighaTkxNV9yZXF1ZXN0X2NvbXBsZXRlZChyZXF1ZXN0KSk7Cj4gKwlHRU1fVFJBQ0UoIiVz IGZlbmNlICVsbHg6JWxsZCwgY3VycmVudCAlZFxuIiwKPiArCQkgIHJxLT5lbmdpbmUtPm5hbWUs Cj4gKwkJICBycS0+ZmVuY2UuY29udGV4dCwgcnEtPmZlbmNlLnNlcW5vLAo+ICsJCSAgaHdzcF9z ZXFubyhycSkpOwo+ICAKPiAtCXRyYWNlX2k5MTVfcmVxdWVzdF9yZXRpcmUocmVxdWVzdCk7Cj4g KwlHRU1fQlVHX09OKCFpOTE1X3N3X2ZlbmNlX3NpZ25hbGVkKCZycS0+c3VibWl0KSk7Cj4gKwl0 cmFjZV9pOTE1X3JlcXVlc3RfcmV0aXJlKHJxKTsKPiAgCj4gLQlhZHZhbmNlX3JpbmcocmVxdWVz dCk7Cj4gLQlmcmVlX2NhcHR1cmVfbGlzdChyZXF1ZXN0KTsKPiArCWFkdmFuY2VfcmluZyhycSk7 Cj4gIAo+ICAJLyoKPiAgCSAqIFdhbGsgdGhyb3VnaCB0aGUgYWN0aXZlIGxpc3QsIGNhbGxpbmcg cmV0aXJlIG9uIGVhY2guIFRoaXMgYWxsb3dzCj4gQEAgLTI2MCw3ICsyMTEsNyBAQCBzdGF0aWMg dm9pZCBpOTE1X3JlcXVlc3RfcmV0aXJlKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJlcXVlc3QpCj4g IAkgKiBwYXNzIGFsb25nIHRoZSBhdXhpbGlhcnkgaW5mb3JtYXRpb24gKHRvIGF2b2lkIGRlcmVm ZXJlbmNpbmcKPiAgCSAqIHRoZSBub2RlIGFmdGVyIHRoZSBjYWxsYmFjaykuCj4gIAkgKi8KPiAt CWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShhY3RpdmUsIG5leHQsICZyZXF1ZXN0LT5hY3RpdmVf bGlzdCwgbGluaykgewo+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKGFjdGl2ZSwgbmV4dCwg JnJxLT5hY3RpdmVfbGlzdCwgbGluaykgewo+ICAJCS8qCj4gIAkJICogSW4gbWljcm9iZW5jaG1h cmtzIG9yIGZvY3VzaW5nIHVwb24gdGltZSBpbnNpZGUgdGhlIGtlcm5lbCwKPiAgCQkgKiB3ZSBt YXkgc3BlbmQgYW4gaW5vcmRpbmF0ZSBhbW91bnQgb2YgdGltZSBzaW1wbHkgaGFuZGxpbmcKPiBA QCAtMjc2LDE4ICsyMjcsMzkgQEAgc3RhdGljIHZvaWQgaTkxNV9yZXF1ZXN0X3JldGlyZShzdHJ1 Y3QgaTkxNV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICAJCUlOSVRfTElTVF9IRUFEKCZhY3RpdmUtPmxp bmspOwo+ICAJCVJDVV9JTklUX1BPSU5URVIoYWN0aXZlLT5yZXF1ZXN0LCBOVUxMKTsKPiAgCj4g LQkJYWN0aXZlLT5yZXRpcmUoYWN0aXZlLCByZXF1ZXN0KTsKPiArCQlhY3RpdmUtPnJldGlyZShh Y3RpdmUsIHJxKTsKPiArCX0KPiArCj4gKwlsb2NhbF9pcnFfZGlzYWJsZSgpOwo+ICsKPiArCXNw aW5fbG9jaygmcnEtPmVuZ2luZS0+dGltZWxpbmUubG9jayk7Cj4gKwlsaXN0X2RlbCgmcnEtPmxp bmspOwo+ICsJc3Bpbl91bmxvY2soJnJxLT5lbmdpbmUtPnRpbWVsaW5lLmxvY2spOwo+ICsKPiAr CXNwaW5fbG9jaygmcnEtPmxvY2spOwo+ICsJaTkxNV9yZXF1ZXN0X21hcmtfY29tcGxldGUocnEp Owo+ICsJaWYgKCFpOTE1X3JlcXVlc3Rfc2lnbmFsZWQocnEpKQo+ICsJCWRtYV9mZW5jZV9zaWdu YWxfbG9ja2VkKCZycS0+ZmVuY2UpOwo+ICsJaWYgKHRlc3RfYml0KERNQV9GRU5DRV9GTEFHX0VO QUJMRV9TSUdOQUxfQklULCAmcnEtPmZlbmNlLmZsYWdzKSkKPiArCQlpOTE1X3JlcXVlc3RfY2Fu Y2VsX2JyZWFkY3J1bWIocnEpOwo+ICsJaWYgKHJxLT53YWl0Ym9vc3QpIHsKPiArCQlHRU1fQlVH X09OKCFhdG9taWNfcmVhZCgmcnEtPmk5MTUtPmd0X3BtLnJwcy5udW1fd2FpdGVycykpOwo+ICsJ CWF0b21pY19kZWMoJnJxLT5pOTE1LT5ndF9wbS5ycHMubnVtX3dhaXRlcnMpOwo+ICAJfQo+ICsJ c3Bpbl91bmxvY2soJnJxLT5sb2NrKTsKPiArCj4gKwlsb2NhbF9pcnFfZW5hYmxlKCk7Cj4gIAo+ IC0JaTkxNV9yZXF1ZXN0X3JlbW92ZV9mcm9tX2NsaWVudChyZXF1ZXN0KTsKPiArCWludGVsX2Nv bnRleHRfZXhpdChycS0+aHdfY29udGV4dCk7Cj4gKwlpbnRlbF9jb250ZXh0X3VucGluKHJxLT5o d19jb250ZXh0KTsKPiAgCj4gLQlfX3JldGlyZV9lbmdpbmVfdXB0byhyZXF1ZXN0LT5lbmdpbmUs IHJlcXVlc3QpOwo+ICsJaTkxNV9yZXF1ZXN0X3JlbW92ZV9mcm9tX2NsaWVudChycSk7Cj4gIAo+ IC0JaW50ZWxfY29udGV4dF9leGl0KHJlcXVlc3QtPmh3X2NvbnRleHQpOwo+IC0JaW50ZWxfY29u dGV4dF91bnBpbihyZXF1ZXN0LT5od19jb250ZXh0KTsKPiArCWZyZWVfY2FwdHVyZV9saXN0KHJx KTsKPiArCWk5MTVfc2NoZWRfbm9kZV9maW5pKCZycS0+c2NoZWQpOwo+ICsJaTkxNV9yZXF1ZXN0 X3B1dChycSk7Cj4gIAo+IC0JaTkxNV9zY2hlZF9ub2RlX2ZpbmkoJnJlcXVlc3QtPnNjaGVkKTsK PiAtCWk5MTVfcmVxdWVzdF9wdXQocmVxdWVzdCk7Cj4gKwlyZXR1cm4gdHJ1ZTsKPiAgfQo+ICAK PiAgdm9pZCBpOTE1X3JlcXVlc3RfcmV0aXJlX3VwdG8oc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEp Cj4gQEAgLTMwOSw5ICsyODEsNyBAQCB2b2lkIGk5MTVfcmVxdWVzdF9yZXRpcmVfdXB0byhzdHJ1 Y3QgaTkxNV9yZXF1ZXN0ICpycSkKPiAgCWRvIHsKPiAgCQl0bXAgPSBsaXN0X2ZpcnN0X2VudHJ5 KCZyaW5nLT5yZXF1ZXN0X2xpc3QsCj4gIAkJCQkgICAgICAgdHlwZW9mKCp0bXApLCByaW5nX2xp bmspOwo+IC0KPiAtCQlpOTE1X3JlcXVlc3RfcmV0aXJlKHRtcCk7Cj4gLQl9IHdoaWxlICh0bXAg IT0gcnEpOwo+ICsJfSB3aGlsZSAoaTkxNV9yZXF1ZXN0X3JldGlyZSh0bXApICYmIHRtcCAhPSBy cSk7CgpUaGUgc2VtYW50aWNzIGRvZXMgY2hhbmdlIGEgbGl0dGxlIGZvciB0aGlzIGZ1bmN0aW9u LiBCdXQKbG9va2luZyBhdCB0aGUgY2FsbHNpdGVzIGl0IGRvZXNuJ3QgbWF0dGVyLgoKPiAgfQo+ ICAKPiAgc3RhdGljIHZvaWQgaXJxX2V4ZWN1dGVfY2Ioc3RydWN0IGlycV93b3JrICp3cmspCj4g QEAgLTYwMCwxMiArNTcwLDkgQEAgc3RhdGljIHZvaWQgcmluZ19yZXRpcmVfcmVxdWVzdHMoc3Ry dWN0IGludGVsX3JpbmcgKnJpbmcpCj4gIHsKPiAgCXN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLCAq cm47Cj4gIAo+IC0JbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKHJxLCBybiwgJnJpbmctPnJlcXVl c3RfbGlzdCwgcmluZ19saW5rKSB7Cj4gLQkJaWYgKCFpOTE1X3JlcXVlc3RfY29tcGxldGVkKHJx KSkKPiArCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShycSwgcm4sICZyaW5nLT5yZXF1ZXN0X2xp c3QsIHJpbmdfbGluaykKPiArCQlpZiAoIWk5MTVfcmVxdWVzdF9yZXRpcmUocnEpKQo+ICAJCQli cmVhazsKPiAtCj4gLQkJaTkxNV9yZXF1ZXN0X3JldGlyZShycSk7Cj4gLQl9Cj4gIH0KPiAgCj4g IHN0YXRpYyBub2lubGluZSBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICoKPiBAQCAtNjIwLDYgKzU4Nywx NSBAQCByZXF1ZXN0X2FsbG9jX3Nsb3coc3RydWN0IGludGVsX2NvbnRleHQgKmNlLCBnZnBfdCBn ZnApCj4gIAlpZiAoIWdmcGZsYWdzX2FsbG93X2Jsb2NraW5nKGdmcCkpCj4gIAkJZ290byBvdXQ7 Cj4gIAo+ICsJLyogTW92ZSBvdXIgb2xkZXN0IHJlcXVlc3QgdG8gdGhlIHNsYWItY2FjaGUgKGlm IG5vdCBpbiB1c2UhKSAqLwo+ICsJcnEgPSBsaXN0X2ZpcnN0X2VudHJ5KCZyaW5nLT5yZXF1ZXN0 X2xpc3QsIHR5cGVvZigqcnEpLCByaW5nX2xpbmspOwo+ICsJaTkxNV9yZXF1ZXN0X3JldGlyZShy cSk7CgpPayB0aGlzIGlzIGp1c3QgZm9yIGtpY2suCgo+ICsKPiArCXJxID0ga21lbV9jYWNoZV9h bGxvYyhnbG9iYWwuc2xhYl9yZXF1ZXN0cywKPiArCQkJICAgICAgZ2ZwIHwgX19HRlBfUkVUUllf TUFZRkFJTCB8IF9fR0ZQX05PV0FSTik7CgpPbmx5IG9uZSBjYWxsc2l0ZSBmb3IgdGhpcyBzbyB5 b3UgZ28gY2xlYW5lciBieSB1c2luZyBnZnAgb25seSBpZgp5b3Ugc28gZGVzaXJlLgoKUmV2aWV3 ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgoKPiAr CWlmIChycSkKPiArCQlyZXR1cm4gcnE7Cj4gKwo+ICAJLyogUmF0ZWxpbWl0IG91cnNlbHZlcyB0 byBwcmV2ZW50IG9vbSBmcm9tIG1hbGljaW91cyBjbGllbnRzICovCj4gIAlycSA9IGxpc3RfbGFz dF9lbnRyeSgmcmluZy0+cmVxdWVzdF9saXN0LCB0eXBlb2YoKnJxKSwgcmluZ19saW5rKTsKPiAg CWNvbmRfc3luY2hyb25pemVfcmN1KHJxLT5yY3VzdGF0ZSk7Cj4gLS0gCj4gMi4yMC4xCj4KPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdm eCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4