From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [RFC 1/3] drm/i915/icl: Restructure ICL DPLL enable
 functionality
Date: Wed, 03 Oct 2018 11:00:51 +0300
Message-ID: <87murvqx1o.fsf@intel.com>
References: <1536908054-2176-1-git-send-email-vandita.kulkarni@intel.com>
 <1536908054-2176-2-git-send-email-vandita.kulkarni@intel.com>
 <20180914160655.GJ5565@intel.com> <87pnwrqxbg.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 3693B6E3F0
 for <intel-gfx@lists.freedesktop.org>; Wed,  3 Oct 2018 08:00:58 +0000 (UTC)
In-Reply-To: <87pnwrqxbg.fsf@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>, Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: intel-gfx@lists.freedesktop.org, paulo.r.zanoni@intel.com
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCAwMyBPY3QgMjAxOCwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g
d3JvdGU6Cj4gT24gRnJpLCAxNCBTZXAgMjAxOCwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq
YWxhQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4+IE9uIEZyaSwgU2VwIDE0LCAyMDE4IGF0IDEy
OjI0OjEyUE0gKzA1MzAsIFZhbmRpdGEgS3Vsa2Fybmkgd3JvdGU6Cj4+PiBGcm9tOiBNYWRoYXYg
Q2hhdWhhbiA8bWFkaGF2LmNoYXVoYW5AaW50ZWwuY29tPgo+Pj4gCj4+PiBJbiBHZW4xMSwgRFBM
TCAwIGFuZCAxIGFyZSBzaGFyZWQgYmV0d2VlbiBEREkgYW5kIERTSS4KPj4+IE1vc3Qgb2YgdGhl
IHN0ZXBzIGZvciBlbmFibGluZyBEUExMIGFyZSBjb21tb24gYWNyb3NzIERESQo+Pj4gYW5kIERT
SS4gVGhpcyBwYXRjaCBtYWtlcyBpY2xfZHBsbF9lbmFibGUoKSBnZW5lcmljIHdoaWNoCj4+PiB3
aWxsIGJlIHVzZWQgYnkgYWxsIHRoZSBlbmNvZGVycy4KPj4+IAo+Pj4gU2lnbmVkLW9mZi1ieTog
TWFkaGF2IENoYXVoYW4gPG1hZGhhdi5jaGF1aGFuQGludGVsLmNvbT4KPj4+IFNpZ25lZC1vZmYt
Ynk6IFZhbmRpdGEgS3Vsa2FybmkgPHZhbmRpdGEua3Vsa2FybmlAaW50ZWwuY29tPgo+Pj4gLS0t
Cj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgICAgICB8IDEyICsrKysrKysr
KysrKwo+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgfCAxOSArKy0t
LS0tLS0tLS0tLS0tLS0tCj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3Iu
aCB8ICAyICstCj4+PiAgMyBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxOCBkZWxl
dGlvbnMoLSkKPj4+IAo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPj4+IGluZGV4IGNkMDFh
MDkuLjI5NDJhMjQgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
ZGkuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPj4+IEBAIC0y
ODEwLDYgKzI4MTAsMTggQEAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX2Nsa19zZWxlY3Qoc3RydWN0
IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4+PiAgCW11dGV4X2xvY2soJmRldl9wcml2LT5kcGxs
X2xvY2spOwo+Pj4gIAo+Pj4gIAlpZiAoSVNfSUNFTEFLRShkZXZfcHJpdikpIHsKPj4+ICsJCWVu
dW0gaW50ZWxfZHBsbF9pZCBpZCA9IHBsbC0+aW5mby0+aWQ7Cj4+PiArCQlpOTE1X3JlZ190IGVu
YWJsZV9yZWcgPSBpY2xfcGxsX2lkX3RvX2VuYWJsZV9yZWcoaWQpOwo+Pj4gKwo+Pj4gKwkJdmFs
ID0gSTkxNV9SRUFEKGVuYWJsZV9yZWcpOwo+Pj4gKwkJdmFsIHw9IFBMTF9FTkFCTEU7Cj4+PiAr
CQlJOTE1X1dSSVRFKGVuYWJsZV9yZWcsIHZhbCk7Cj4+PiArCj4+PiArCQkvKiBUT0RPOiB3YWl0
IHRpbWVzIG1pc3NpbmcgZnJvbSB0aGUgc3BlYy4gKi8KPj4+ICsJCWlmIChpbnRlbF93YWl0X2Zv
cl9yZWdpc3RlcihkZXZfcHJpdiwgZW5hYmxlX3JlZywgUExMX0xPQ0ssCj4+PiArCQkJCQkgICAg
UExMX0xPQ0ssIDUpKQo+Pj4gKwkJCURSTV9FUlJPUigiUExMICVkIG5vdCBsb2NrZWRcbiIsIGlk
KTsKPj4+ICsKPj4KPj4gSSBkb24ndCByZWFsbHkgc2VlIHdoeSB0aGlzIGNhbid0IHN0YXkgaW4g
dGhlIGRwbGwgbWdyLgo+Cj4gQWdyZWVkLCBJIHRoaW5rIGl0IHNob3VsZCBzdGF5IGluIERQTEwg
bWFuYWdlci4KPgo+IFRoZSB0aGluZyBpcywgRFBMTCBlbmFibGluZyBmb3IgRFNJIHJlcXVpcmVz
IGVuY29kZXIgc3BlY2lmaWMgc3RlcHMgaW4KPiB0aGUgbWlkZGxlIG9mIHRoZSBzZXF1ZW5jZSBo
aWRkZW4gaW4gRFBMTCBtYW5hZ2VyLiBJdCdzIG5vdCBwcmV0dHkgdG8KPiBhZGQgdGhhdCBpbiBE
UExMIG1hbmFnZXIuCj4KPiBPbmUgYXBwcm9hY2ggbWlnaHQgYmUgdG8gYWRkIGVuY29kZXIgaG9v
a3MgdG8gY2FsbCBmcm9tIHRoZSByaWdodCBzcG90Cj4gaW4gdGhlIERQTEwgbWFuYWdlciwgIm1p
ZF9wbGxfZW5hYmxlIi4gSXQncyBhbm5veWluZyBiZWNhdXNlIGl0IHdvdWxkCj4gaGF2ZSB0byBo
YXBwZW4gaW4gdGhlIG1pZGRsZSBvZiB0aGUgcGxhdGZvcm0gc3BlY2lmaWMgRFBMTCBtYW5hZ2Vy
Cj4gcGxsLT5pbmZvLT5mdW5jcy0+ZW5hYmxlIGhvb2suIFdlJ2QgaGF2ZSB0byBjYWxsIHRoZSBo
b29rcyBmcm9tIHBsYXRmb3JtCj4gc3BlY2lmaWMgY29kZSwgb3Igc3BsaXQgdGhvc2UgaG9va3Mg
aW4gdHdvLiBUaGUgZm9ybWVyIGlzIHVnbHkgYmVjYXVzZQo+IGl0IHJlcXVpcmVzIHBhc3Npbmcg
Y3J0YyB0byB0aGUgcGxsIGVuYWJsZSBob29rLiBTbyBJIGd1ZXNzIGFkZCBhIHBsbAo+IHBvc3Qg
ZW5hYmxlIGhvb2suCj4KPiBCZWxvdydzIHNvbWUgZHJhZnQgY29kZSB0byBnaXZlIGFuIGlkZWEg
d2hhdCBJIG1lYW4uIFlvdSdkIG1vdmUgdGhlCj4gYWJvdmUgaHVuayB0byB0aGUgcG9zdCBob29r
IGluc3RlYWQuCj4KPiBTbyB0aGVuIHdlJ2QgYWRkIG1pZF9wbGxfZW5hYmxlIGhvb2tzIGFuZCBk
byB0aGUgcmVxdWlyZWQgbWFnaWMgaW4gdGhlCj4gRFNJIG1pZCBwbGwgaG9vay4KClBTLiBBbmQg
ZXZlbiB3aXRoIHRoaXMgSSdtIG5vdCB5ZXQgc3VyZSBpZiB3ZSBjYW4gZG8gdGhlIG92ZXJhbGwg
RFBMTAplbmFibGluZyBhdCB0aGUgcmlnaHQgc3BvdCB3cnQgYnNwZWMgRFNJIG1vZGUgc2V0IHNl
cXVlbmNlLiAqY3JpbmdlKi4KCkJSLApKYW5pLgoKPgo+IE92ZXJhbGwgSSdtIHN0YXJ0aW5nIHRv
IGZlZWwgdGhlIGFwcGVhbCBvZiBkcml2aW5nIG1vZGVzZXQgZnJvbQo+IGVuY29kZXJzLCB3aXRo
IGxpYnJhcnkgc3R5bGUgaGVscGVycyBwcm92aWRlZCBmcm9tIGludGVsX2Rpc3BsYXkuYywKPiBp
bnN0ZWFkIG9mIGFkZGluZyBtb3JlIGFuZCBtb3JlIGVuY29kZXIgaG9va3MgdG8gZG8gc3R1ZmYg
YXQgc3BlY2lmaWMKPiBwbGFjZXMuIEJ1dCBJIGRpZ3Jlc3MuCj4KPiBCUiwKPiBKYW5pLgo+Cj4K
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiBpbmRleCBlNmNhYzkyMjU1MzYu
LmE0Y2ExYjRhMTI0YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
cGxsX21nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+
IEBAIC0xOTEsNiArMTkxLDEyIEBAIHZvaWQgaW50ZWxfZW5hYmxlX3NoYXJlZF9kcGxsKHN0cnVj
dCBpbnRlbF9jcnRjICpjcnRjKQo+ICAKPiAgCURSTV9ERUJVR19LTVMoImVuYWJsaW5nICVzXG4i
LCBwbGwtPmluZm8tPm5hbWUpOwo+ICAJcGxsLT5pbmZvLT5mdW5jcy0+ZW5hYmxlKGRldl9wcml2
LCBwbGwpOwo+ICsKPiArCWludGVsX2VuY29kZXJzX21pZF9wbGxfZW5hYmxlKGNydGMpOyAvKiBw
aXBlX2NvbmZpZywgb2xkX3N0YXRlPyAqLwo+ICsKPiArCWlmIChwbGwtPmluZm8tPmZ1bmNzLT5w
b3N0X2VuYWJsZSkKPiArCQlwbGwtPmluZm8tPmZ1bmNzLT5wb3N0X2VuYWJsZShkZXZfcHJpdiwg
cGxsKTsKPiArCj4gIAlwbGwtPm9uID0gdHJ1ZTsKPiAgCj4gIG91dDoKPiBAQCAtMzE5OSw2ICsz
MjA1LDcgQEAgc3RhdGljIHZvaWQgaWNsX2R1bXBfaHdfc3RhdGUoc3RydWN0IGRybV9pOTE1X3By
aXZhdGUgKmRldl9wcml2LAo+ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBpbnRlbF9zaGFyZWRf
ZHBsbF9mdW5jcyBpY2xfcGxsX2Z1bmNzID0gewo+ICAJLmVuYWJsZSA9IGljbF9wbGxfZW5hYmxl
LAo+ICsJLnBvc3RfZW5hYmxlID0gaWNsX3BsbF9wb3N0X2VuYWJsZSwKPiAgCS5kaXNhYmxlID0g
aWNsX3BsbF9kaXNhYmxlLAo+ICAJLmdldF9od19zdGF0ZSA9IGljbF9wbGxfZ2V0X2h3X3N0YXRl
LAo+ICB9Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21n
ci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+IGluZGV4IGJmMGRl
OGE0ZGM2My4uZWNlZWVmM2I4ODcyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX2RwbGxfbWdyLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxs
X21nci5oCj4gQEAgLTIzMSw2ICsyMzEsMTYgQEAgc3RydWN0IGludGVsX3NoYXJlZF9kcGxsX2Z1
bmNzIHsKPiAgCQkgICAgICAgc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpwbGwpOwo+ICAKPiAg
CS8qKgo+ICsJICogQHBvc3RfZW5hYmxlOgo+ICsJICoKPiArCSAqIE9wdGlvbmFsIGhvb2sgdG8g
Y2FsbCBhZnRlciBlbmNvZGVyIHNwZWNpZmljIG1pZCBwbGwgaG9va3MgaGF2ZSBiZWVuCj4gKwkg
KiBjYWxsZWQgZnJvbSBpbnRlbF9lbmFibGVfc2hhcmVkX2RwbGwoKS4KPiArCSAqLwo+ICsJdm9p
ZCAoKnBvc3RfZW5hYmxlKShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJ
CSAgICBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbCk7Cj4gKwo+ICsKPiArCS8qKgo+ICAJ
ICogQGRpc2FibGU6Cj4gIAkgKgo+ICAJICogSG9vayBmb3IgZGlzYWJsaW5nIHRoZSBwbGwsIGNh
bGxlZCBmcm9tIGludGVsX2Rpc2FibGVfc2hhcmVkX2RwbGwoKQoKLS0gCkphbmkgTmlrdWxhLCBJ
bnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA
bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==