From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915: Double check we didn't miss an unclaimed register access Date: Tue, 04 Sep 2018 15:34:12 +0300 Message-ID: <87musx5tmj.fsf@gaia.fi.intel.com> References: <20180904111732.24266-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B9426E3CB for ; Tue, 4 Sep 2018 12:34:21 +0000 (UTC) In-Reply-To: <20180904111732.24266-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQ3VycmVu dGx5LCBpZiB0aGUgdXNlciBoYXMgZW5hYmxlZCBtbWlvLWRlYnVnIGFyb3VuZCBlYWNoIHJlZ2lz dGVyCj4gYWNjZXNzLCB3ZSBwcmVzdW1lIHRoYXQgd2UgaGF2ZSB0aGVuIGNoZWNrZWQgdGhlbSBh bGwuIEhvd2V2ZXIsIGl0IGlzCj4gc3RpbGwgcG9zc2libGUgdGhyb3VnaCBvbWlzc2lvbiAocmF3 IHJlZ2lzdGVyIGFjY2Vzcykgb3IgZXh0ZXJuYWwKPiBpbnRlcmFjdGlvbiB0aGF0IHRoZSB1bmNs YWltZWQgYWNjZXNzIHdhcyBub3QgaGlnaGxpZ2h0ZWQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWlrYSBLdW9wcGFsYSA8 bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3VuY29yZS5jIHwgMTMgKysrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg NyBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf dW5jb3JlLmMKPiBpbmRleCAyMGYyZjVhZDljM2YuLjA1ZjBjZGExODUwMSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4gQEAgLTIyODMsMTUgKzIyODMsMTYgQEAgYm9vbCBp bnRlbF91bmNvcmVfdW5jbGFpbWVkX21taW8oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ICBib29sCj4gIGludGVsX3VuY29yZV9hcm1fdW5jbGFpbWVkX21taW9fZGV0ZWN0aW9u KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+IC0JaWYgKHVubGlrZWx5 KGk5MTVfbW9kcGFyYW1zLm1taW9fZGVidWcgfHwKPiAtCQkgICAgIGRldl9wcml2LT51bmNvcmUu dW5jbGFpbWVkX21taW9fY2hlY2sgPD0gMCkpCj4gKwlpZiAodW5saWtlbHkoZGV2X3ByaXYtPnVu Y29yZS51bmNsYWltZWRfbW1pb19jaGVjayA8PSAwKSkKPiAgCQlyZXR1cm4gZmFsc2U7Cj4KCldl IGNvdWxkIGNhdGNoIHRoZSByZWFkZXJzIGF0dGVudGlvbiBieSBtYXJraW5nIHRoaXMgYXMgUkVB RF9PTkNFLgoKCkFuZCB0aGVuIHRha2Ugc3BpbmxvY2sgaGVyZSBiZWZvcmUgY2hlY2tpbmcgZm9y IHVuY2xhaW1lZC4KCldlIHBva2UgaGVyZSBmcm9tIGhhbmdjaGVjayBhdCB1bmtub3duIGludGVy dmFscyBhbmQgSSBhbQpjb25jZXJuZWQgYm90aCB0aGUgdHJhbXBsaW5nIG9uIHRoZSBjaGVjayB2 YWx1ZXMgYW5kIGFsc28KdGhlIHJlZ2lzdGVyIGFjY2VzcyBvZiB0aGUgdW5jbGFpbWVkIGRlYnVn IHJlZ3MuCgpXaGljaCBhbHNvIHJhaXNlcyB0aGUgcXVlc3Rpb24gdGhhdCBzaG91bGQgd2UganVz dCBtb3ZlCnRoZSBhcm1pbmcgY2hlY2sgdG8gcGFyay91bnBhcms/CgotTWlrYQoKPiAgCWlmICh1 bmxpa2VseShpbnRlbF91bmNvcmVfdW5jbGFpbWVkX21taW8oZGV2X3ByaXYpKSkgewo+IC0JCURS TV9ERUJVRygiVW5jbGFpbWVkIHJlZ2lzdGVyIGRldGVjdGVkLCAiCj4gLQkJCSAgImVuYWJsaW5n IG9uZXNob3QgdW5jbGFpbWVkIHJlZ2lzdGVyIHJlcG9ydGluZy4gIgo+IC0JCQkgICJQbGVhc2Ug dXNlIGk5MTUubW1pb19kZWJ1Zz1OIGZvciBtb3JlIGluZm9ybWF0aW9uLlxuIik7Cj4gLQkJaTkx NV9tb2RwYXJhbXMubW1pb19kZWJ1ZysrOwo+ICsJCWlmICghaTkxNV9tb2RwYXJhbXMubW1pb19k ZWJ1Zykgewo+ICsJCQlEUk1fREVCVUcoIlVuY2xhaW1lZCByZWdpc3RlciBkZXRlY3RlZCwgIgo+ ICsJCQkJICAiZW5hYmxpbmcgb25lc2hvdCB1bmNsYWltZWQgcmVnaXN0ZXIgcmVwb3J0aW5nLiAi Cj4gKwkJCQkgICJQbGVhc2UgdXNlIGk5MTUubW1pb19kZWJ1Zz1OIGZvciBtb3JlIGluZm9ybWF0 aW9uLlxuIik7Cj4gKwkJCWk5MTVfbW9kcGFyYW1zLm1taW9fZGVidWcrKzsKPiArCQl9Cj4gIAkJ ZGV2X3ByaXYtPnVuY29yZS51bmNsYWltZWRfbW1pb19jaGVjay0tOwo+ICAJCXJldHVybiB0cnVl Owo+ICAJfQo+IC0tIAo+IDIuMTkuMC5yYzEKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==